Re: WARNING in crypto_wait_for_test

2015-12-20 Thread Stephan Mueller
Am Freitag, 18. Dezember 2015, 19:16:57 schrieb Herbert Xu: Hi Herbert, > On Fri, Dec 18, 2015 at 04:49:17PM +0800, Herbert Xu wrote: > > OK turns out I was looking at the wrong WARN_ON line. > > > > This particular bug is a legacy of the geniv construct we have > > for ablkcipher. > > > > It

Re: WARNING in crypto_wait_for_test

2015-12-20 Thread Stephan Mueller
Am Freitag, 18. Dezember 2015, 19:16:57 schrieb Herbert Xu: Hi Herbert, > On Fri, Dec 18, 2015 at 04:49:17PM +0800, Herbert Xu wrote: > > OK turns out I was looking at the wrong WARN_ON line. > > > > This particular bug is a legacy of the geniv construct we have > > for ablkcipher. > > > > It

Re: WARNING in crypto_wait_for_test

2015-12-18 Thread Herbert Xu
On Fri, Dec 18, 2015 at 04:49:17PM +0800, Herbert Xu wrote: > > OK turns out I was looking at the wrong WARN_ON line. > > This particular bug is a legacy of the geniv construct we have > for ablkcipher. > > It should disappear once we remove geniv which I will do as part > of the skcipher

Re: WARNING in crypto_wait_for_test

2015-12-18 Thread Herbert Xu
On Mon, Dec 14, 2015 at 11:45:02PM +0100, Stephan Mueller wrote: > > But with the given code, when you remove the bogus mask setting (which in > turn > leaves it as 0), the code works flawless. OK turns out I was looking at the wrong WARN_ON line. This particular bug is a legacy of the geniv

Re: WARNING in crypto_wait_for_test

2015-12-18 Thread Herbert Xu
On Mon, Dec 14, 2015 at 11:45:02PM +0100, Stephan Mueller wrote: > > But with the given code, when you remove the bogus mask setting (which in > turn > leaves it as 0), the code works flawless. OK turns out I was looking at the wrong WARN_ON line. This particular bug is a legacy of the geniv

Re: WARNING in crypto_wait_for_test

2015-12-18 Thread Herbert Xu
On Fri, Dec 18, 2015 at 04:49:17PM +0800, Herbert Xu wrote: > > OK turns out I was looking at the wrong WARN_ON line. > > This particular bug is a legacy of the geniv construct we have > for ablkcipher. > > It should disappear once we remove geniv which I will do as part > of the skcipher

Re: WARNING in crypto_wait_for_test

2015-12-14 Thread Herbert Xu
On Mon, Dec 14, 2015 at 11:45:02PM +0100, Stephan Mueller wrote: > > But with the given code, when you remove the bogus mask setting (which in > turn > leaves it as 0), the code works flawless. Please find out exactly why this would be triggering the warning because your previous explanation of

Re: WARNING in crypto_wait_for_test

2015-12-14 Thread Stephan Mueller
Am Montag, 14. Dezember 2015, 20:52:19 schrieb Herbert Xu: Hi Herbert, >On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: >> Herbert, alg_bind currently blacklists one bit in the mask and type bit >> array. Shouldn't we instead white-list the allowed bits? > >Well a bogus mask

Re: WARNING in crypto_wait_for_test

2015-12-14 Thread Herbert Xu
On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: > > Herbert, alg_bind currently blacklists one bit in the mask and type bit > array. > Shouldn't we instead white-list the allowed bits? Well a bogus mask shouldn't lead to the warning anyway. The warning in question is triggered

Re: WARNING in crypto_wait_for_test

2015-12-14 Thread Herbert Xu
On Mon, Dec 14, 2015 at 11:45:02PM +0100, Stephan Mueller wrote: > > But with the given code, when you remove the bogus mask setting (which in > turn > leaves it as 0), the code works flawless. Please find out exactly why this would be triggering the warning because your previous explanation of

Re: WARNING in crypto_wait_for_test

2015-12-14 Thread Herbert Xu
On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: > > Herbert, alg_bind currently blacklists one bit in the mask and type bit > array. > Shouldn't we instead white-list the allowed bits? Well a bogus mask shouldn't lead to the warning anyway. The warning in question is triggered

Re: WARNING in crypto_wait_for_test

2015-12-14 Thread Stephan Mueller
Am Montag, 14. Dezember 2015, 20:52:19 schrieb Herbert Xu: Hi Herbert, >On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: >> Herbert, alg_bind currently blacklists one bit in the mask and type bit >> array. Shouldn't we instead white-list the allowed bits? > >Well a bogus mask

Re: WARNING in crypto_wait_for_test

2015-12-10 Thread Stephan Mueller
Am Dienstag, 8. Dezember 2015, 12:12:27 schrieb Dmitry Vyukov: Hi Dmitry, >Hello, > >The following program triggers a WARNING in crypto_wait_for_test: > >// autogenerated by syzkaller (http://github.com/google/syzkaller) >#include >#include >#include > >int main() >{ >long r0 =

Re: WARNING in crypto_wait_for_test

2015-12-10 Thread Stephan Mueller
Am Dienstag, 8. Dezember 2015, 12:12:27 schrieb Dmitry Vyukov: Hi Dmitry, >Hello, > >The following program triggers a WARNING in crypto_wait_for_test: > >// autogenerated by syzkaller (http://github.com/google/syzkaller) >#include >#include >#include > >int main() >{ >long r0 =