Re: WARNING in event_function_local

2019-02-13 Thread Peter Zijlstra
On Wed, Feb 13, 2019 at 10:57:26AM +0100, Peter Zijlstra wrote: > On Wed, Feb 13, 2019 at 10:51:58AM +0100, Peter Zijlstra wrote: > > On Tue, Feb 12, 2019 at 07:40:12PM -0800, Kees Cook wrote: > > > > > > > Is this maybe just an unlucky condition with the event loop running in > > > > > an IRQ? Sh

Re: WARNING in event_function_local

2019-02-13 Thread Peter Zijlstra
On Wed, Feb 13, 2019 at 10:51:58AM +0100, Peter Zijlstra wrote: > On Tue, Feb 12, 2019 at 07:40:12PM -0800, Kees Cook wrote: > > > > > Is this maybe just an unlucky condition with the event loop running in > > > > an IRQ? Should the WARN be expected, or is running under an IRQ > > > > unexpected?

Re: WARNING in event_function_local

2019-02-13 Thread Peter Zijlstra
On Tue, Feb 12, 2019 at 07:40:12PM -0800, Kees Cook wrote: > > > Is this maybe just an unlucky condition with the event loop running in > > > an IRQ? Should the WARN be expected, or is running under an IRQ > > > unexpected? > > Is perf expected to fire during an IRQ? The task == current test seem

Re: WARNING in event_function_local

2019-02-12 Thread Steven Rostedt
On Tue, 12 Feb 2019 19:40:12 -0800 Kees Cook wrote: > > > Steve, what could possibly be happening here? Just adding more > > > tracepoints causes some kind of race where the task vs current test > > > trips in event_function_local(): > > > > > > if (WARN_ON_ONCE(task !=

Re: WARNING in event_function_local

2019-02-12 Thread Kees Cook
On Tue, Feb 12, 2019 at 6:14 PM Steven Rostedt wrote: > On Tue, 12 Feb 2019 17:27:56 -0800 > Kees Cook wrote: > > > On Wed, May 9, 2018 at 10:18 PM Dmitry Vyukov wrote: > > > > > > On Sat, Jan 27, 2018 at 8:58 PM, syzbot > > > wrote: > > > > Hello, > > > > > > > > syzbot hit the following crash

Re: WARNING in event_function_local

2019-02-12 Thread Steven Rostedt
On Tue, 12 Feb 2019 17:27:56 -0800 Kees Cook wrote: > On Wed, May 9, 2018 at 10:18 PM Dmitry Vyukov wrote: > > > > On Sat, Jan 27, 2018 at 8:58 PM, syzbot > > wrote: > > > Hello, > > > > > > syzbot hit the following crash on bpf-next commit > > > 8223967fe0b8eb2448cca5cfe3c64a0838e6f60d (Sat

Re: WARNING in event_function_local

2019-02-12 Thread Kees Cook
On Wed, May 9, 2018 at 10:18 PM Dmitry Vyukov wrote: > > On Sat, Jan 27, 2018 at 8:58 PM, syzbot > wrote: > > Hello, > > > > syzbot hit the following crash on bpf-next commit > > 8223967fe0b8eb2448cca5cfe3c64a0838e6f60d (Sat Jan 27 01:06:23 2018 +) > > Merge branch 'fix-lpm-map' > > > > So fa

Re: WARNING in event_function_local

2018-05-09 Thread Dmitry Vyukov
On Sat, Jan 27, 2018 at 8:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 8223967fe0b8eb2448cca5cfe3c64a0838e6f60d (Sat Jan 27 01:06:23 2018 +) > Merge branch 'fix-lpm-map' > > So far this crash happened 2 times on bpf-next. > C reproducer is attached. > s