Re: asm-generic: Disallow no-op mb() for SMP systems

On Sat, Feb 03, 2018 at 03:14:01AM +0800, kbuild test robot wrote: > Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on asm-generic/master] > [also build test ERROR on v4.15 next-20180202] > [if your patch is applied to the wrong git tree, please drop us a

Re: asm-generic: Disallow no-op mb() for SMP systems

On Sat, Feb 03, 2018 at 03:14:01AM +0800, kbuild test robot wrote: > Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on asm-generic/master] > [also build test ERROR on v4.15 next-20180202] > [if your patch is applied to the wrong git tree, please drop us a

Re: asm-generic: Disallow no-op mb() for SMP systems

On Fri, Feb 02, 2018 at 09:08:20PM +, Alan Cox wrote: > On Fri, 2 Feb 2018 21:25:49 +0100 > Peter Zijlstra wrote: > > > On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > > > Hi Peter, > > > > > > I love your patch! Yet something to improve: > > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Fri, Feb 02, 2018 at 09:08:20PM +, Alan Cox wrote: > On Fri, 2 Feb 2018 21:25:49 +0100 > Peter Zijlstra wrote: > > > On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > > > Hi Peter, > > > > > > I love your patch! Yet something to improve: > > > > Seriously? Bots have

Re: asm-generic: Disallow no-op mb() for SMP systems

On Fri, 2 Feb 2018 21:25:49 +0100 Peter Zijlstra wrote: > On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > I love your patch! Yet something to improve: > > Seriously? Bots have feelings? > > > [auto build test ERROR on

Re: asm-generic: Disallow no-op mb() for SMP systems

On Fri, 2 Feb 2018 21:25:49 +0100 Peter Zijlstra wrote: > On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > I love your patch! Yet something to improve: > > Seriously? Bots have feelings? > > > [auto build test ERROR on asm-generic/master] > > [also

Re: asm-generic: Disallow no-op mb() for SMP systems

On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > Hi Peter, > > I love your patch! Yet something to improve: Seriously? Bots have feelings? > [auto build test ERROR on asm-generic/master] > [also build test ERROR on v4.15 next-20180202] > [if your patch is applied to the

Re: asm-generic: Disallow no-op mb() for SMP systems

On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > Hi Peter, > > I love your patch! Yet something to improve: Seriously? Bots have feelings? > [auto build test ERROR on asm-generic/master] > [also build test ERROR on v4.15 next-20180202] > [if your patch is applied to the

Re: asm-generic: Disallow no-op mb() for SMP systems

Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: asm-generic: Disallow no-op mb() for SMP systems

Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: asm-generic: Disallow no-op mb() for SMP systems

Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: asm-generic: Disallow no-op mb() for SMP systems

Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > some of > > the techniques we used for the SMP implementation. Its probably not > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > some of > > the techniques we used for the SMP implementation. Its probably not > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 04:50:07PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 03:39:51PM +, Will Deacon wrote: > > > I could've gotten my brain in a twist or course, which isn't _that_ > > > unusual. I never seem to be able to quite remember the holes you have > > > with ll/sc on

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 04:50:07PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 03:39:51PM +, Will Deacon wrote: > > > I could've gotten my brain in a twist or course, which isn't _that_ > > > unusual. I never seem to be able to quite remember the holes you have > > > with ll/sc on

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 03:39:51PM +, Will Deacon wrote: > > I could've gotten my brain in a twist or course, which isn't _that_ > > unusual. I never seem to be able to quite remember the holes you have > > with ll/sc on arm64 :-) > > Is smp_mb__before_atomic supposed to provide ordering

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 03:39:51PM +, Will Deacon wrote: > > I could've gotten my brain in a twist or course, which isn't _that_ > > unusual. I never seem to be able to quite remember the holes you have > > with ll/sc on arm64 :-) > > Is smp_mb__before_atomic supposed to provide ordering

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 02:53:29PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 01:32:30PM +, Will Deacon wrote: > > On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > > > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > > > I tried to clarify some

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 02:53:29PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 01:32:30PM +, Will Deacon wrote: > > On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > > > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > > > I tried to clarify some

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 01:32:30PM +, Will Deacon wrote: > On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > > some of > > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 01:32:30PM +, Will Deacon wrote: > On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > > some of > > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > some of > > the techniques we used for the SMP implementation. Its probably not > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > some of > > the techniques we used for the SMP implementation. Its probably not > >

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > I tried to clarify some of this in the spec v1.2 [0] which help formalize > some of > the techniques we used for the SMP implementation. Its probably not perfect, > but I added a section "10. Multicore support" and tried to

Re: asm-generic: Disallow no-op mb() for SMP systems

On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > I tried to clarify some of this in the spec v1.2 [0] which help formalize > some of > the techniques we used for the SMP implementation. Its probably not perfect, > but I added a section "10. Multicore support" and tried to

Re: asm-generic: Disallow no-op mb() for SMP systems

On Wed, Jan 31, 2018 at 02:26:10PM +0100, Peter Zijlstra wrote: > On Wed, Jan 31, 2018 at 01:17:37PM +, Will Deacon wrote: > > On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > > > > > While looking through the qspinlock users, I stumbled upon openrisc and > > > being

Re: asm-generic: Disallow no-op mb() for SMP systems

On Wed, Jan 31, 2018 at 02:26:10PM +0100, Peter Zijlstra wrote: > On Wed, Jan 31, 2018 at 01:17:37PM +, Will Deacon wrote: > > On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > > > > > While looking through the qspinlock users, I stumbled upon openrisc and > > > being

Re: asm-generic: Disallow no-op mb() for SMP systems

On Wed, Jan 31, 2018 at 01:17:37PM +, Will Deacon wrote: > On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > > > While looking through the qspinlock users, I stumbled upon openrisc and > > being curious, I wanted to have a look at its memory model. > > > > To my surprise it

Re: asm-generic: Disallow no-op mb() for SMP systems

On Wed, Jan 31, 2018 at 01:17:37PM +, Will Deacon wrote: > On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > > > While looking through the qspinlock users, I stumbled upon openrisc and > > being curious, I wanted to have a look at its memory model. > > > > To my surprise it

Re: asm-generic: Disallow no-op mb() for SMP systems

On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > While looking through the qspinlock users, I stumbled upon openrisc and > being curious, I wanted to have a look at its memory model. > > To my surprise it doesn't have asm/barrier.h. It does however support > SMP. This lead me

Re: asm-generic: Disallow no-op mb() for SMP systems

On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > While looking through the qspinlock users, I stumbled upon openrisc and > being curious, I wanted to have a look at its memory model. > > To my surprise it doesn't have asm/barrier.h. It does however support > SMP. This lead me