Re: avoiding rejects

2007-07-11 Thread Jan Engelhardt
On Jul 10 2007 12:44, Andrew Morton wrote: > >There are many situations where patching the kernel involves adding a new >item to a list, such as: > >- adding a makefile line >- adding a new #include >- adding a new Kconfig entry >- adding a new PCI ID >- adding a record to feature-removal.txt >-

Re: avoiding rejects

2007-07-11 Thread Boaz Harrosh
Andrew Morton wrote: > > Most of these lists are unordered anyway, so inserting the new item at a > randomly-chosen position is a better approach than just appending it. > - But you have lost the order you have just stated. "Order by time of addition" ascending ;) Sometimes what I do is a diff

Re: avoiding rejects

2007-07-11 Thread Boaz Harrosh
Andrew Morton wrote: Most of these lists are unordered anyway, so inserting the new item at a randomly-chosen position is a better approach than just appending it. - But you have lost the order you have just stated. Order by time of addition ascending ;) Sometimes what I do is a diff with

Re: avoiding rejects

2007-07-11 Thread Jan Engelhardt
On Jul 10 2007 12:44, Andrew Morton wrote: There are many situations where patching the kernel involves adding a new item to a list, such as: - adding a makefile line - adding a new #include - adding a new Kconfig entry - adding a new PCI ID - adding a record to feature-removal.txt - adding a

Re: avoiding rejects

2007-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2007, Geert Uytterhoeven wrote: > > > Most of these lists are unordered anyway, so inserting the new item at a > > randomly-chosen position is a better approach than just appending it. > > Really? > > #includes should be sorted alphabetically > Lots of other stuff should be

Re: avoiding rejects

2007-07-10 Thread Geert Uytterhoeven
On Tue, 10 Jul 2007, Andrew Morton wrote: > There are many situations where patching the kernel involves adding a new > item to a list, such as: > > - adding a makefile line > - adding a new #include > - adding a new Kconfig entry > - adding a new PCI ID > - adding a record to feature-removal.txt

Re: avoiding rejects

2007-07-10 Thread Dan Aloni
On Tue, Jul 10, 2007 at 12:44:22PM -0700, Andrew Morton wrote: > > There are many situations where patching the kernel involves adding a new > item to a list, such as: > > - adding a makefile line > - adding a new #include > - adding a new Kconfig entry > - adding a new PCI ID > - adding a

Re: avoiding rejects

2007-07-10 Thread Dan Aloni
On Tue, Jul 10, 2007 at 12:44:22PM -0700, Andrew Morton wrote: There are many situations where patching the kernel involves adding a new item to a list, such as: - adding a makefile line - adding a new #include - adding a new Kconfig entry - adding a new PCI ID - adding a record to

Re: avoiding rejects

2007-07-10 Thread Geert Uytterhoeven
On Tue, 10 Jul 2007, Andrew Morton wrote: There are many situations where patching the kernel involves adding a new item to a list, such as: - adding a makefile line - adding a new #include - adding a new Kconfig entry - adding a new PCI ID - adding a record to feature-removal.txt -

Re: avoiding rejects

2007-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2007, Geert Uytterhoeven wrote: Most of these lists are unordered anyway, so inserting the new item at a randomly-chosen position is a better approach than just appending it. Really? #includes should be sorted alphabetically Lots of other stuff should be sorted