>> Do you find proposed spelling corrections useful?
>
> To commit messages? No.
Are you really going to tolerate wording weaknesses there?
https://lore.kernel.org/linux-block/20200605104558.16686-1-yanai...@huawei.com/
https://lore.kernel.org/patchwork/patch/1252648/
> You do not seem to
On Fri, Jun 05, 2020 at 03:12:08PM +0200, Markus Elfring wrote:
> > Your feedback is unhelpful
>
> Do you find proposed spelling corrections useful?
To commit messages? No.
> > and you show no signs of changing it in response to the people
> > who are telling you that it's unhelpful.
>
>
> Maintainers generally do change commit messages to improve them,
> if needed.
You have got a documented choice here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=435faf5c218a47fd6258187f62d9bb1009717896#n468
Regards,
> Your feedback is unhelpful
Do you find proposed spelling corrections useful?
> and you show no signs of changing it in response to the people
> who are telling you that it's unhelpful.
Other adjustments can occasionally be more challenging
besides the usual communication challenges.
On 6/5/20 7:01 AM, Markus Elfring wrote:
>>> The details can vary also for my suggestions.
>>> Would you point any more disagreements out on concrete items?
>>
>> That's exactly the problem with many of your comments.
>> They're vague to the point of unintelligibility.
>
> Was is so vague about
>> The details can vary also for my suggestions.
>> Would you point any more disagreements out on concrete items?
>
> That's exactly the problem with many of your comments.
> They're vague to the point of unintelligibility.
Was is so vague about possibilities which I point out for patch reviews
>> The details can vary also for my suggestions.
>> Would you point any more disagreements out on concrete items?
>
> That's exactly the problem with many of your comments.
> They're vague to the point of unintelligibility.
Was is so vague about possibilities which I point out for patch reviews
On Fri, Jun 05, 2020 at 02:47:00PM +0200, Markus Elfring wrote:
> >> Some developers found parts of my reviews helpful, didn't they?
> >
> > Overall you are a net negative to kernel development.
>
> Which concrete items do you like less here?
Your feedback is unhelpful and you show no signs of
>> Some developers found parts of my reviews helpful, didn't they?
>
> Overall you are a net negative to kernel development.
Which concrete items do you like less here?
> Please change how you contribute.
I am curious to find the details out which might hinder progress
in desirable directions
On Fri, Jun 05, 2020 at 01:48:43PM +0200, Markus Elfring wrote:
> >> I am trying to contribute a bit of patch review as usual.
> >
> > Please stop criticising people's commit messages. Your suggestions
> > are usually not improvements.
>
> The details can vary also for my suggestions.
> Would
>> I am trying to contribute a bit of patch review as usual.
>
> Please stop criticising people's commit messages. Your suggestions
> are usually not improvements.
The details can vary also for my suggestions.
Would you point any more disagreemnents out on concrete items?
> But refcount ->
On Fri, Jun 05, 2020 at 01:40:37PM +0200, Markus Elfring wrote:
> >> I am trying to contribute a bit of patch review as usual.
> >
> > We have asked you again and again to stop commenting on commit messages.
>
> I am going to continue with constructive feedback at some places.
>
>
> > New
>> I am trying to contribute a bit of patch review as usual.
>
> We have asked you again and again to stop commenting on commit messages.
I am going to continue with constructive feedback at some places.
> New kernel developers have emailed me privately to say that your review
> comments
13 matches
Mail list logo
