From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Thu, 8 Nov 2007 04:30:10 +0100
> @davem:
>
> Please look at net/ipv4/arp.c:arp_process()
>
> Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
> CONFIG_NETDEV_1=y will not be handled correctly there?
>
> And the best solution is
From: Adrian Bunk [EMAIL PROTECTED]
Date: Thu, 8 Nov 2007 04:30:10 +0100
@davem:
Please look at net/ipv4/arp.c:arp_process()
Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
CONFIG_NETDEV_1=y will not be handled correctly there?
And the best solution is to nuke
On Thu, 8 Nov 2007 04:30:10 +0100 Adrian Bunk wrote:
> On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote:
> > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > > > But on the other hand, it seems that only the ASIX code will work
> > > > > right; the DM9601 and
On Thu, 8 Nov 2007 04:30:10 +0100 Adrian Bunk wrote:
On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote:
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
But on the other hand, it seems that only the ASIX code will work
right; the DM9601 and MCS7830 Kconfig is
On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote:
> On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > > But on the other hand, it seems that only the ASIX code will work
> > > > right; the DM9601 and MCS7830 Kconfig is different/wrong.
> > >
> > > I'm not seeing the
On Wed, Nov 07, 2007 at 06:53:48PM -0800, David Brownell wrote:
> On Wednesday 07 November 2007, Adrian Bunk wrote:
> > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > > > But on the other hand, it seems that only the ASIX code will work
> > > > > right; the DM9601 and
On Wednesday 07 November 2007, Adrian Bunk wrote:
> On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > > But on the other hand, it seems that only the ASIX code will work
> > > > right; the DM9601 and MCS7830 Kconfig is different/wrong.
> > >
> > > I'm not seeing the problem.
>
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > But on the other hand, it seems that only the ASIX code will work
> > > right; the DM9601 and MCS7830 Kconfig is different/wrong.
> >
> > I'm not seeing the problem.
> >
> > Which configuration will be handled wrongly?
>
>
> > But on the other hand, it seems that only the ASIX code will work
> > right; the DM9601 and MCS7830 Kconfig is different/wrong.
>
> I'm not seeing the problem.
>
> Which configuration will be handled wrongly?
Notice how only the ASIX kconfig depended on NET_ETHERNET...
since MII depends on
On Wednesday 07 November 2007, David Miller wrote:
> David, I hate to say this and point you out like this, but you are a
> real cancer for bug fixes to USB things in the kernel,
You didn't hate it enough to find a way to deal with your issue
that doesn't involve namecalling or other flamage,
David, I hate to say this and point you out like this, but you are a
real cancer for bug fixes to USB things in the kernel, and I'm very
tired of seeing things stuck in the mud (and engineering resources
wasted) because of how you handle things. It's very bad for Linux,
and the USB code in
David, I hate to say this and point you out like this, but you are a
real cancer for bug fixes to USB things in the kernel, and I'm very
tired of seeing things stuck in the mud (and engineering resources
wasted) because of how you handle things. It's very bad for Linux,
and the USB code in
On Wednesday 07 November 2007, David Miller wrote:
David, I hate to say this and point you out like this, but you are a
real cancer for bug fixes to USB things in the kernel,
You didn't hate it enough to find a way to deal with your issue
that doesn't involve namecalling or other flamage, I'll
But on the other hand, it seems that only the ASIX code will work
right; the DM9601 and MCS7830 Kconfig is different/wrong.
I'm not seeing the problem.
Which configuration will be handled wrongly?
Notice how only the ASIX kconfig depended on NET_ETHERNET...
since MII depends on
On Wed, Nov 07, 2007 at 06:53:48PM -0800, David Brownell wrote:
On Wednesday 07 November 2007, Adrian Bunk wrote:
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
But on the other hand, it seems that only the ASIX code will work
right; the DM9601 and MCS7830 Kconfig is
On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote:
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
But on the other hand, it seems that only the ASIX code will work
right; the DM9601 and MCS7830 Kconfig is different/wrong.
I'm not seeing the problem.
On Wednesday 07 November 2007, Adrian Bunk wrote:
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
But on the other hand, it seems that only the ASIX code will work
right; the DM9601 and MCS7830 Kconfig is different/wrong.
I'm not seeing the problem.
Which
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
But on the other hand, it seems that only the ASIX code will work
right; the DM9601 and MCS7830 Kconfig is different/wrong.
I'm not seeing the problem.
Which configuration will be handled wrongly?
Notice how only
On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote:
>...
> --- a.orig/drivers/net/usb/usbnet.c 2007-10-13 15:16:10.0 -0700
> +++ a/drivers/net/usb/usbnet.c2007-11-02 11:39:59.0 -0700
> @@ -682,10 +682,17 @@ done_nopm:
> /* ethtool methods; minidrivers may
On Fri, Nov 02, 2007 at 12:30:22PM -0700, David Brownell wrote:
> On Friday 02 November 2007, Adrian Bunk wrote:
> > This approach has two disadvantages:
> > - it's complicated
>
> No more so than the problem itself.
>
>
> > - the MII stuff is an implementation detail, and we shouldn't bother
>
On Friday 02 November 2007, Adrian Bunk wrote:
> This approach has two disadvantages:
> - it's complicated
No more so than the problem itself.
> - the MII stuff is an implementation detail, and we shouldn't bother
> the user with it (especially since we can do better)
That's a Kconfig policy
On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote:
> On Thursday 01 November 2007, Adrian Bunk wrote:
> > The following combination of options is simply an unusual one:
> >
> > CONFIG_MII=m
> > CONFIG_USB_USBNET=y
> > CONFIG_USB_USBNET_MII=n
>
> I though that had been fixed for ages
On Thursday 01 November 2007, Adrian Bunk wrote:
> The following combination of options is simply an unusual one:
>
> CONFIG_MII=m
> CONFIG_USB_USBNET=y
> CONFIG_USB_USBNET_MII=n
I though that had been fixed for ages ...
This should do a better job of it.
- Dave
== CUT HERE
On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote:
On Thursday 01 November 2007, Adrian Bunk wrote:
The following combination of options is simply an unusual one:
CONFIG_MII=m
CONFIG_USB_USBNET=y
CONFIG_USB_USBNET_MII=n
I though that had been fixed for ages ...
This
On Thursday 01 November 2007, Adrian Bunk wrote:
The following combination of options is simply an unusual one:
CONFIG_MII=m
CONFIG_USB_USBNET=y
CONFIG_USB_USBNET_MII=n
I though that had been fixed for ages ...
This should do a better job of it.
- Dave
== CUT HERE
Simplify
On Friday 02 November 2007, Adrian Bunk wrote:
This approach has two disadvantages:
- it's complicated
No more so than the problem itself.
- the MII stuff is an implementation detail, and we shouldn't bother
the user with it (especially since we can do better)
That's a Kconfig policy
On Fri, Nov 02, 2007 at 12:30:22PM -0700, David Brownell wrote:
On Friday 02 November 2007, Adrian Bunk wrote:
This approach has two disadvantages:
- it's complicated
No more so than the problem itself.
- the MII stuff is an implementation detail, and we shouldn't bother
the user
On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote:
...
--- a.orig/drivers/net/usb/usbnet.c 2007-10-13 15:16:10.0 -0700
+++ a/drivers/net/usb/usbnet.c2007-11-02 11:39:59.0 -0700
@@ -682,10 +682,17 @@ done_nopm:
/* ethtool methods; minidrivers may need to
On Thu, Nov 01, 2007 at 04:32:18PM -0700, David Brownell wrote:
> On Thursday 01 November 2007, Randy Dunlap wrote:
> > The MII functions aren't available unless NET_ETHERNET=y.
The setting of CONFIG_NET_ETHERNET doesn't matter for this bug.
> > Howver, the MII functions aren't always needed...
On Thursday 01 November 2007, Randy Dunlap wrote:
> The MII functions aren't available unless NET_ETHERNET=y.
> Howver, the MII functions aren't always needed...
>
> David, any ideas on this one?
It's been several years since I looked at this. It
used to behave just fine.
Something must have
On Thu, 1 Nov 2007 20:24:54 +0100 Toralf Förster wrote:
[adding netdev]
> Hello,
>
> the build with the attached .config failed, make ends with:
> ...
> CC arch/x86/lib/usercopy_32.o
> AR arch/x86/lib/lib.a
> GEN .version
> CHK include/linux/compile.h
> UPD
On Thu, 1 Nov 2007 20:24:54 +0100 Toralf Förster wrote:
[adding netdev]
Hello,
the build with the attached .config failed, make ends with:
...
CC arch/x86/lib/usercopy_32.o
AR arch/x86/lib/lib.a
GEN .version
CHK include/linux/compile.h
UPD
On Thursday 01 November 2007, Randy Dunlap wrote:
The MII functions aren't available unless NET_ETHERNET=y.
Howver, the MII functions aren't always needed...
David, any ideas on this one?
It's been several years since I looked at this. It
used to behave just fine.
Something must have
On Thu, Nov 01, 2007 at 04:32:18PM -0700, David Brownell wrote:
On Thursday 01 November 2007, Randy Dunlap wrote:
The MII functions aren't available unless NET_ETHERNET=y.
The setting of CONFIG_NET_ETHERNET doesn't matter for this bug.
Howver, the MII functions aren't always needed...
34 matches
Mail list logo
