Re: cleanup the walk_page_range interface v2

2019-08-28 Thread Jason Gunthorpe
On Wed, Aug 28, 2019 at 04:19:52PM +0200, Christoph Hellwig wrote: > Hi all, > > this series is based on a patch from Linus to split the callbacks > passed to walk_page_range and walk_page_vma into a separate structure > that can be marked const, with various cleanups from me on top. > > This

Re: cleanup the walk_page_range interface

2019-08-28 Thread Steven Price
On 28/08/2019 00:36, Jason Gunthorpe wrote: > On Tue, Aug 27, 2019 at 04:34:31PM -0700, Andrew Morton wrote: >> On Tue, 27 Aug 2019 01:34:13 + Jason Gunthorpe wrote: >> >>> On Sat, Aug 24, 2019 at 03:26:55PM -0700, Christoph Hellwig wrote: On Fri, Aug 23, 2019 at 01:43:12PM +, Jason

Re: cleanup the walk_page_range interface

2019-08-28 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 11:36:26PM +, Jason Gunthorpe wrote: > Okay, I'll get it on a branch and merge it toward hmm.git tomorrow I was planning to resend it with the rebase, especially as the build bot picked a build error in task_mmu.c where we were missing a stub for an unusual

Re: cleanup the walk_page_range interface

2019-08-27 Thread Jason Gunthorpe
On Tue, Aug 27, 2019 at 04:34:31PM -0700, Andrew Morton wrote: > On Tue, 27 Aug 2019 01:34:13 + Jason Gunthorpe wrote: > > > On Sat, Aug 24, 2019 at 03:26:55PM -0700, Christoph Hellwig wrote: > > > On Fri, Aug 23, 2019 at 01:43:12PM +, Jason Gunthorpe wrote: > > > > > So what is the plan

Re: cleanup the walk_page_range interface

2019-08-27 Thread Andrew Morton
On Tue, 27 Aug 2019 01:34:13 + Jason Gunthorpe wrote: > On Sat, Aug 24, 2019 at 03:26:55PM -0700, Christoph Hellwig wrote: > > On Fri, Aug 23, 2019 at 01:43:12PM +, Jason Gunthorpe wrote: > > > > So what is the plan forward? Probably a little late for 5.3, > > > > so queue it up in -mm

Re: cleanup the walk_page_range interface

2019-08-26 Thread Jason Gunthorpe
On Sat, Aug 24, 2019 at 03:26:55PM -0700, Christoph Hellwig wrote: > On Fri, Aug 23, 2019 at 01:43:12PM +, Jason Gunthorpe wrote: > > > So what is the plan forward? Probably a little late for 5.3, > > > so queue it up in -mm for 5.4 and deal with the conflicts in at least > > > hmm? Queue it

Re: cleanup the walk_page_range interface

2019-08-24 Thread Christoph Hellwig
On Fri, Aug 23, 2019 at 01:43:12PM +, Jason Gunthorpe wrote: > > So what is the plan forward? Probably a little late for 5.3, > > so queue it up in -mm for 5.4 and deal with the conflicts in at least > > hmm? Queue it up in the hmm tree even if it doesn't 100% fit? > > Did we make a

Re: cleanup the walk_page_range interface

2019-08-23 Thread Steven Price
On 23/08/2019 14:43, Jason Gunthorpe wrote: > On Thu, Aug 15, 2019 at 11:27:51PM -0700, Christoph Hellwig wrote: >> On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: >>> On Thu, Aug 8, 2019 at 8:42 AM Christoph Hellwig wrote: this series is based on a patch from Linus to

Re: cleanup the walk_page_range interface

2019-08-23 Thread Jason Gunthorpe
On Thu, Aug 15, 2019 at 11:27:51PM -0700, Christoph Hellwig wrote: > On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: > > On Thu, Aug 8, 2019 at 8:42 AM Christoph Hellwig wrote: > > > > > > this series is based on a patch from Linus to split the callbacks > > > passed to

Re: cleanup the walk_page_range interface

2019-08-17 Thread Linus Torvalds
On Fri, Aug 16, 2019 at 11:41 PM Stephen Rothwell wrote: > > I certainly prefer that method of API change :-) > (see the current "keys: Replace uid/gid/perm permissions checking with > an ACL" in linux-next Side note: I will *not* be pulling that again. It was broken last time, and without more

Re: cleanup the walk_page_range interface

2019-08-17 Thread Stephen Rothwell
Hi Christoph, On Sat, 17 Aug 2019 08:43:01 +0200 Christoph Hellwig wrote: > > On Sat, Aug 17, 2019 at 04:41:24PM +1000, Stephen Rothwell wrote: > > I certainly prefer that method of API change :-) > > (see the current "keys: Replace uid/gid/perm permissions checking with > > an ACL" in

Re: cleanup the walk_page_range interface

2019-08-17 Thread Christoph Hellwig
On Sat, Aug 17, 2019 at 04:41:24PM +1000, Stephen Rothwell wrote: > I certainly prefer that method of API change :-) > (see the current "keys: Replace uid/gid/perm permissions checking with > an ACL" in linux-next and the (currently) three merge fixup patches I > am carrying. Its not bad when

Re: cleanup the walk_page_range interface

2019-08-17 Thread Stephen Rothwell
Hi all, On Fri, 16 Aug 2019 14:06:23 -0700 Andrew Morton wrote: > > On Fri, 16 Aug 2019 14:32:58 +0200 Christoph Hellwig wrote: > > > On Fri, Aug 16, 2019 at 11:57:40AM +, Jason Gunthorpe wrote: > > > Are there conflicts with trees other than hmm? > > > > > > We can put it on a topic

Re: cleanup the walk_page_range interface

2019-08-16 Thread Andrew Morton
On Fri, 16 Aug 2019 14:32:58 +0200 Christoph Hellwig wrote: > On Fri, Aug 16, 2019 at 11:57:40AM +, Jason Gunthorpe wrote: > > Are there conflicts with trees other than hmm? > > > > We can put it on a topic branch and merge to hmm to resolve. If hmm > > has problems then send the topic on

Re: cleanup the walk_page_range interface

2019-08-16 Thread Linus Torvalds
On Fri, Aug 16, 2019 at 5:33 AM Christoph Hellwig wrote: > > I see two new walk_page_range user in linux-next related to MADV_COLD > support (which probably really should use walk_range_vma), and then > there is the series from Steven, which hasn't been merged yet. It does sound like this might

Re: cleanup the walk_page_range interface

2019-08-16 Thread Christoph Hellwig
On Fri, Aug 16, 2019 at 11:57:40AM +, Jason Gunthorpe wrote: > Are there conflicts with trees other than hmm? > > We can put it on a topic branch and merge to hmm to resolve. If hmm > has problems then send the topic on its own? I see two new walk_page_range user in linux-next related to

Re: cleanup the walk_page_range interface

2019-08-16 Thread Jason Gunthorpe
On Thu, Aug 15, 2019 at 11:27:51PM -0700, Christoph Hellwig wrote: > On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: > > On Thu, Aug 8, 2019 at 8:42 AM Christoph Hellwig wrote: > > > > > > this series is based on a patch from Linus to split the callbacks > > > passed to

Re: cleanup the walk_page_range interface

2019-08-16 Thread Christoph Hellwig
On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: > On Thu, Aug 8, 2019 at 8:42 AM Christoph Hellwig wrote: > > > > this series is based on a patch from Linus to split the callbacks > > passed to walk_page_range and walk_page_vma into a separate structure > > that can be marked

Re: cleanup the walk_page_range interface

2019-08-12 Thread Mike Rapoport
On Thu, Aug 08, 2019 at 11:56:32PM +0200, Christoph Hellwig wrote: > On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: > > > Note that both Thomas and Steven have series touching this area pending, > > > and there are a couple consumer in flux too - the hmm tree already > > >

Re: cleanup the walk_page_range interface

2019-08-09 Thread Christoph Hellwig
On Fri, Aug 09, 2019 at 12:21:24AM +0200, Thomas Hellstrom wrote: > On 8/8/19 11:56 PM, Christoph Hellwig wrote: >> On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: Note that both Thomas and Steven have series touching this area pending, and there are a couple consumer in

Re: cleanup the walk_page_range interface

2019-08-08 Thread Thomas Hellstrom
On 8/8/19 11:56 PM, Christoph Hellwig wrote: On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: Note that both Thomas and Steven have series touching this area pending, and there are a couple consumer in flux too - the hmm tree already conflicts with this series, and I have

Re: cleanup the walk_page_range interface

2019-08-08 Thread Christoph Hellwig
On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: > > Note that both Thomas and Steven have series touching this area pending, > > and there are a couple consumer in flux too - the hmm tree already > > conflicts with this series, and I have potential dma changes on top of > > the

Re: cleanup the walk_page_range interface

2019-08-08 Thread Linus Torvalds
On Thu, Aug 8, 2019 at 8:42 AM Christoph Hellwig wrote: > > this series is based on a patch from Linus to split the callbacks > passed to walk_page_range and walk_page_vma into a separate structure > that can be marked const, with various cleanups from me on top. The whole series looks good to