Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-12 Thread Dan Williams
On 8/12/13 11:10 AM, "Jon Mason" wrote: >On Fri, Aug 02, 2013 at 09:18:03PM +0200, Brice Goglin wrote: >> Le 02/08/2013 19:47, Dan Williams a écrit : >> > Yup, but should also fold in the deletions of the other is_xeon_cb32() >> > alignment fixups further below. >> > >> > Actually all the

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-12 Thread Jon Mason
On Fri, Aug 02, 2013 at 09:18:03PM +0200, Brice Goglin wrote: > Le 02/08/2013 19:47, Dan Williams a écrit : > > Yup, but should also fold in the deletions of the other is_xeon_cb32() > > alignment fixups further below. > > > > Actually all the alignment settings can be removed now. > > > > ...and

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-12 Thread Jon Mason
On Fri, Aug 02, 2013 at 09:18:03PM +0200, Brice Goglin wrote: Le 02/08/2013 19:47, Dan Williams a écrit : Yup, but should also fold in the deletions of the other is_xeon_cb32() alignment fixups further below. Actually all the alignment settings can be removed now. ...and the

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-12 Thread Dan Williams
On 8/12/13 11:10 AM, Jon Mason jon.ma...@intel.com wrote: On Fri, Aug 02, 2013 at 09:18:03PM +0200, Brice Goglin wrote: Le 02/08/2013 19:47, Dan Williams a écrit : Yup, but should also fold in the deletions of the other is_xeon_cb32() alignment fixups further below. Actually all the

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
Le 02/08/2013 19:47, Dan Williams a écrit : > Yup, but should also fold in the deletions of the other is_xeon_cb32() > alignment fixups further below. > > Actually all the alignment settings can be removed now. > > ...and the PQ_VAL/XOR_VAL fixup for is_xeon_cb32() can go. Ok, here's another one,

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jon Mason
On Fri, Aug 02, 2013 at 04:57:44PM +, Dan Williams wrote: > > > On 8/2/13 12:34 AM, "Brice Goglin" wrote: > > >Le 01/08/2013 19:15, Jiang, Dave a écrit : > >> On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > >>> On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > I'm

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
Le 02/08/2013 18:57, Dan Williams a écrit : > I like Jon¹s suggestion. Just make raid disabled by default on non-atom > platforms. When if a non-atom platform comes along without the previous > restrictions it can add itself to this list. > > So let¹s drop the module parameter and just cleanup

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Dan Williams
On 8/2/13 10:26 AM, "Brice Goglin" wrote: >Le 02/08/2013 18:57, Dan Williams a écrit : >> I like Jon¹s suggestion. Just make raid disabled by default on non-atom >> platforms. When if a non-atom platform comes along without the previous >> restrictions it can add itself to this list. >> >>

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Dan Williams
On 8/2/13 12:34 AM, "Brice Goglin" wrote: >Le 01/08/2013 19:15, Jiang, Dave a écrit : >> On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: >>> On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with enabling this for people that just want to use DMA and not RAID.

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jiang, Dave
On Fri, 2013-08-02 at 16:57 +, Dan Williams wrote: > > On 8/2/13 12:34 AM, "Brice Goglin" wrote: > > >Le 01/08/2013 19:15, Jiang, Dave a écrit : > >> On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > >>> On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > I'm ok with

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jiang, Dave
That looks fine. Acked-by: Dave Jiang On Fri, 2013-08-02 at 09:34 +0200, Brice Goglin wrote: > Le 01/08/2013 19:15, Jiang, Dave a écrit : > > On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > >> On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > >>> I'm ok with enabling this for

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
Le 01/08/2013 19:15, Jiang, Dave a écrit : > On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: >> On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: >>> I'm ok with enabling this for people that just want to use DMA and not >>> RAID. >> I might be crazy, but I'd be in favor of

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jiang, Dave
That looks fine. Acked-by: Dave Jiang dave.ji...@intel.com On Fri, 2013-08-02 at 09:34 +0200, Brice Goglin wrote: Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jiang, Dave
On Fri, 2013-08-02 at 16:57 +, Dan Williams wrote: On 8/2/13 12:34 AM, Brice Goglin brice.gog...@inria.fr wrote: Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Dan Williams
On 8/2/13 12:34 AM, Brice Goglin brice.gog...@inria.fr wrote: Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with enabling this for people that just want to use DMA and not

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Dan Williams
On 8/2/13 10:26 AM, Brice Goglin brice.gog...@inria.fr wrote: Le 02/08/2013 18:57, Dan Williams a écrit : I like Jon¹s suggestion. Just make raid disabled by default on non-atom platforms. When if a non-atom platform comes along without the previous restrictions it can add itself to this

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
Le 02/08/2013 18:57, Dan Williams a écrit : I like Jon¹s suggestion. Just make raid disabled by default on non-atom platforms. When if a non-atom platform comes along without the previous restrictions it can add itself to this list. So let¹s drop the module parameter and just cleanup the

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jon Mason
On Fri, Aug 02, 2013 at 04:57:44PM +, Dan Williams wrote: On 8/2/13 12:34 AM, Brice Goglin brice.gog...@inria.fr wrote: Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
Le 02/08/2013 19:47, Dan Williams a écrit : Yup, but should also fold in the deletions of the other is_xeon_cb32() alignment fixups further below. Actually all the alignment settings can be removed now. ...and the PQ_VAL/XOR_VAL fixup for is_xeon_cb32() can go. Ok, here's another one, but

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Brice Goglin
Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with enabling this for people that just want to use DMA and not RAID. I might be crazy, but I'd be in favor of disabling the RAID

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-01 Thread Jiang, Dave
On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > > I'm ok with enabling this for people that just want to use DMA and not > > RAID. > > I might be crazy, but I'd be in favor of disabling the RAID offload by > default on non-Atom

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-01 Thread Jon Mason
On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > I'm ok with enabling this for people that just want to use DMA and not > RAID. I might be crazy, but I'd be in favor of disabling the RAID offload by default on non-Atom platforms. Thanks, Jon > > Acked-by: Dave Jiang > > On

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-01 Thread Jon Mason
On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with enabling this for people that just want to use DMA and not RAID. I might be crazy, but I'd be in favor of disabling the RAID offload by default on non-Atom platforms. Thanks, Jon Acked-by: Dave Jiang

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-01 Thread Jiang, Dave
On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with enabling this for people that just want to use DMA and not RAID. I might be crazy, but I'd be in favor of disabling the RAID offload by default on non-Atom

Re: ioatdma: add ioat_raid_enabled module parameter

2013-07-31 Thread Jiang, Dave
I'm ok with enabling this for people that just want to use DMA and not RAID. Acked-by: Dave Jiang On Thu, 2013-08-01 at 00:05 +0200, Brice Goglin wrote: > ioatdma: add ioat_raid_enabled module parameter > > Commit f26df1a1 added a 64-byte alignment requirement for legacy > operations to work

Re: ioatdma: add ioat_raid_enabled module parameter

2013-07-31 Thread Jiang, Dave
I'm ok with enabling this for people that just want to use DMA and not RAID. Acked-by: Dave Jiang dave.ji...@intel.com On Thu, 2013-08-01 at 00:05 +0200, Brice Goglin wrote: ioatdma: add ioat_raid_enabled module parameter Commit f26df1a1 added a 64-byte alignment requirement for legacy