Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 9:55 PM, Cong Wang wrote: > Why not add a printk and play with my patch to see the difference? I have other things to do. If you believe your patch fixes the problem, send it and let Andrey verify.

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 9:55 PM, Cong Wang wrote: > Why not add a printk and play with my patch to see the difference? I have other things to do. If you believe your patch fixes the problem, send it and let Andrey verify.

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 7:43 PM, David Ahern wrote: > On 5/3/17 5:35 PM, Cong Wang wrote: >> Ah, we need: >> >> @@ -4024,7 +4027,7 @@ static struct pernet_operations ip6_route_net_late_ops >> = { >> >> static struct notifier_block ip6_route_dev_notifier = { >>

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 7:43 PM, David Ahern wrote: > On 5/3/17 5:35 PM, Cong Wang wrote: >> Ah, we need: >> >> @@ -4024,7 +4027,7 @@ static struct pernet_operations ip6_route_net_late_ops >> = { >> >> static struct notifier_block ip6_route_dev_notifier = { >> .notifier_call =

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 5:35 PM, Cong Wang wrote: > Ah, we need: > > @@ -4024,7 +4027,7 @@ static struct pernet_operations ip6_route_net_late_ops > = { > > static struct notifier_block ip6_route_dev_notifier = { > .notifier_call = ip6_route_dev_notify, > - .priority = 0, > + .priority =

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 5:35 PM, Cong Wang wrote: > Ah, we need: > > @@ -4024,7 +4027,7 @@ static struct pernet_operations ip6_route_net_late_ops > = { > > static struct notifier_block ip6_route_dev_notifier = { > .notifier_call = ip6_route_dev_notify, > - .priority = 0, > + .priority =

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 3:09 PM, David Ahern wrote: > On 5/3/17 4:02 PM, Cong Wang wrote: >> On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >>> On 5/3/17 11:02 AM, Cong Wang wrote: A quick glance shows we need to simply check local->rt6i_idev

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 3:09 PM, David Ahern wrote: > On 5/3/17 4:02 PM, Cong Wang wrote: >> On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >>> On 5/3/17 11:02 AM, Cong Wang wrote: A quick glance shows we need to simply check local->rt6i_idev since we do the same check for sprt

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 4:02 PM, Cong Wang wrote: > On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >> On 5/3/17 11:02 AM, Cong Wang wrote: >>> A quick glance shows we need to simply check local->rt6i_idev >>> since we do the same check for sprt right above. >> >> As I recall, rt6i_idev

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 4:02 PM, Cong Wang wrote: > On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >> On 5/3/17 11:02 AM, Cong Wang wrote: >>> A quick glance shows we need to simply check local->rt6i_idev >>> since we do the same check for sprt right above. >> >> As I recall, rt6i_idev is set for all

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: > On 5/3/17 11:02 AM, Cong Wang wrote: >> A quick glance shows we need to simply check local->rt6i_idev >> since we do the same check for sprt right above. > > As I recall, rt6i_idev is set for all routes except null_entry and

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: > On 5/3/17 11:02 AM, Cong Wang wrote: >> A quick glance shows we need to simply check local->rt6i_idev >> since we do the same check for sprt right above. > > As I recall, rt6i_idev is set for all routes except null_entry and it is > not set on

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 11:02 AM, Cong Wang wrote: > A quick glance shows we need to simply check local->rt6i_idev > since we do the same check for sprt right above. As I recall, rt6i_idev is set for all routes except null_entry and it is not set on null_entry only because of initialization order. > > diff

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 11:02 AM, Cong Wang wrote: > A quick glance shows we need to simply check local->rt6i_idev > since we do the same check for sprt right above. As I recall, rt6i_idev is set for all routes except null_entry and it is not set on null_entry only because of initialization order. > > diff

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 9:33 AM, Andrey Konovalov wrote: > Hi David, > > Got another report related to fib6. > > I'm on 89c9fea3c8034cdb2fd745f551cde0b507fd6893 with your last patch applied. > > A reproducer and .config are attached. > > kasan: CONFIG_KASAN_INLINE enabled >

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 9:33 AM, Andrey Konovalov wrote: > Hi David, > > Got another report related to fib6. > > I'm on 89c9fea3c8034cdb2fd745f551cde0b507fd6893 with your last patch applied. > > A reproducer and .config are attached. > > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be