Re: new warning on sysrq kernel crash trigger

On Thu, Dec 17, 2015 at 9:28 AM, Greg KH wrote: > On Wed, Dec 16, 2015 at 11:25:21AM -0500, Rik van Riel wrote: >> On 12/15/2015 07:52 PM, Ani Sinha wrote: >> > Rik, should I send a separate email with the patch or you are OK >> > with what I sent in the email? Are you queueing up my patch for >>

Re: new warning on sysrq kernel crash trigger

On Wed, Dec 16, 2015 at 11:25:21AM -0500, Rik van Riel wrote: > On 12/15/2015 07:52 PM, Ani Sinha wrote: > > Rik, should I send a separate email with the patch or you are OK > > with what I sent in the email? Are you queueing up my patch for > > applying upstream? > > I don't have a git tree for

Re: new warning on sysrq kernel crash trigger

On Wed, Dec 16, 2015 at 11:25:21AM -0500, Rik van Riel wrote: > On 12/15/2015 07:52 PM, Ani Sinha wrote: > > Rik, should I send a separate email with the patch or you are OK > > with what I sent in the email? Are you queueing up my patch for > > applying upstream? > > I don't have a git tree for

Re: new warning on sysrq kernel crash trigger

On Thu, Dec 17, 2015 at 9:28 AM, Greg KH wrote: > On Wed, Dec 16, 2015 at 11:25:21AM -0500, Rik van Riel wrote: >> On 12/15/2015 07:52 PM, Ani Sinha wrote: >> > Rik, should I send a separate email with the patch or you are OK >> > with what I sent in the email? Are you

Re: new warning on sysrq kernel crash trigger

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/15/2015 07:52 PM, Ani Sinha wrote: > Rik, should I send a separate email with the patch or you are OK > with what I sent in the email? Are you queueing up my patch for > applying upstream? I don't have a git tree for people to pull from, and

Re: new warning on sysrq kernel crash trigger

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/14/2015 07:14 PM, Anirban Sinha wrote: > > > On Mon, 14 Dec 2015, Rik van Riel wrote: > >> On 12/14/2015 11:24 AM, Ani Sinha wrote: >>> Rik, any comments? >> >> Another good option is to simply ignore this warning, or drop the >>

Re: new warning on sysrq kernel crash trigger

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/14/2015 07:14 PM, Anirban Sinha wrote: > > > On Mon, 14 Dec 2015, Rik van Riel wrote: > >> On 12/14/2015 11:24 AM, Ani Sinha wrote: >>> Rik, any comments? >> >> Another good option is to simply ignore this warning, or drop the >>

Re: new warning on sysrq kernel crash trigger

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/15/2015 07:52 PM, Ani Sinha wrote: > Rik, should I send a separate email with the patch or you are OK > with what I sent in the email? Are you queueing up my patch for > applying upstream? I don't have a git tree for people to pull from, and

Re: new warning on sysrq kernel crash trigger

Rik, should I send a separate email with the patch or you are OK with what I sent in the email? Are you queueing up my patch for applying upstream? On Tue, Dec 15, 2015 at 5:44 AM, Anirban Sinha wrote: > > > On Mon, 14 Dec 2015, Rik van Riel wrote: > >> On 12/14/2015 11:24 AM, Ani Sinha wrote:

Re: new warning on sysrq kernel crash trigger

Rik, should I send a separate email with the patch or you are OK with what I sent in the email? Are you queueing up my patch for applying upstream? On Tue, Dec 15, 2015 at 5:44 AM, Anirban Sinha wrote: > > > On Mon, 14 Dec 2015, Rik van Riel wrote: > >> On 12/14/2015 11:24 AM,

Re: new warning on sysrq kernel crash trigger

On Mon, 14 Dec 2015, Rik van Riel wrote: > On 12/14/2015 11:24 AM, Ani Sinha wrote: > > Rik, any comments? > > Another good option is to simply ignore this warning, or drop > the rcu_read_lock before doing the alt-syrsq-c action. > > After all, alt-sysrq-c is "crash the system, take a crash

Re: new warning on sysrq kernel crash trigger

On 12/14/2015 11:24 AM, Ani Sinha wrote: > Rik, any comments? Another good option is to simply ignore this warning, or drop the rcu_read_lock before doing the alt-syrsq-c action. After all, alt-sysrq-c is "crash the system, take a crash dump", which is not an action the system ever returns from.

Re: new warning on sysrq kernel crash trigger

Rik, any comments? On Sat, Dec 12, 2015 at 6:33 AM, Paul E. McKenney wrote: > On Fri, Dec 11, 2015 at 04:16:37PM -0800, Ani Sinha wrote: >> On Fri, 11 Dec 2015, Paul E. McKenney wrote: >> > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: >> > > On 12/11/2015 03:44 PM, Ani Sinha

Re: new warning on sysrq kernel crash trigger

On Mon, 14 Dec 2015, Rik van Riel wrote: > On 12/14/2015 11:24 AM, Ani Sinha wrote: > > Rik, any comments? > > Another good option is to simply ignore this warning, or drop > the rcu_read_lock before doing the alt-syrsq-c action. > > After all, alt-sysrq-c is "crash the system, take a crash

Re: new warning on sysrq kernel crash trigger

Rik, any comments? On Sat, Dec 12, 2015 at 6:33 AM, Paul E. McKenney wrote: > On Fri, Dec 11, 2015 at 04:16:37PM -0800, Ani Sinha wrote: >> On Fri, 11 Dec 2015, Paul E. McKenney wrote: >> > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: >> > > On

Re: new warning on sysrq kernel crash trigger

On 12/14/2015 11:24 AM, Ani Sinha wrote: > Rik, any comments? Another good option is to simply ignore this warning, or drop the rcu_read_lock before doing the alt-syrsq-c action. After all, alt-sysrq-c is "crash the system, take a crash dump", which is not an action the system ever returns from.

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 04:16:37PM -0800, Ani Sinha wrote: > On Fri, 11 Dec 2015, Paul E. McKenney wrote: > > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > > > On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > > > > > > > > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > >

Re: new warning on sysrq kernel crash trigger

On Fri, 11 Dec 2015, Paul E. McKenney wrote: > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > > On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > > > > > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > > > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > >

Re: new warning on sysrq kernel crash trigger

I backported your ee376dbdf277 ("rcu: Consolidate rcu_synchronize and wakeme_after_rcu()" & ec90a194ae2cb8b8e("rcu: Create a synchronize_rcu_mult()") and tested this on our 3.18 kernel running on our board. The sysrq kernel crash seems to have been fixed (behavior as per our old 3.4 kernel). I

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 03:41:04PM -0800, Ani Sinha wrote: > On Fri, Dec 11, 2015 at 2:27 PM, Paul E. McKenney > wrote: > > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > >> On 12/11/2015 03:44 PM, Ani Sinha wrote: > >> > > >> > > >> > On Thu, 10 Dec 2015, Paul E. McKenney wrote:

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 2:27 PM, Paul E. McKenney wrote: > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: >> On 12/11/2015 03:44 PM, Ani Sinha wrote: >> > >> > >> > On Thu, 10 Dec 2015, Paul E. McKenney wrote: >> > >> >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: >>

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > >>> Hi guys > >>> > >>> I am noticing a new warning in linux

Re: new warning on sysrq kernel crash trigger

On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: >>> Hi guys >>> >>> I am noticing a new warning in linux 3.18 which we did not see before >>> in linux 3.4 : >>> >>> bash-4.1# echo c >

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 12:44:13PM -0800, Ani Sinha wrote: > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > > > Hi guys > > > > > > I am noticing a new warning in linux 3.18 which we did not see before > > > in linux 3.4 : >

Re: new warning on sysrq kernel crash trigger

On Thu, 10 Dec 2015, Paul E. McKenney wrote: > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > > Hi guys > > > > I am noticing a new warning in linux 3.18 which we did not see before > > in linux 3.4 : > > > > bash-4.1# echo c > /proc/sysrq-trigger > > [ 978.807185] BUG:

Re: new warning on sysrq kernel crash trigger

Well I can certainly send a patch but I wonder if simply using SRCU for this one instance in Rik's original patch will not break anything else. Rik, please provide your thoughts. On Thu, Dec 10, 2015 at 9:26 PM, Paul E. McKenney wrote: > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote:

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 12:44:13PM -0800, Ani Sinha wrote: > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > > > Hi guys > > > > > > I am noticing a new warning in linux 3.18 which we did not see before > > > in linux 3.4 : >

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 2:27 PM, Paul E. McKenney wrote: > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: >> On 12/11/2015 03:44 PM, Ani Sinha wrote: >> > >> > >> > On Thu, 10 Dec 2015, Paul E. McKenney wrote: >> > >> >> On Thu, Dec 10, 2015 at

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 03:41:04PM -0800, Ani Sinha wrote: > On Fri, Dec 11, 2015 at 2:27 PM, Paul E. McKenney > wrote: > > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > >> On 12/11/2015 03:44 PM, Ani Sinha wrote: > >> > > >> > > >> > On Thu, 10 Dec

Re: new warning on sysrq kernel crash trigger

I backported your ee376dbdf277 ("rcu: Consolidate rcu_synchronize and wakeme_after_rcu()" & ec90a194ae2cb8b8e("rcu: Create a synchronize_rcu_mult()") and tested this on our 3.18 kernel running on our board. The sysrq kernel crash seems to have been fixed (behavior as per our old 3.4 kernel). I

Re: new warning on sysrq kernel crash trigger

On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: >>> Hi guys >>> >>> I am noticing a new warning in linux 3.18 which we did not see before >>> in linux 3.4 : >>> >>> bash-4.1# echo c >

Re: new warning on sysrq kernel crash trigger

On Fri, 11 Dec 2015, Paul E. McKenney wrote: > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > > On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > > > > > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > > > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > >

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > >>> Hi guys > >>> > >>> I am noticing a new warning in linux

Re: new warning on sysrq kernel crash trigger

On Fri, Dec 11, 2015 at 04:16:37PM -0800, Ani Sinha wrote: > On Fri, 11 Dec 2015, Paul E. McKenney wrote: > > On Fri, Dec 11, 2015 at 05:10:43PM -0500, Rik van Riel wrote: > > > On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > > > > > > > > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > >

Re: new warning on sysrq kernel crash trigger

On Thu, 10 Dec 2015, Paul E. McKenney wrote: > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > > Hi guys > > > > I am noticing a new warning in linux 3.18 which we did not see before > > in linux 3.4 : > > > > bash-4.1# echo c > /proc/sysrq-trigger > > [ 978.807185] BUG:

Re: new warning on sysrq kernel crash trigger

Well I can certainly send a patch but I wonder if simply using SRCU for this one instance in Rik's original patch will not break anything else. Rik, please provide your thoughts. On Thu, Dec 10, 2015 at 9:26 PM, Paul E. McKenney wrote: > On Thu, Dec 10, 2015 at

Re: new warning on sysrq kernel crash trigger

On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > Hi guys > > I am noticing a new warning in linux 3.18 which we did not see before > in linux 3.4 : > > bash-4.1# echo c > /proc/sysrq-trigger > [ 978.807185] BUG: sleeping function called from invalid context at >

Re: new warning on sysrq kernel crash trigger

On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > Hi guys > > I am noticing a new warning in linux 3.18 which we did not see before > in linux 3.4 : > > bash-4.1# echo c > /proc/sysrq-trigger > [ 978.807185] BUG: sleeping function called from invalid context at >