Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

Hi Peter, On Tue, 6 Sep 2016 16:47:56 +0200, Peter Zijlstra wrote: > On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > > [diff "default"] > > > xfuncname = "^[[:alpha:]$_].*[^:]$" > > > > OK, I see. As mentioned somewhere else, it fails for labels which have > > comments.

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

Hi Peter, On Tue, 6 Sep 2016 16:47:56 +0200, Peter Zijlstra wrote: > On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > > [diff "default"] > > > xfuncname = "^[[:alpha:]$_].*[^:]$" > > > > OK, I see. As mentioned somewhere else, it fails for labels which have > > comments.

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Tue, 2016-09-06 at 16:47 +0200, Peter Zijlstra wrote: > On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > > [diff "default"] > > >         xfuncname = "^[[:alpha:]$_].*[^:]$" > > OK, I see. As mentioned somewhere else, it fails for labels which have > > comments.  > Heh, There's

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Tue, 2016-09-06 at 16:47 +0200, Peter Zijlstra wrote: > On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > > [diff "default"] > > >         xfuncname = "^[[:alpha:]$_].*[^:]$" > > OK, I see. As mentioned somewhere else, it fails for labels which have > > comments.  > Heh, There's

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > [diff "default"] > > xfuncname = "^[[:alpha:]$_].*[^:]$" > > OK, I see. As mentioned somewhere else, it fails for labels which have > comments. Heh, There's labels that have comments? > My worry is that you recommending

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > [diff "default"] > > xfuncname = "^[[:alpha:]$_].*[^:]$" > > OK, I see. As mentioned somewhere else, it fails for labels which have > comments. Heh, There's labels that have comments? > My worry is that you recommending

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

Hi Peter, On Mon, 5 Sep 2016 13:58:38 +0200, Peter Zijlstra wrote: > On Mon, Sep 05, 2016 at 01:54:45PM +0200, Jean Delvare wrote: > > On Mon, 5 Sep 2016 13:37:04 +0200, Peter Zijlstra wrote: > > > I have it in my local .gitconfig, and recommend it to people who send me > > > patches. > > > >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

Hi Peter, On Mon, 5 Sep 2016 13:58:38 +0200, Peter Zijlstra wrote: > On Mon, Sep 05, 2016 at 01:54:45PM +0200, Jean Delvare wrote: > > On Mon, 5 Sep 2016 13:37:04 +0200, Peter Zijlstra wrote: > > > I have it in my local .gitconfig, and recommend it to people who send me > > > patches. > > > >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Mon, Sep 05, 2016 at 01:54:45PM +0200, Jean Delvare wrote: > On Mon, 5 Sep 2016 13:37:04 +0200, Peter Zijlstra wrote: > > On Mon, Sep 05, 2016 at 01:07:37PM +0200, Jean Delvare wrote: > > > Now I see in http://patchwork.ozlabs.org/patch/664966/ that Peter > > > Zijlstra reportedly changed the

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Mon, Sep 05, 2016 at 01:54:45PM +0200, Jean Delvare wrote: > On Mon, 5 Sep 2016 13:37:04 +0200, Peter Zijlstra wrote: > > On Mon, Sep 05, 2016 at 01:07:37PM +0200, Jean Delvare wrote: > > > Now I see in http://patchwork.ozlabs.org/patch/664966/ that Peter > > > Zijlstra reportedly changed the

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Mon, 5 Sep 2016 13:37:04 +0200, Peter Zijlstra wrote: > On Mon, Sep 05, 2016 at 01:07:37PM +0200, Jean Delvare wrote: > > Now I see in http://patchwork.ozlabs.org/patch/664966/ that Peter > > Zijlstra reportedly changed the behavior of "diff -p" so that it > > handles unindented C labels

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Mon, 5 Sep 2016 13:37:04 +0200, Peter Zijlstra wrote: > On Mon, Sep 05, 2016 at 01:07:37PM +0200, Jean Delvare wrote: > > Now I see in http://patchwork.ozlabs.org/patch/664966/ that Peter > > Zijlstra reportedly changed the behavior of "diff -p" so that it > > handles unindented C labels

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Mon, Sep 05, 2016 at 01:07:37PM +0200, Jean Delvare wrote: > Now I see in http://patchwork.ozlabs.org/patch/664966/ that Peter > Zijlstra reportedly changed the behavior of "diff -p" so that it > handles unindented C labels nicely. If this actually happens, it could > change my point of view.

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On Mon, Sep 05, 2016 at 01:07:37PM +0200, Jean Delvare wrote: > Now I see in http://patchwork.ozlabs.org/patch/664966/ that Peter > Zijlstra reportedly changed the behavior of "diff -p" so that it > handles unindented C labels nicely. If this actually happens, it could > change my point of view.

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

Hi Daniel, Preliminary note: the SNR of Markus Elfring is incredibly low. I advise you just ignore him. On Sun, 04 Sep 2016 11:56:58 +0200, Daniel Borkmann wrote: > I don't want to drag this thread onwards for (way) too long, but clearly "it > is > advised to indent labels with a single space

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

Hi Daniel, Preliminary note: the SNR of Markus Elfring is incredibly low. I advise you just ignore him. On Sun, 04 Sep 2016 11:56:58 +0200, Daniel Borkmann wrote: > I don't want to drag this thread onwards for (way) too long, but clearly "it > is > advised to indent labels with a single space

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On 09/04/2016 09:20 AM, SF Markus Elfring wrote: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 [ + Jonathan for above commit in linux-next ] You seem to lack understanding of the difference

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On 09/04/2016 09:20 AM, SF Markus Elfring wrote: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 [ + Jonathan for above commit in linux-next ] You seem to lack understanding of the difference

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

> It's not because I find improvements "uncomfortable", but rather it's > because your changes are not seen as improvements in the first place. What is your software development opinion for the update step "[1/4] sparc: bpf_jit: Use kmalloc_array() in bpf_jit_compile()" from this small patch

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

> It's not because I find improvements "uncomfortable", but rather it's > because your changes are not seen as improvements in the first place. What is your software development opinion for the update step "[1/4] sparc: bpf_jit: Use kmalloc_array() in bpf_jit_compile()" from this small patch

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 > > You seem to lack understanding of the difference between absolute > requirements and "advice". > > As Sparc maintainer I can choose to not take

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 > > You seem to lack understanding of the difference between absolute > requirements and "advice". > > As Sparc maintainer I can choose to not take

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

From: SF Markus Elfring Date: Sun, 4 Sep 2016 09:20:55 +0200 > I guess that I will stumble on more software improvement opportunities > you find harder to become comfortable with. Improvement is a matter of opinion. So your statement assumes that your changes are

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

From: SF Markus Elfring Date: Sun, 4 Sep 2016 09:20:55 +0200 > I guess that I will stumble on more software improvement opportunities > you find harder to become comfortable with. Improvement is a matter of opinion. So your statement assumes that your changes are an improvement, and everyone

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

From: SF Markus Elfring Date: Sun, 4 Sep 2016 08:50:20 +0200 >>> NAK, just noise. >> >> And frankly I hate that leading space. > > Would you like to comment the recent update of the document "CodingStyle" any > more? >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

From: SF Markus Elfring Date: Sun, 4 Sep 2016 08:50:20 +0200 >>> NAK, just noise. >> >> And frankly I hate that leading space. > > Would you like to comment the recent update of the document "CodingStyle" any > more? >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

>> NAK, just noise. > > And frankly I hate that leading space. Would you like to comment the recent update of the document "CodingStyle" any more? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

>> NAK, just noise. > > And frankly I hate that leading space. Would you like to comment the recent update of the document "CodingStyle" any more? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51