Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-19 Thread Andi Kleen
On Wed, Jan 19, 2005 at 05:06:36PM +0530, Prasanna S Panchamukhi wrote: > Hi Andi, > > > > > - set_intr_gate(3,); > > > > + set_system_gate(3,); > > > > set_system_gate(4,); /* int4-5 can be called from > > > > all */ > > > > set_system_gate(5,); > > > >

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-19 Thread Prasanna S Panchamukhi
Hi Andi, > > > - set_intr_gate(3,); > > > + set_system_gate(3,); > > > set_system_gate(4,); /* int4-5 can be called from all */ > > > set_system_gate(5,); > > > set_intr_gate(6,_op); > > > Index: linux/arch/x86_64/kernel/kprobes.c This looks good to me. Andi do you see any thing that

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-19 Thread Prasanna S Panchamukhi
Hi Andi, - set_intr_gate(3,int3); + set_system_gate(3,int3); set_system_gate(4,overflow); /* int4-5 can be called from all */ set_system_gate(5,bounds); set_intr_gate(6,invalid_op); Index: linux/arch/x86_64/kernel/kprobes.c This looks good to me. Andi do you see any

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-19 Thread Andi Kleen
On Wed, Jan 19, 2005 at 05:06:36PM +0530, Prasanna S Panchamukhi wrote: Hi Andi, - set_intr_gate(3,int3); + set_system_gate(3,int3); set_system_gate(4,overflow); /* int4-5 can be called from all */ set_system_gate(5,bounds);

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-18 Thread Andi Kleen
> Yes its a bug, we turn trap 3 into interrupt gates to ensure that it is not > preemtable. Is the patch ok for you? -Andi > > Like this patch. > > > > Index: linux/arch/x86_64/kernel/traps.c > > === > > ---

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-18 Thread Prasanna S Panchamukhi
On Tue, Jan 18, 2005 at 02:47:08AM +0100, Andi Kleen wrote: > Juho Snellman <[EMAIL PROTECTED]> writes: > > > 2.6.10 changed the behaviour of the int3 instruction on x86-64. It > > used to result in a SIGTRAP, now it's a SIGSEGV in both native and > > 32-bit legacy modes. This was apparently

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-18 Thread Prasanna S Panchamukhi
On Tue, Jan 18, 2005 at 02:47:08AM +0100, Andi Kleen wrote: Juho Snellman [EMAIL PROTECTED] writes: 2.6.10 changed the behaviour of the int3 instruction on x86-64. It used to result in a SIGTRAP, now it's a SIGSEGV in both native and 32-bit legacy modes. This was apparently caused by the

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-18 Thread Andi Kleen
Yes its a bug, we turn trap 3 into interrupt gates to ensure that it is not preemtable. Is the patch ok for you? -Andi Like this patch. Index: linux/arch/x86_64/kernel/traps.c === ---

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-17 Thread Andi Kleen
Juho Snellman <[EMAIL PROTECTED]> writes: > 2.6.10 changed the behaviour of the int3 instruction on x86-64. It > used to result in a SIGTRAP, now it's a SIGSEGV in both native and > 32-bit legacy modes. This was apparently caused by the kprobe port, > specifically this part: > > ---

Re: x86-64: int3 no longer causes SIGTRAP in 2.6.10

2005-01-17 Thread Andi Kleen
Juho Snellman [EMAIL PROTECTED] writes: 2.6.10 changed the behaviour of the int3 instruction on x86-64. It used to result in a SIGTRAP, now it's a SIGSEGV in both native and 32-bit legacy modes. This was apparently caused by the kprobe port, specifically this part: ---