Re: Redundant up operation in stop_machine.c ?(2.6.12)

2005-08-25 Thread Rusty Russell
On Thu, 2005-08-25 at 21:59 +0800, Yingchao Zhou wrote: > In stop_machine function, there are codes: > if (ret < 0) { > stopmachine_set_state(STOPMACHINE_EXIT); > up(_mutex); > return ret; > } > And in __stop_machine_run ,there are: > if

Re: Redundant up operation in stop_machine.c ?(2.6.12)

2005-08-25 Thread Rusty Russell
On Thu, 2005-08-25 at 21:59 +0800, Yingchao Zhou wrote: In stop_machine function, there are codes: if (ret 0) { stopmachine_set_state(STOPMACHINE_EXIT); up(stopmachine_mutex); return ret; } And in __stop_machine_run ,there are: