Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-09-11 Thread Mike Snitzer
Hi, Could you please try the following patch (against any of the kernels you saw the corruption with. be it 4.0, 4.1, 4.2) to see if the regression you reported goes away? Thanks, Mike From: Mike Snitzer Date: Wed, 9 Sep 2015 21:34:51 -0400 Subject: [PATCH] dm crypt: constrain crypt device's

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-09-11 Thread Mike Snitzer
Hi, Could you please try the following patch (against any of the kernels you saw the corruption with. be it 4.0, 4.1, 4.2) to see if the regression you reported goes away? Thanks, Mike From: Mike Snitzer Date: Wed, 9 Sep 2015 21:34:51 -0400 Subject: [PATCH] dm crypt:

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-06-02 Thread Abelardo Ricart III
On Tue, 2015-06-02 at 13:51 -0400, Mikulas Patocka wrote: > > On Mon, 18 May 2015, Abelardo Ricart III wrote: > > > On Fri, 2015-05-15 at 08:04 -0700, Brandon Smith wrote: > > > On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: > > > > > > The patchset in question was tested

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-06-02 Thread Mikulas Patocka
On Mon, 18 May 2015, Abelardo Ricart III wrote: > On Fri, 2015-05-15 at 08:04 -0700, Brandon Smith wrote: > > On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: > > > > > The patchset in question was tested quite heavily so this is a > > > > > surprising report. I'm noticing you

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-06-02 Thread Mikulas Patocka
On Mon, 18 May 2015, Abelardo Ricart III wrote: On Fri, 2015-05-15 at 08:04 -0700, Brandon Smith wrote: On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: The patchset in question was tested quite heavily so this is a surprising report. I'm noticing you are opting

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-06-02 Thread Abelardo Ricart III
On Tue, 2015-06-02 at 13:51 -0400, Mikulas Patocka wrote: On Mon, 18 May 2015, Abelardo Ricart III wrote: On Fri, 2015-05-15 at 08:04 -0700, Brandon Smith wrote: On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: The patchset in question was tested quite heavily so

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-18 Thread Abelardo Ricart III
On Fri, 2015-05-15 at 08:04 -0700, Brandon Smith wrote: > On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: > > > > The patchset in question was tested quite heavily so this is a > > > > surprising report. I'm noticing you are opting in to dm-crypt discard > > > > support. Have

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-18 Thread Abelardo Ricart III
On Fri, 2015-05-15 at 08:04 -0700, Brandon Smith wrote: On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: The patchset in question was tested quite heavily so this is a surprising report. I'm noticing you are opting in to dm-crypt discard support. Have you tested

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-15 Thread Brandon Smith
On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: > > > The patchset in question was tested quite heavily so this is a > > > surprising report. I'm noticing you are opting in to dm-crypt discard > > > support. Have you tested without discards enabled? > > > > I've disabled

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-15 Thread Brandon Smith
On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote: The patchset in question was tested quite heavily so this is a surprising report. I'm noticing you are opting in to dm-crypt discard support. Have you tested without discards enabled? I've disabled discards

Re: [dm-devel] Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-01 Thread Abelardo Ricart III
On Fri, 2015-05-01 at 22:47 +0100, Alasdair G Kergon wrote: > On Fri, May 01, 2015 at 12:37:07AM -0400, Abelardo Ricart III wrote: > > # first bad commit: [cf2f1abfbd0dba701f7f16ef619e4d2485de3366] dm crypt: > > don't > > allocate pages for a partial request > > That's not a particularly good

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-01 Thread Abelardo Ricart III
On Fri, 2015-05-01 at 18:24 -0400, Abelardo Ricart III wrote: > On Fri, 2015-05-01 at 17:17 -0400, Mike Snitzer wrote: > > On Fri, May 01 2015 at 12:37am -0400, > > Abelardo Ricart III wrote: > > > > > I made sure to run a completely vanilla kernel when testing why I was > > > suddenly > > >

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-01 Thread Abelardo Ricart III
On Fri, 2015-05-01 at 17:17 -0400, Mike Snitzer wrote: > On Fri, May 01 2015 at 12:37am -0400, > Abelardo Ricart III wrote: > > > I made sure to run a completely vanilla kernel when testing why I was > > suddenly > > seeing some nasty libata errors with all kernels >= v4.0. Here's a snippet: >

Re: [dm-devel] Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-01 Thread Alasdair G Kergon
On Fri, May 01, 2015 at 12:37:07AM -0400, Abelardo Ricart III wrote: > # first bad commit: [cf2f1abfbd0dba701f7f16ef619e4d2485de3366] dm crypt: don't > allocate pages for a partial request That's not a particularly good commit to identify. If you didn't already, can you confirm whether or not

Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-05-01 Thread Mike Snitzer
On Fri, May 01 2015 at 12:37am -0400, Abelardo Ricart III wrote: > I made sure to run a completely vanilla kernel when testing why I was suddenly > seeing some nasty libata errors with all kernels >= v4.0. Here's a snippet: > > >8 > [ 165.592136]

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-01 Thread Abelardo Ricart III
On Fri, 2015-05-01 at 18:24 -0400, Abelardo Ricart III wrote: On Fri, 2015-05-01 at 17:17 -0400, Mike Snitzer wrote: On Fri, May 01 2015 at 12:37am -0400, Abelardo Ricart III aric...@memnix.com wrote: I made sure to run a completely vanilla kernel when testing why I was suddenly

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-01 Thread Abelardo Ricart III
On Fri, 2015-05-01 at 17:17 -0400, Mike Snitzer wrote: On Fri, May 01 2015 at 12:37am -0400, Abelardo Ricart III aric...@memnix.com wrote: I made sure to run a completely vanilla kernel when testing why I was suddenly seeing some nasty libata errors with all kernels = v4.0. Here's a

Re: [dm-devel] Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-01 Thread Abelardo Ricart III
On Fri, 2015-05-01 at 22:47 +0100, Alasdair G Kergon wrote: On Fri, May 01, 2015 at 12:37:07AM -0400, Abelardo Ricart III wrote: # first bad commit: [cf2f1abfbd0dba701f7f16ef619e4d2485de3366] dm crypt: don't allocate pages for a partial request That's not a particularly good commit to

Re: Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-01 Thread Mike Snitzer
On Fri, May 01 2015 at 12:37am -0400, Abelardo Ricart III aric...@memnix.com wrote: I made sure to run a completely vanilla kernel when testing why I was suddenly seeing some nasty libata errors with all kernels = v4.0. Here's a snippet: 8 [

Re: [dm-devel] Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-05-01 Thread Alasdair G Kergon
On Fri, May 01, 2015 at 12:37:07AM -0400, Abelardo Ricart III wrote: # first bad commit: [cf2f1abfbd0dba701f7f16ef619e4d2485de3366] dm crypt: don't allocate pages for a partial request That's not a particularly good commit to identify. If you didn't already, can you confirm whether or not the

Regression: Disk corruption with dm-crypt and kernels >= 4.0

2015-04-30 Thread Abelardo Ricart III
I made sure to run a completely vanilla kernel when testing why I was suddenly seeing some nasty libata errors with all kernels >= v4.0. Here's a snippet: >8 [ 165.592136] ata5.00: exception Emask 0x60 SAct 0x7000 SErr 0x800 action 0x6 frozen [

Regression: Disk corruption with dm-crypt and kernels = 4.0

2015-04-30 Thread Abelardo Ricart III
I made sure to run a completely vanilla kernel when testing why I was suddenly seeing some nasty libata errors with all kernels = v4.0. Here's a snippet: 8 [ 165.592136] ata5.00: exception Emask 0x60 SAct 0x7000 SErr 0x800 action 0x6 frozen [ 165.592140]