Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Mon, Feb 06, 2017 at 06:49:42PM +, Russell King - ARM Linux wrote: > On Mon, Feb 06, 2017 at 06:46:19PM +, Will Deacon wrote: > > Converting the smc91x driver over to NAPI would probably solve this problem, > > but given the "vintage" of this code, I'd be more tempted by a simpler > >

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Mon, Feb 06, 2017 at 06:49:42PM +, Russell King - ARM Linux wrote: > On Mon, Feb 06, 2017 at 06:46:19PM +, Will Deacon wrote: > > Converting the smc91x driver over to NAPI would probably solve this problem, > > but given the "vintage" of this code, I'd be more tempted by a simpler > >

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Mon, Feb 06, 2017 at 06:46:19PM +, Will Deacon wrote: > Converting the smc91x driver over to NAPI would probably solve this problem, > but given the "vintage" of this code, I'd be more tempted by a simpler > point fix if only I could think of one. I'm not sure if converting it to NAPI

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Mon, Feb 06, 2017 at 06:46:19PM +, Will Deacon wrote: > Converting the smc91x driver over to NAPI would probably solve this problem, > but given the "vintage" of this code, I'd be more tempted by a simpler > point fix if only I could think of one. I'm not sure if converting it to NAPI

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi all, I've also stumbled over this issue with the ARM fastmodel and, somewhat embarrassingly, blamed the model developers for the regression. I'm using NFS and copying ~14MB file from NFS to a virtio-blk device which takes over 20 minutes with 4cd13c21b207, but <1 min with it reverted. I also

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi all, I've also stumbled over this issue with the ARM fastmodel and, somewhat embarrassingly, blamed the model developers for the regression. I'm using NFS and copying ~14MB file from NFS to a virtio-blk device which takes over 20 minutes with 4cd13c21b207, but <1 min with it reverted. I also

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi, On Wed, Nov 23, 2016 at 12:03:28PM -0800, Eric Dumazet wrote: On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey wrote: This patch didn't help. I did get some new traces though - I've attached the diff for the trace_printks I added. Before 4cd13c21b207:

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi, On Wed, Nov 23, 2016 at 12:03:28PM -0800, Eric Dumazet wrote: On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey wrote: This patch didn't help. I did get some new traces though - I've attached the diff for the trace_printks I added. Before 4cd13c21b207:

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey wrote: > This patch didn't help. > > I did get some new traces though - I've attached the diff for the > trace_printks I added. > > Before 4cd13c21b207: > https://drive.google.com/open?id=0B8siaK6ZjvEwcEtOeFQzTmY0Nnc > After

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey wrote: > This patch didn't help. > > I did get some new traces though - I've attached the diff for the > trace_printks I added. > > Before 4cd13c21b207: > https://drive.google.com/open?id=0B8siaK6ZjvEwcEtOeFQzTmY0Nnc > After 4cd13c21b207: >

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Tue, Nov 22, 2016 at 08:09:58AM -0800, Eric Dumazet wrote: Looks like there's a few similarly named devices and drivers. Mine is an SMSC LAN91C111 using the smc91x driver in drivers/net/ethernet/smsc/smc91x.c, rather than smc911x.c. So the interrupt handler is smc_interrupt()

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Tue, Nov 22, 2016 at 08:09:58AM -0800, Eric Dumazet wrote: Looks like there's a few similarly named devices and drivers. Mine is an SMSC LAN91C111 using the smc91x driver in drivers/net/ethernet/smsc/smc91x.c, rather than smc911x.c. So the interrupt handler is smc_interrupt()

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

> > Looks like there's a few similarly named devices and drivers. Mine is > an SMSC LAN91C111 using the smc91x driver in > drivers/net/ethernet/smsc/smc91x.c, rather than smc911x.c. So the > interrupt handler is smc_interrupt() > > CONFIG_ARCH_PXA is not set, nor is SMC_USE_PXA_DMA or SMC_USE_DMA.

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

> > Looks like there's a few similarly named devices and drivers. Mine is > an SMSC LAN91C111 using the smc91x driver in > drivers/net/ethernet/smsc/smc91x.c, rather than smc911x.c. So the > interrupt handler is smc_interrupt() > > CONFIG_ARCH_PXA is not set, nor is SMC_USE_PXA_DMA or SMC_USE_DMA.

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Tue, Nov 22, 2016 at 06:29:33AM -0800, Eric Dumazet wrote: On Tue, Nov 22, 2016 at 2:33 AM, Brian Starkey wrote: Hi, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Tue, Nov 22, 2016 at 06:29:33AM -0800, Eric Dumazet wrote: On Tue, Nov 22, 2016 at 2:33 AM, Brian Starkey wrote: Hi, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Tue, Nov 22, 2016 at 2:33 AM, Brian Starkey wrote: > > Hi, > > On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: >> >> Brian, >> >> On Thu, 17 Nov 2016, Brian Starkey wrote: >>> >>> No joy with this patch :-( >>> >>> I had to add an ioaddr argument because

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Tue, Nov 22, 2016 at 2:33 AM, Brian Starkey wrote: > > Hi, > > On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: >> >> Brian, >> >> On Thu, 17 Nov 2016, Brian Starkey wrote: >>> >>> No joy with this patch :-( >>> >>> I had to add an ioaddr argument because apparently that macro

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an ioaddr argument because apparently that macro depends on local context (yuck...), but it doesn't help my issue. FWIW I don't see

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an ioaddr argument because apparently that macro depends on local context (yuck...), but it doesn't help my issue. FWIW I don't see

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Thomas, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an ioaddr argument because apparently that macro depends on local context (yuck...), but it doesn't help my issue. FWIW I

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Thomas, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an ioaddr argument because apparently that macro depends on local context (yuck...), but it doesn't help my issue. FWIW I

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: > No joy with this patch :-( > > I had to add an ioaddr argument because apparently that macro depends > on local context (yuck...), but it doesn't help my issue. > > FWIW I don't see any timeouts, either with or without the patch. > (I don't

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: > No joy with this patch :-( > > I had to add an ioaddr argument because apparently that macro depends > on local context (yuck...), but it doesn't help my issue. > > FWIW I don't see any timeouts, either with or without the patch. > (I don't

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Thu, Nov 17, 2016 at 07:29:14AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 1:01 PM, Brian Starkey wrote: On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote:

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Thu, Nov 17, 2016 at 07:29:14AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 1:01 PM, Brian Starkey wrote: On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: The smc91x driver does seem to have some

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 1:01 PM, Brian Starkey wrote: > On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: >> >> On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey >> wrote: >> >>> >>> The smc91x driver does seem to have some trickiness

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 1:01 PM, Brian Starkey wrote: > On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: >> >> On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey >> wrote: >> >>> >>> The smc91x driver does seem to have some trickiness around softirqs. >>> I'm not familiar with net

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: The smc91x driver does seem to have some trickiness around softirqs. I'm not familiar with net drivers, but I'll see if I can figure anything out there.

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: The smc91x driver does seem to have some trickiness around softirqs. I'm not familiar with net drivers, but I'll see if I can figure anything out there. Oh this code looks

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: > > The smc91x driver does seem to have some trickiness around softirqs. > I'm not familiar with net drivers, but I'll see if I can figure > anything out there. Oh this code looks ugly :( Do you have CONFIG_SMP=y or

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: > > The smc91x driver does seem to have some trickiness around softirqs. > I'm not familiar with net drivers, but I'll see if I can figure > anything out there. Oh this code looks ugly :( Do you have CONFIG_SMP=y or not ?

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Wed, Nov 16, 2016 at 07:52:42AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: Hi, I'm running an ARM FVP (virtual platform - simluated hardware), which is failing to reach a login prompt due to extremely slow progress

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi Eric, On Wed, Nov 16, 2016 at 07:52:42AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: Hi, I'm running an ARM FVP (virtual platform - simluated hardware), which is failing to reach a login prompt due to extremely slow progress during boot. systemd gives

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: > Hi, > > I'm running an ARM FVP (virtual platform - simluated hardware), which > is failing to reach a login prompt due to extremely slow progress > during boot. systemd gives up waiting for the ttyAMA0 device to >

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: > Hi, > > I'm running an ARM FVP (virtual platform - simluated hardware), which > is failing to reach a login prompt due to extremely slow progress > during boot. systemd gives up waiting for the ttyAMA0 device to > appear, and never starts

Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi, I'm running an ARM FVP (virtual platform - simluated hardware), which is failing to reach a login prompt due to extremely slow progress during boot. systemd gives up waiting for the ttyAMA0 device to appear, and never starts the getty. I've bisected this to commit 4cd13c21b207 "softirq: Let

Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Hi, I'm running an ARM FVP (virtual platform - simluated hardware), which is failing to reach a login prompt due to extremely slow progress during boot. systemd gives up waiting for the ttyAMA0 device to appear, and never starts the getty. I've bisected this to commit 4cd13c21b207 "softirq: Let