Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-08-10 Thread Jan Engelhardt
On Saturday 2012-07-07 23:19, Kay Sievers wrote: >On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds > wrote: >> Kay, this needs to be fixed. >> >> Suggested fix: just use the 'seq_printf()' interfaces, which do the >> proper buffering, and allow any size reads of various packetized data. > >I'll

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-08-10 Thread Jan Engelhardt
On Saturday 2012-07-07 23:19, Kay Sievers wrote: On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds torva...@linux-foundation.org wrote: Kay, this needs to be fixed. Suggested fix: just use the 'seq_printf()' interfaces, which do the proper buffering, and allow any size reads of various

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-07 Thread Kay Sievers
On Sat, 2012-07-07 at 23:19 +0200, Kay Sievers wrote: > On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds > wrote: > > Kay, this needs to be fixed. > > > > Suggested fix: just use the 'seq_printf()' interfaces, which do the > > proper buffering, and allow any size reads of various packetized data.

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-07 Thread Kay Sievers
On Sat, Jul 7, 2012 at 12:05 AM, Jukka Ollila wrote: > And I did a little digging. According to the Debian package tracking > system[1] it would seem that the _stable_ distro carries a version > that doesn't do the dd shuffling at all and probably runs its klogd as > root, reading /proc/kmsg

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-07 Thread Kay Sievers
On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds wrote: > Kay, this needs to be fixed. > > Suggested fix: just use the 'seq_printf()' interfaces, which do the > proper buffering, and allow any size reads of various packetized data. I'll have a look. > Of course, I'd also suggest that whoever was

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-07 Thread Kay Sievers
On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds torva...@linux-foundation.org wrote: Kay, this needs to be fixed. Suggested fix: just use the 'seq_printf()' interfaces, which do the proper buffering, and allow any size reads of various packetized data. I'll have a look. Of course, I'd also

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-07 Thread Kay Sievers
On Sat, Jul 7, 2012 at 12:05 AM, Jukka Ollila jiikst...@gmail.com wrote: And I did a little digging. According to the Debian package tracking system[1] it would seem that the _stable_ distro carries a version that doesn't do the dd shuffling at all and probably runs its klogd as root, reading

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-07 Thread Kay Sievers
On Sat, 2012-07-07 at 23:19 +0200, Kay Sievers wrote: On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds torva...@linux-foundation.org wrote: Kay, this needs to be fixed. Suggested fix: just use the 'seq_printf()' interfaces, which do the proper buffering, and allow any size reads of

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Linus Torvalds
On Fri, Jul 6, 2012 at 3:05 PM, Jukka Ollila wrote: > > Now this got me wondering if Debian _unstable_ actually qualifies as a > standard distro userspace. Oh, if the kernel breaks some standard user space, that counts. Tons of people run Debian unstable (and from my limited interactions with

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Jukka Ollila
On Fri, Jul 6, 2012 at 10:38 PM, Alan Cox wrote: > On Fri, 6 Jul 2012 20:45:44 +0300 > Jukka Ollila wrote: >> A few days ago I filed a kernel regression report concerning a change >> in /proc/kmsg behaviour with short reads: >> >> https://bugzilla.kernel.org/show_bug.cgi?id=44211 >> I don't

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Linus Torvalds
Kay, this needs to be fixed. Suggested fix: just use the 'seq_printf()' interfaces, which do the proper buffering, and allow any size reads of various packetized data. Of course, I'd also suggest that whoever was the genius who thought it was a good idea to read things ONE F*CKING BYTE AT A TIME

Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Alan Cox
On Fri, 6 Jul 2012 20:45:44 +0300 Jukka Ollila wrote: > Hello, > > A few days ago I filed a kernel regression report concerning a change > in /proc/kmsg behaviour with short reads: > > https://bugzilla.kernel.org/show_bug.cgi?id=44211 > > The comments suggest that this is probably

Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Alan Cox
On Fri, 6 Jul 2012 20:45:44 +0300 Jukka Ollila jiikst...@gmail.com wrote: Hello, A few days ago I filed a kernel regression report concerning a change in /proc/kmsg behaviour with short reads: https://bugzilla.kernel.org/show_bug.cgi?id=44211 The comments suggest that this is probably

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Linus Torvalds
Kay, this needs to be fixed. Suggested fix: just use the 'seq_printf()' interfaces, which do the proper buffering, and allow any size reads of various packetized data. Of course, I'd also suggest that whoever was the genius who thought it was a good idea to read things ONE F*CKING BYTE AT A TIME

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Jukka Ollila
On Fri, Jul 6, 2012 at 10:38 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Fri, 6 Jul 2012 20:45:44 +0300 Jukka Ollila jiikst...@gmail.com wrote: A few days ago I filed a kernel regression report concerning a change in /proc/kmsg behaviour with short reads:

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

2012-07-06 Thread Linus Torvalds
On Fri, Jul 6, 2012 at 3:05 PM, Jukka Ollila jiikst...@gmail.com wrote: Now this got me wondering if Debian _unstable_ actually qualifies as a standard distro userspace. Oh, if the kernel breaks some standard user space, that counts. Tons of people run Debian unstable (and from my limited