RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Joakim Zhang
inux-tegra > > Subject: RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resume back > > > > -Original Message- > > From: Thierry Reding > > Sent: 2021年4月14日 15:41 > > To: Joakim Zhang > > Cc: David S. Miller ; Jakub Kicinski

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Joakim Zhang
inux-tegra > > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resume back > > On Wed, Apr 14, 2021 at 02:18:58AM +, Joakim Zhang wrote: > > > > > -Original Message- > > > From: Thierry Reding > > > Sent:

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Thierry Reding
> Alexandre Torgue ; Jose Abreu > > ; net...@vger.kernel.org; Linux Kernel Mailing List > > ; linux-tegra > > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > > resume back > > > > On Tue, Apr 13, 2021 at 12:13:01PM +

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Joakim Zhang
linux-tegra > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resume back > > On Tue, Apr 13, 2021 at 12:13:01PM +, Joakim Zhang wrote: > > > > Hi Jon, > > > > > -Original Message- > > > From: Jon Hunte

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Jakub Kicinski
On Tue, 13 Apr 2021 18:06:39 +0200 Thierry Reding wrote: > given where we are in the release cycle, I think it'd be best to revert > commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume > back") for now. > > To summarize the discussion: the patch was meant as a workaround to fix >

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Thierry Reding
: net...@vger.kernel.org; Linux Kernel Mailing List > > ; linux-tegra ; > > Jakub Kicinski > > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > > resume back > > > > > > On 01/04/2021 17:28, Jon Hunter wrote: > > > &

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Joakim Zhang
Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resume back > > > On 01/04/2021 17:28, Jon Hunter wrote: > > > > On 31/03/2021 12:41, Joakim Zhang wrote: > > > > ... > > > >>> In answer to your question, resuming from sus

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Jon Hunter
On 01/04/2021 17:28, Jon Hunter wrote: > > On 31/03/2021 12:41, Joakim Zhang wrote: > > ... > >>> In answer to your question, resuming from suspend does work on this board >>> without your change. We have been testing suspend/resume now on this board >>> since Linux v5.8 and so we have the abi

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-01 Thread Jon Hunter
On 31/03/2021 12:41, Joakim Zhang wrote: ... >> In answer to your question, resuming from suspend does work on this board >> without your change. We have been testing suspend/resume now on this board >> since Linux v5.8 and so we have the ability to bisect such regressions. So >> it is >> clea

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Joakim Zhang
ion v5.12-rc3: net: stmmac: re-init rx buffers when mac > resume back > > > On 31/03/2021 12:10, Joakim Zhang wrote: > > ... > > >>>>>>>> You mean one of your boards? Does other boards with STMMAC can > >>>>>>>&

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Jon Hunter
On 31/03/2021 12:10, Joakim Zhang wrote: ... You mean one of your boards? Does other boards with STMMAC can work >>> fine? >>> >>> We have two devices with the STMMAC and one works OK and the >>> other > fails. >>> They are different generation of devic

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Jon Hunter
On 31/03/2021 08:43, Joakim Zhang wrote: ... >>> You mean one of your boards? Does other boards with STMMAC can >>> work >> fine? >> >> We have two devices with the STMMAC and one works OK and the other fails. >> They are different generation of device and so there

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年3月31日 15:44 > To: Jon Hunter > Cc: net...@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: RE: Regression v5.12-rc3: net: stmmac: re-init rx buffer

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月30日 20:51 > To: Joakim Zhang > Cc: net...@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resu

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-30 Thread Jon Hunter
On 25/03/2021 08:12, Joakim Zhang wrote: ... > You mean one of your boards? Does other boards with STMMAC can work fine? We have two devices with the STMMAC and one works OK and the other >> fails. They are different generation of device and so there could be some

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-25 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月25日 16:01 > To: Joakim Zhang > Cc: net...@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > r

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-25 Thread Jon Hunter
On 25/03/2021 07:53, Joakim Zhang wrote: > >> -Original Message- >> From: Jon Hunter >> Sent: 2021年3月24日 20:39 >> To: Joakim Zhang >> Cc: net...@vger.kernel.org; Linux Kernel Mailing List >> ; linux-tegra ; >> Jakub Kicinski >> Subj

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-25 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月24日 20:39 > To: Joakim Zhang > Cc: net...@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resu

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-24 Thread Jon Hunter
On 24/03/2021 12:20, Joakim Zhang wrote: ... > Sorry for this breakage at your side. > > You mean one of your boards? Does other boards with STMMAC can work fine? We have two devices with the STMMAC and one works OK and the other fails. They are different generation of device and so there co

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-24 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月24日 18:51 > To: Joakim Zhang > Cc: net...@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac >

Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-24 Thread Jon Hunter
Hi Joakim, Starting with v5.12-rc3 I noticed that one of our boards, Tegra186 Jetson TX2, was not long resuming from suspend. Bisect points to commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume back") and reverting this on top of mainline fixes the problem. Interestingly, the b