Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-13 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 10:22:36PM -0800, Andrew Morton wrote: > > On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > > wrote: ... > > And there is absolutely no negotiations about this, I've held back on > > this for nearly 2 years, and nothing has happened, this code is

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-13 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 10:22:36PM -0800, Andrew Morton wrote: On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: ... And there is absolutely no negotiations about this, I've held back on this for nearly 2 years, and nothing has happened, this code is not

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread Andrew Morton
> On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Mon, 12 Mar 2007 12:51:37 +0100 > > > But until then it'll unnecessarily spoil linux opinion as regards > > stability and waste time of developers to check

Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 12:51:37 +0100 > But until then it'll unnecessarily spoil linux opinion as regards > stability and waste time of developers to check error messages. > So, maybe it's less evil to check those NULLs where possible and add > some

Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 12:51:37 +0100 But until then it'll unnecessarily spoil linux opinion as regards stability and waste time of developers to check error messages. So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread Andrew Morton
On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 12:51:37 +0100 But until then it'll unnecessarily spoil linux opinion as regards stability and waste time of developers to check error messages.