Re: [PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread Guenter Roeck
On Fri, Jan 04, 2019 at 10:03:42AM -0800, Linus Torvalds wrote: > On Fri, Jan 4, 2019 at 9:42 AM Guenter Roeck wrote: > > > > ... and this is just the very first build I happened to try this morning. > > It will fail for all sparc32 builds. And unlike the powerpc case, I > hadn't even noticed

Re: [PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread Linus Torvalds
On Fri, Jan 4, 2019 at 9:42 AM Guenter Roeck wrote: > > ... and this is just the very first build I happened to try this morning. It will fail for all sparc32 builds. And unlike the powerpc case, I hadn't even noticed this one. Trivial fix for powerpc/sparc32 pushed out. Hopefully that was all

Re: [PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread Linus Torvalds
On Fri, Jan 4, 2019 at 1:28 AM Mathieu Malaterre wrote: > > Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with > access_ok()") to fix the following compilation error: Gaah. I even *looked* at the powerpc use of 'type', but then when I was actually going through my manual

Re: [PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread LEROY Christophe
Mathieu Malaterre a écrit : In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with access_ok()") an attempt was made to remove a warning by referencing the variable `type`, however in commit 96d4f267e40f ("Remove 'type' argument from access_ok() function") the

Re: Remove 'type' argument from access_ok() function

2019-01-04 Thread Michael Ellerman
On Fri, 2019-01-04 at 09:27:58 UTC, Mathieu Malaterre wrote: > In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with > access_ok()") an attempt was made to remove a warning by referencing the > variable `type`, however in commit 96d4f267e40f ("Remove 'type' a

[PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread Mathieu Malaterre
In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with access_ok()") an attempt was made to remove a warning by referencing the variable `type`, however in commit 96d4f267e40f ("Remove 'type' argument from access_ok() function") the variable `type` has been rem