Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Eric W. Biederman
"Kay Sievers" <[EMAIL PROTECTED]> writes: > That cruft is going away with the block patch in your tree. And it doesn't matter because it is a separate mount anyway. Although I have to admit I hadn't taken that mount into account earlier. Eric -- To unsubscribe from this list: send the line

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Kay Sievers
On Dec 2, 2007 11:53 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Sun, Dec 02, 2007 at 03:22:46PM -0700, Eric W. Biederman wrote: > > Greg KH <[EMAIL PROTECTED]> writes: > > > > > On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: > > >> On Dec 2, 2007 12:48 PM, Greg KH <[EMAIL PROTECTED]>

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Greg KH
On Sun, Dec 02, 2007 at 03:22:46PM -0700, Eric W. Biederman wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: > >> On Dec 2, 2007 12:48 PM, Greg KH <[EMAIL PROTECTED]> wrote: > >> ... > >> > > and where is a detailed explaination on

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Eric W. Biederman
Greg KH <[EMAIL PROTECTED]> writes: > On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: >> On Dec 2, 2007 12:48 PM, Greg KH <[EMAIL PROTECTED]> wrote: >> ... >> > > and where is a detailed explaination on kern_mount? could someone give >> > > some comments or documentation pointers on this?

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: On Dec 2, 2007 12:48 PM, Greg KH [EMAIL PROTECTED] wrote: ... and where is a detailed explaination on kern_mount? could someone give some comments or documentation pointers on this? See the

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Greg KH
On Sun, Dec 02, 2007 at 03:22:46PM -0700, Eric W. Biederman wrote: Greg KH [EMAIL PROTECTED] writes: On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: On Dec 2, 2007 12:48 PM, Greg KH [EMAIL PROTECTED] wrote: ... and where is a detailed explaination on kern_mount? could someone

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Kay Sievers
On Dec 2, 2007 11:53 PM, Greg KH [EMAIL PROTECTED] wrote: On Sun, Dec 02, 2007 at 03:22:46PM -0700, Eric W. Biederman wrote: Greg KH [EMAIL PROTECTED] writes: On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: On Dec 2, 2007 12:48 PM, Greg KH [EMAIL PROTECTED] wrote: ...

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Eric W. Biederman
Kay Sievers [EMAIL PROTECTED] writes: That cruft is going away with the block patch in your tree. And it doesn't matter because it is a separate mount anyway. Although I have to admit I hadn't taken that mount into account earlier. Eric -- To unsubscribe from this list: send the line

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread Greg KH
On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: > On Dec 2, 2007 12:48 PM, Greg KH <[EMAIL PROTECTED]> wrote: > ... > > > and where is a detailed explaination on kern_mount? could someone give > > > some comments or documentation pointers on this? > > > > See the patches that Eric Biederman

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread rae l
On Dec 2, 2007 12:48 PM, Greg KH <[EMAIL PROTECTED]> wrote: ... > > and where is a detailed explaination on kern_mount? could someone give > > some comments or documentation pointers on this? > > See the patches that Eric Biederman just posted to lkml for why this > structure is a static pointer

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread Greg KH
On Sun, Dec 02, 2007 at 04:31:09AM +0800, rae l wrote: > --- > and I still have questions about this code: > 1. Why here kern_mount is needed? > Or the first time user space `mount -t sysfs` won't do that? > 2. If root executes many mounts to mount sysfs on /sys and many other places, >

Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread rae l
--- and I still have questions about this code: 1. Why here kern_mount is needed? Or the first time user space `mount -t sysfs` won't do that? 2. If root executes many mounts to mount sysfs on /sys and many other places, are there many instances of struct vfsmount those have only

Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread rae l
--- and I still have questions about this code: 1. Why here kern_mount is needed? Or the first time user space `mount -t sysfs` won't do that? 2. If root executes many mounts to mount sysfs on /sys and many other places, are there many instances of struct vfsmount those have only

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread Greg KH
On Sun, Dec 02, 2007 at 04:31:09AM +0800, rae l wrote: --- and I still have questions about this code: 1. Why here kern_mount is needed? Or the first time user space `mount -t sysfs` won't do that? 2. If root executes many mounts to mount sysfs on /sys and many other places, are

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread rae l
On Dec 2, 2007 12:48 PM, Greg KH [EMAIL PROTECTED] wrote: ... and where is a detailed explaination on kern_mount? could someone give some comments or documentation pointers on this? See the patches that Eric Biederman just posted to lkml for why this structure is a static pointer this way

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-01 Thread Greg KH
On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: On Dec 2, 2007 12:48 PM, Greg KH [EMAIL PROTECTED] wrote: ... and where is a detailed explaination on kern_mount? could someone give some comments or documentation pointers on this? See the patches that Eric Biederman just posted