Theodore Ts'o writes:
> Dr. Michael Weller writes:
> > Sorry, I've no idea about the ext2 and fs implementation.
> > However did you read the comment below and convince yourself that 'err' is
> > always set correctly?
>
> I looked at it and was convinced.
Ted and I submitted patches to this
>Also, I might be wrong, but maybe you should submit things to Alan, not
>Linus, could be it suffices to post them here though.
>
> Actually, life is a little bit easier when you give the subsystem
> maintainer a chance to submit patches to Linus.
For 2.2.x you can submit me stuff. Im
Date:Fri, 1 Sep 2000 12:47:44 +0200 (MESZ)
From: "Dr. Michael Weller" <[EMAIL PROTECTED]>
Sorry, I've no idea about the ext2 and fs implementation.
However did you read the comment below and convince yourself that 'err' is
always set correctly?
I looked at it and was
Hi Michael,
It is better to assume that he has done the checks and then do the checks
to convince yourself (as they say in russia "doverjaj no proverjaj" -
"trust but always double-check").
So, I now went fs/ext2/ialloc.c and did that for you - ext2_new_inode()
does indeed set err accordingly
Sorry, I've no idea about the ext2 and fs implementation.
However did you read the comment below and convince yourself that 'err' is
always set correctly?
I'm just asking because you don't mention it and no patch to
ext2_new_inode that makes it set err correctly is provided. It could be
the
Hello.
Following patch against 2.4.0-test7 fixes returning of errors from
ext2_new_inode(). Currenly if ext2_new_inode() failed EIO was returned
from functions like ext2_create() which is bad as it can fail also
with EDQUOT and such.
Hello.
Following patch against 2.4.0-test7 fixes returning of errors from
ext2_new_inode(). Currenly if ext2_new_inode() failed EIO was returned
from functions like ext2_create() which is bad as it can fail also
with EDQUOT and such.
Sorry, I've no idea about the ext2 and fs implementation.
However did you read the comment below and convince yourself that 'err' is
always set correctly?
I'm just asking because you don't mention it and no patch to
ext2_new_inode that makes it set err correctly is provided. It could be
the
Hi Michael,
It is better to assume that he has done the checks and then do the checks
to convince yourself (as they say in russia "doverjaj no proverjaj" -
"trust but always double-check").
So, I now went fs/ext2/ialloc.c and did that for you - ext2_new_inode()
does indeed set err accordingly
9 matches
Mail list logo
