Re: Tagged pointers in the XArray

2018-08-29 Thread Matthew Wilcox
On Tue, Aug 28, 2018 at 03:27:27PM -0700, Matthew Wilcox wrote: > I find myself caught between two traditions. > > On the one hand, the radix tree has been calling the page cache dirty & > writeback bits "tags" for over a decade. > > On the other hand, using some of the bits _in a pointer_ as a t

Re: Tagged pointers in the XArray

2018-08-28 Thread Gao Xiang
Hi, On 2018/8/29 6:27, Matthew Wilcox wrote: > I find myself caught between two traditions. > > On the one hand, the radix tree has been calling the page cache dirty & > writeback bits "tags" for over a decade. > > On the other hand, using some of the bits _in a pointer_ as a tag has been > common

Re: Tagged pointers in the XArray

2018-08-28 Thread Randy Dunlap
On 08/28/2018 04:03 PM, Matthew Wilcox wrote: > On Tue, Aug 28, 2018 at 03:39:01PM -0700, Randy Dunlap wrote: >> Just a question, please... >> >> On 08/28/2018 03:27 PM, Matthew Wilcox wrote: >>> >>> diff --git a/include/linux/xarray.h b/include/linux/xarray.h >>> index c74556ea4258..d1b383f3063f 1

Re: Tagged pointers in the XArray

2018-08-28 Thread Matthew Wilcox
On Tue, Aug 28, 2018 at 03:39:01PM -0700, Randy Dunlap wrote: > Just a question, please... > > On 08/28/2018 03:27 PM, Matthew Wilcox wrote: > > > > diff --git a/include/linux/xarray.h b/include/linux/xarray.h > > index c74556ea4258..d1b383f3063f 100644 > > --- a/include/linux/xarray.h > > +++ b/

Re: Tagged pointers in the XArray

2018-08-28 Thread Randy Dunlap
Just a question, please... On 08/28/2018 03:27 PM, Matthew Wilcox wrote: > > diff --git a/include/linux/xarray.h b/include/linux/xarray.h > index c74556ea4258..d1b383f3063f 100644 > --- a/include/linux/xarray.h > +++ b/include/linux/xarray.h > @@ -150,6 +150,54 @@ static inline int xa_err(void *e

Tagged pointers in the XArray

2018-08-28 Thread Matthew Wilcox
I find myself caught between two traditions. On the one hand, the radix tree has been calling the page cache dirty & writeback bits "tags" for over a decade. On the other hand, using some of the bits _in a pointer_ as a tag has been common practice since at least the 1960s. https://en.wikipedia