Re: [patch] ipv4: Update ip command line processing (take II)

2007-12-25 Thread Simon Horman
On Tue, Dec 25, 2007 at 08:55:43PM -0800, David Miller wrote: > From: Simon Horman <[EMAIL PROTECTED]> > Date: Wed, 26 Dec 2007 11:59:05 +0900 > > > Recently the documentation in Documentation/nfsroot.txt was > > update to note that in fact ip=off and ip=::off as the > > latter is ignored and

Re: [patch] ipv4: Update ip command line processing (take II)

2007-12-25 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Wed, 26 Dec 2007 11:59:05 +0900 > Recently the documentation in Documentation/nfsroot.txt was > update to note that in fact ip=off and ip=::off as the > latter is ignored and the default (on) is used. > > This was certainly a step in the direction

[patch] ipv4: Update ip command line processing (take II)

2007-12-25 Thread Simon Horman
Recently the documentation in Documentation/nfsroot.txt was update to note that in fact ip=off and ip=::off as the latter is ignored and the default (on) is used. This was certainly a step in the direction of reducing confusion. But it seems to me that the code ought to be fixed up so that

[patch] ipv4: Update ip command line processing (take II)

2007-12-25 Thread Simon Horman
Recently the documentation in Documentation/nfsroot.txt was update to note that in fact ip=off and ip=::off as the latter is ignored and the default (on) is used. This was certainly a step in the direction of reducing confusion. But it seems to me that the code ought to be fixed up so that

Re: [patch] ipv4: Update ip command line processing (take II)

2007-12-25 Thread David Miller
From: Simon Horman [EMAIL PROTECTED] Date: Wed, 26 Dec 2007 11:59:05 +0900 Recently the documentation in Documentation/nfsroot.txt was update to note that in fact ip=off and ip=::off as the latter is ignored and the default (on) is used. This was certainly a step in the direction of

Re: [patch] ipv4: Update ip command line processing (take II)

2007-12-25 Thread Simon Horman
On Tue, Dec 25, 2007 at 08:55:43PM -0800, David Miller wrote: From: Simon Horman [EMAIL PROTECTED] Date: Wed, 26 Dec 2007 11:59:05 +0900 Recently the documentation in Documentation/nfsroot.txt was update to note that in fact ip=off and ip=::off as the latter is ignored and the

Re: Update ip command line processing

2007-12-20 Thread Simon Horman
On Thu, Dec 20, 2007 at 03:21:21PM -0800, David Miller wrote: > From: Simon Horman <[EMAIL PROTECTED]> > Date: Tue, 18 Dec 2007 17:57:32 +0900 > > > @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); > > */ > > static int __init ic_proto_name(char *name) > > { > > + if (!name) { > > +

Re: Update ip command line processing

2007-12-20 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Tue, 18 Dec 2007 17:57:32 +0900 > @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); > */ > static int __init ic_proto_name(char *name) > { > + if (!name) { > + return 1; > + } I do not see any circumstance under which this

Re: Update ip command line processing

2007-12-20 Thread David Miller
From: Simon Horman [EMAIL PROTECTED] Date: Tue, 18 Dec 2007 17:57:32 +0900 @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); */ static int __init ic_proto_name(char *name) { + if (!name) { + return 1; + } I do not see any circumstance under which this pointer

Re: Update ip command line processing

2007-12-20 Thread Simon Horman
On Thu, Dec 20, 2007 at 03:21:21PM -0800, David Miller wrote: From: Simon Horman [EMAIL PROTECTED] Date: Tue, 18 Dec 2007 17:57:32 +0900 @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); */ static int __init ic_proto_name(char *name) { + if (!name) { + return 1;

Update ip command line processing

2007-12-18 Thread Simon Horman
Recently the documentation in Documentation/nfsroot.txt was update to note that in fact ip=off and ip=::off as the latter is ignored and the default (on) is used. This was certainly a step in the direction of reducing confusion. But it seems to me that the code ought to be fixed up so that

Update ip command line processing

2007-12-18 Thread Simon Horman
Recently the documentation in Documentation/nfsroot.txt was update to note that in fact ip=off and ip=::off as the latter is ignored and the default (on) is used. This was certainly a step in the direction of reducing confusion. But it seems to me that the code ought to be fixed up so that