Re: __sb_start_write() && force_trylock hack

2015-08-21 Thread Oleg Nesterov
On 08/20, Dave Chinner wrote: > > On Wed, Aug 19, 2015 at 05:00:26PM +0200, Oleg Nesterov wrote: > > > > Yes, we hold SB_FREEZE_WRITE lock, so recursive SB_FREEZE_FS is safe. > > > > But, this means that the comment in __sb_start_write() is still correct, > > "XFS for example gets freeze

Re: __sb_start_write() force_trylock hack

2015-08-21 Thread Oleg Nesterov
On 08/20, Dave Chinner wrote: On Wed, Aug 19, 2015 at 05:00:26PM +0200, Oleg Nesterov wrote: Yes, we hold SB_FREEZE_WRITE lock, so recursive SB_FREEZE_FS is safe. But, this means that the comment in __sb_start_write() is still correct, XFS for example gets freeze protection on internal

Re: __sb_start_write() && force_trylock hack

2015-08-19 Thread Dave Chinner
On Wed, Aug 19, 2015 at 05:00:26PM +0200, Oleg Nesterov wrote: > On 08/19, Dave Chinner wrote: > > > > On Tue, Aug 18, 2015 at 04:49:00PM +0200, Oleg Nesterov wrote: > > > Jan, Dave, perhaps you can take a look... > > > > > > On 08/14, Oleg Nesterov wrote: > > > > > > > > Plus another patch which

Re: __sb_start_write() && force_trylock hack

2015-08-19 Thread Oleg Nesterov
On 08/19, Dave Chinner wrote: > > On Tue, Aug 18, 2015 at 04:49:00PM +0200, Oleg Nesterov wrote: > > Jan, Dave, perhaps you can take a look... > > > > On 08/14, Oleg Nesterov wrote: > > > > > > Plus another patch which removes the "trylock" > > > hack in __sb_start_write(). > > > > I meant the

Re: __sb_start_write() force_trylock hack

2015-08-19 Thread Oleg Nesterov
On 08/19, Dave Chinner wrote: On Tue, Aug 18, 2015 at 04:49:00PM +0200, Oleg Nesterov wrote: Jan, Dave, perhaps you can take a look... On 08/14, Oleg Nesterov wrote: Plus another patch which removes the trylock hack in __sb_start_write(). I meant the patch we already discussed

Re: __sb_start_write() force_trylock hack

2015-08-19 Thread Dave Chinner
On Wed, Aug 19, 2015 at 05:00:26PM +0200, Oleg Nesterov wrote: On 08/19, Dave Chinner wrote: On Tue, Aug 18, 2015 at 04:49:00PM +0200, Oleg Nesterov wrote: Jan, Dave, perhaps you can take a look... On 08/14, Oleg Nesterov wrote: Plus another patch which removes the trylock

Re: __sb_start_write() && force_trylock hack

2015-08-18 Thread Dave Chinner
On Tue, Aug 18, 2015 at 05:18:16PM +0200, Oleg Nesterov wrote: > On 08/18, Oleg Nesterov wrote: > > > > When I tried to run all tests, I > > got the new reports from lockdep. > > Just in case... when I run all tests I see misc failures (with or without > the changes above) which I didn't try to

Re: __sb_start_write() && force_trylock hack

2015-08-18 Thread Dave Chinner
On Tue, Aug 18, 2015 at 04:49:00PM +0200, Oleg Nesterov wrote: > Jan, Dave, perhaps you can take a look... > > On 08/14, Oleg Nesterov wrote: > > > > Plus another patch which removes the "trylock" > > hack in __sb_start_write(). > > I meant the patch we already discussed (attached at the end).

Re: __sb_start_write() && force_trylock hack

2015-08-18 Thread Oleg Nesterov
On 08/18, Oleg Nesterov wrote: > > When I tried to run all tests, I > got the new reports from lockdep. Just in case... when I run all tests I see misc failures (with or without the changes above) which I didn't try to interpret. In particular xfs/073 just hangs, "shutdown -r" doesn't work, the

__sb_start_write() && force_trylock hack

2015-08-18 Thread Oleg Nesterov
Jan, Dave, perhaps you can take a look... On 08/14, Oleg Nesterov wrote: > > Plus another patch which removes the "trylock" > hack in __sb_start_write(). I meant the patch we already discussed (attached at the end). And yes, previously I reported it passed the tests. However, I only ran the same

Re: __sb_start_write() force_trylock hack

2015-08-18 Thread Dave Chinner
On Tue, Aug 18, 2015 at 04:49:00PM +0200, Oleg Nesterov wrote: Jan, Dave, perhaps you can take a look... On 08/14, Oleg Nesterov wrote: Plus another patch which removes the trylock hack in __sb_start_write(). I meant the patch we already discussed (attached at the end). And yes,

Re: __sb_start_write() force_trylock hack

2015-08-18 Thread Dave Chinner
On Tue, Aug 18, 2015 at 05:18:16PM +0200, Oleg Nesterov wrote: On 08/18, Oleg Nesterov wrote: When I tried to run all tests, I got the new reports from lockdep. Just in case... when I run all tests I see misc failures (with or without the changes above) which I didn't try to interpret.

__sb_start_write() force_trylock hack

2015-08-18 Thread Oleg Nesterov
Jan, Dave, perhaps you can take a look... On 08/14, Oleg Nesterov wrote: Plus another patch which removes the trylock hack in __sb_start_write(). I meant the patch we already discussed (attached at the end). And yes, previously I reported it passed the tests. However, I only ran the same

Re: __sb_start_write() force_trylock hack

2015-08-18 Thread Oleg Nesterov
On 08/18, Oleg Nesterov wrote: When I tried to run all tests, I got the new reports from lockdep. Just in case... when I run all tests I see misc failures (with or without the changes above) which I didn't try to interpret. In particular xfs/073 just hangs, shutdown -r doesn't work, the serial