Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-15 Thread Joe Perches
On Mon, 2013-04-15 at 07:58 +0200, Heiko Carstens wrote: > On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: > > On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > > > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > > > Commit ea81531d ("s390/uaccess: fix page

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-15 Thread Joe Perches
On Mon, 2013-04-15 at 07:58 +0200, Heiko Carstens wrote: On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: Commit ea81531d (s390/uaccess: fix page table walk)

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Heiko Carstens
On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: > On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > > Commit ea81531d ("s390/uaccess: fix page table walk") > > > added this code. It looks like it should have

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Joe Perches
On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > Commit ea81531d ("s390/uaccess: fix page table walk") > > added this code. It looks like it should have break; > > for each case. > no, the fallthrough is on purpose for

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Heiko Carstens
On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > Hello Heiko. > > Commit ea81531d ("s390/uaccess: fix page table walk") > added this code. It looks like it should have break; > for each case. Hi Joe, no, the fallthrough is on purpose for each case statement. > static unsigned

arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Joe Perches
Hello Heiko. Commit ea81531d ("s390/uaccess: fix page table walk") added this code. It looks like it should have break; for each case. static unsigned long follow_table(struct mm_struct *mm, unsigned long address, int write) { unsigned

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Heiko Carstens
On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: Hello Heiko. Commit ea81531d (s390/uaccess: fix page table walk) added this code. It looks like it should have break; for each case. Hi Joe, no, the fallthrough is on purpose for each case statement. static unsigned long

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Joe Perches
On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: Commit ea81531d (s390/uaccess: fix page table walk) added this code. It looks like it should have break; for each case. no, the fallthrough is on purpose for each case

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Heiko Carstens
On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: Commit ea81531d (s390/uaccess: fix page table walk) added this code. It looks like it should have break;

arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Joe Perches
Hello Heiko. Commit ea81531d (s390/uaccess: fix page table walk) added this code. It looks like it should have break; for each case. static unsigned long follow_table(struct mm_struct *mm, unsigned long address, int write) { unsigned long