Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-13 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:59:05PM +0800, Frankie Chang wrote: > On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote: > > On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > > > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > > > - The reason why printing

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-11 Thread Frankie Chang
On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > > - The reason why printing the related information to > > > > kernel information log but not trace

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-11 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > - The reason why printing the related information to > > > kernel information log but not trace buffer is that > > > some abnormal transactions may be pending for

[PATCH v14] binder: add transaction latency tracer

2020-11-11 Thread Frankie Chang
ead of custom registration functions. Change from v2: - create transaction latency module to monitor slow transaction. Change from v1: - first patchset. Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction late

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:02:44AM +0800, Frankie Chang wrote: > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold > (default 2 sec), if yes, printing

Re: [PATCH v13] binder: add transaction latency tracer

2020-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:02:41AM +0800, Frankie Chang wrote: > > Frankie.Chang (3): > binder: move structs from core file to header file > binder: add trace at free transaction. > binder: add transaction latency tracer > > drivers/android/Kconfig

[PATCH v13] binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig | 8 + drivers/android/Makefile| 1 + drivers/android/binder.c

[PATCH v12] binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
ead of custom registration functions. Change from v2: - create transaction latency module to monitor slow transaction. Change from v1: - first patchset. Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transact

Re: binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
On Tue, 2020-11-10 at 08:53 +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2020 at 08:52:09AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 10, 2020 at 03:33:00PM +0800, Frankie Chang wrote: > > > On Mon, 2020-11-09 at 18:46 +0100, Greg Kroah-Hartman wrote: > > > > On Fri, Oct 30, 2020 at

Re: binder: add transaction latency tracer

2020-11-09 Thread Greg Kroah-Hartman
On Tue, Nov 10, 2020 at 08:52:09AM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2020 at 03:33:00PM +0800, Frankie Chang wrote: > > On Mon, 2020-11-09 at 18:46 +0100, Greg Kroah-Hartman wrote: > > > On Fri, Oct 30, 2020 at 12:08:54AM +0800, Frankie Chang wrote: > > > > Change from v11: > > >

Re: binder: add transaction latency tracer

2020-11-09 Thread Greg Kroah-Hartman
On Tue, Nov 10, 2020 at 03:33:00PM +0800, Frankie Chang wrote: > On Mon, 2020-11-09 at 18:46 +0100, Greg Kroah-Hartman wrote: > > On Fri, Oct 30, 2020 at 12:08:54AM +0800, Frankie Chang wrote: > > > Change from v11: > > > - rebase. > > > > This whole patch set is sent with DOS line-ends, which

Re: binder: add transaction latency tracer

2020-11-09 Thread Frankie Chang
On Mon, 2020-11-09 at 18:46 +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 30, 2020 at 12:08:54AM +0800, Frankie Chang wrote: > > Change from v11: > > - rebase. > > This whole patch set is sent with DOS line-ends, which makes git really > unhappy when it tries to apply it, as rightfully, it

Re: binder: add transaction latency tracer

2020-11-09 Thread Greg Kroah-Hartman
On Fri, Oct 30, 2020 at 12:08:54AM +0800, Frankie Chang wrote: > Change from v11: > - rebase. This whole patch set is sent with DOS line-ends, which makes git really unhappy when it tries to apply it, as rightfully, it doesn't know how to convert things. Please resend this patch series as a

binder: add transaction latency tracer

2020-10-29 Thread Frankie Chang
ion functions. Change from v2: - create transaction latency module to monitor slow transaction. Change from v1: - first patchset. Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/andr

[PATCH v10 3/3] binder: add transaction latency tracer

2020-10-15 Thread Frankie Chang
v2: - create transaction latency module to monitor slow transaction. Change from v1: - first patchset. Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig |

Re: [PATCH v9 3/3] binder: add transaction latency tracer

2020-09-16 Thread Greg Kroah-Hartman
On Tue, Sep 08, 2020 at 10:06:48PM +0800, Frankie Chang wrote: > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > +#include > +#include > +#endif > + > struct binder_context { > struct binder_node *binder_context_mgr_node; > struct mutex context_mgr_node_lock; > @@

Re: [PATCH v8 3/3] binder: add transaction latency tracer

2020-09-07 Thread Frankie Chang
On Mon, 2020-09-07 at 16:09 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 09:51:15PM +0800, Frankie Chang wrote: > > On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > > > From: "Frankie.Chang" > > > >

Re: [PATCH v8 3/3] binder: add transaction latency tracer

2020-09-07 Thread Frankie Chang
On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction is free, > > it would be checked if

Re: [PATCH v7 3/3] binder: add transaction latency tracer

2020-09-07 Thread peter enderborg
On 8/4/20 3:59 PM, Frankie Chang wrote: > +void probe_binder_txn_latency_free(void *ignore, struct binder_transaction > *t, > + int from_proc, int from_thread, > + int to_proc, int to_thread) > +{ > + struct rtc_time tm;

Re: [PATCH v8 3/3] binder: add transaction latency tracer

2020-09-07 Thread Greg Kroah-Hartman
On Mon, Sep 07, 2020 at 09:51:15PM +0800, Frankie Chang wrote: > On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > > From: "Frankie.Chang" > > > > > > Record start/end timestamp for binder transaction. > > > When

Re: [PATCH v8 3/3] binder: add transaction latency tracer

2020-09-07 Thread Greg Kroah-Hartman
On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold > (default 2 sec), if yes, printing

Re: [PATCH v7 3/3] binder: add transaction latency tracer

2020-08-04 Thread Todd Kjos
On Tue, Aug 4, 2020 at 6:59 AM Frankie Chang wrote: > > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold > (default 2 sec), if yes, printing related

[PATCH v7 3/3] binder: add transaction latency tracer

2020-08-04 Thread Frankie Chang
From: "Frankie.Chang" Record start/end timestamp for binder transaction. When transaction is completed or transaction is free, it would be checked if transaction latency over threshold (default 2 sec), if yes, printing related information for tracing. /* Implement details */ - Add latency

[PATCH v6 3/3] binder: add transaction latency tracer

2020-07-27 Thread Frankie Chang
From: "Frankie.Chang" Record start/end timestamp for binder transaction. When transaction is completed or transaction is free, it would be checked if transaction latency over threshold (default 2 sec), if yes, printing related information for tracing. /* Implement details */ - Add latency

Re: [PATCH v5 3/3] binder: add transaction latency tracer

2020-07-22 Thread Frankie Chang
On Mon, 2020-07-20 at 11:56 -0700, Todd Kjos wrote: > On Wed, Jun 10, 2020 at 5:34 AM Frankie Chang > wrote: > > > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction is free, > > it would be checked if transaction

Re: [PATCH v5 3/3] binder: add transaction latency tracer

2020-07-20 Thread Todd Kjos
On Wed, Jun 10, 2020 at 5:34 AM Frankie Chang wrote: > > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold (2 sec), > if yes, printing related

Re: [PATCH v4 3/3] binder: add transaction latency tracer

2020-05-11 Thread Frankie Chang
On Thu, 2020-05-07 at 11:21 -0700, Todd Kjos wrote: > On Thu, May 7, 2020 at 1:11 AM Frankie Chang > wrote: > > > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction is free, > > it would be checked if transaction

Re: [PATCH v4 3/3] binder: add transaction latency tracer

2020-05-11 Thread Frankie Chang
On Thu, 2020-05-07 at 10:55 +0200, Greg Kroah-Hartman wrote: > On Thu, May 07, 2020 at 04:10:55PM +0800, Frankie Chang wrote: > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction is free, > > it would be checked if

Re: [PATCH v4 3/3] binder: add transaction latency tracer

2020-05-07 Thread Todd Kjos
On Thu, May 7, 2020 at 1:11 AM Frankie Chang wrote: > > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold (2 sec), If this is a hard-coded threshold,

Re: [PATCH v4 3/3] binder: add transaction latency tracer

2020-05-07 Thread Greg Kroah-Hartman
On Thu, May 07, 2020 at 04:10:55PM +0800, Frankie Chang wrote: > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold (2 sec), > if yes, printing related