Re: bio refcount problem

2005-02-18 Thread Jens Axboe
On Fri, Feb 18 2005, Philip R Auld wrote: > Hi, > > Rumor has it that on Fri, Feb 18, 2005 at 02:59:32PM +0100 Jens Axboe said: > > On Fri, Feb 18 2005, Philip R Auld wrote: > > ... > > > Or make all users of submit_bio take and release and extra reference > > > like submit_bh. > > > > The queue

Re: bio refcount problem

2005-02-18 Thread Philip R Auld
Hi, Rumor has it that on Fri, Feb 18, 2005 at 02:59:32PM +0100 Jens Axboe said: > On Fri, Feb 18 2005, Philip R Auld wrote: ... > > Or make all users of submit_bio take and release and extra reference > > like submit_bh. > > The queue lock is still held at that point, so the driver hasn't had a

Re: bio refcount problem

2005-02-18 Thread Jens Axboe
On Fri, Feb 18 2005, Philip R Auld wrote: > Hi, > I think there are some potential issues with the reference > counting of bios as used in 2.6.10. The __make_request function > which is the default block device routine accesses the bio structure > after issuing the call to add_request. This

bio refcount problem

2005-02-18 Thread Philip R Auld
Hi, I think there are some potential issues with the reference counting of bios as used in 2.6.10. The __make_request function which is the default block device routine accesses the bio structure after issuing the call to add_request. This means that the bio could have completed before _