Re: clk/Renesas-MSTP: Rename jump labels in cpg_mstp_attach_dev()

2016-09-15 Thread SF Markus Elfring
> "Choose label names which say what the goto does or why the goto exists." > > I prefer the "why" over the "what". Does your opinion indicate also that you would appreciate another adjustment around the quoted sentence from "Chapter 7: Centralized exiting of functions" of the document "CodingSty

Re: [PATCH 4/4] clk/Renesas-MSTP: Rename jump labels in cpg_mstp_attach_dev()

2016-09-15 Thread Geert Uytterhoeven
Hi Markus, On Wed, Sep 14, 2016 at 10:04 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 14 Sep 2016 21:41:50 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/clk/renesas/clk-mstp.c | 16

[PATCH 4/4] clk/Renesas-MSTP: Rename jump labels in cpg_mstp_attach_dev()

2016-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 14 Sep 2016 21:41:50 +0200 Adjust jump labels according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/clk/renesas/clk-mstp.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/cl