Re: commit 94fc5d9: chromium-sandbox core dumped

2013-08-20 Thread Emmanuel Benisty
Hi Linus, On Tue, Aug 20, 2013 at 1:26 AM, Linus Torvalds wrote: > On Mon, Aug 19, 2013 at 1:25 PM, Linus Torvalds > wrote: >> >> I suspect that last "return 0" at the end should be "return 1". Does >> that fix things for you? Untested. > > Ok. Confirmed. I reproduced the bug that Richard

Re: commit 94fc5d9: chromium-sandbox core dumped

2013-08-20 Thread Emmanuel Benisty
Hi Linus, On Tue, Aug 20, 2013 at 1:26 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Aug 19, 2013 at 1:25 PM, Linus Torvalds torva...@linux-foundation.org wrote: I suspect that last return 0 at the end should be return 1. Does that fix things for you? Untested. Ok.

Re: commit 94fc5d9: chromium-sandbox core dumped

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 1:25 PM, Linus Torvalds wrote: > > I suspect that last "return 0" at the end should be "return 1". Does > that fix things for you? Untested. Ok. Confirmed. I reproduced the bug that Richard Genoud fixed, and also verified that yes, changing that last "return 0" in

Re: commit 94fc5d9: chromium-sandbox core dumped

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 11:48 AM, Emmanuel Benisty wrote: > > The following commit breaks chromium on my machine ("proc: > return on proc_readdir error") > > Chromium breaks with: > > [269:269:0819/203839:FATAL:zygote_host_impl_linux.cc(195)] Check > failed: pid_0. Did not find zygote process

commit 94fc5d9: chromium-sandbox core dumped

2013-08-19 Thread Emmanuel Benisty
Hi, The following commit breaks chromium on my machine: commit 94fc5d9de5bd757ad46f0d94bc4ebf617c4487f6 Author: Richard Genoud Date: Mon Aug 19 18:30:31 2013 +0200 proc: return on proc_readdir error Chromium breaks with: [269:269:0819/203839:FATAL:zygote_host_impl_linux.cc(195)] Check

commit 94fc5d9: chromium-sandbox core dumped

2013-08-19 Thread Emmanuel Benisty
Hi, The following commit breaks chromium on my machine: commit 94fc5d9de5bd757ad46f0d94bc4ebf617c4487f6 Author: Richard Genoud richard.gen...@gmail.com Date: Mon Aug 19 18:30:31 2013 +0200 proc: return on proc_readdir error Chromium breaks with:

Re: commit 94fc5d9: chromium-sandbox core dumped

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 11:48 AM, Emmanuel Benisty benist...@gmail.com wrote: The following commit breaks chromium on my machine (proc: return on proc_readdir error) Chromium breaks with: [269:269:0819/203839:FATAL:zygote_host_impl_linux.cc(195)] Check failed: pid_0. Did not find zygote

Re: commit 94fc5d9: chromium-sandbox core dumped

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 1:25 PM, Linus Torvalds torva...@linux-foundation.org wrote: I suspect that last return 0 at the end should be return 1. Does that fix things for you? Untested. Ok. Confirmed. I reproduced the bug that Richard Genoud fixed, and also verified that yes, changing that last