Re: crypto/async_tx/* doesn't build on s390

2008-02-04 Thread Cornelia Huck
On Sun, 3 Feb 2008 07:10:50 -0700, "Dan Williams" <[EMAIL PROTECTED]> wrote: > On Feb 3, 2008 4:40 AM, Heiko Carstens <[EMAIL PROTECTED]> wrote: > > On Fri, Feb 01, 2008 at 02:31:28PM -0700, Dan Williams wrote: > [..] > > The fix works for me. Thanks! However your mailer replaced tabs with spaces

Re: crypto/async_tx/* doesn't build on s390

2008-02-03 Thread Dan Williams
On Feb 3, 2008 4:40 AM, Heiko Carstens <[EMAIL PROTECTED]> wrote: > On Fri, Feb 01, 2008 at 02:31:28PM -0700, Dan Williams wrote: [..] > The fix works for me. Thanks! However your mailer replaced tabs with spaces > and added an extra line break. > The attached patch is slightly cleaner, and still

Re: crypto/async_tx/* doesn't build on s390

2008-02-03 Thread Heiko Carstens
On Fri, Feb 01, 2008 at 02:31:28PM -0700, Dan Williams wrote: > On Feb 1, 2008 4:37 AM, Cornelia Huck <[EMAIL PROTECTED]> wrote: > > On Thu, 31 Jan 2008 12:49:00 -0700, > > "Williams, Dan J" <[EMAIL PROTECTED]> wrote: > > > > > I am mistaken, the 'depends on ARCH...' precludes HAS_DMA. Perhaps the

Re: crypto/async_tx/* doesn't build on s390

2008-02-01 Thread Dan Williams
On Feb 1, 2008 4:37 AM, Cornelia Huck <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008 12:49:00 -0700, > "Williams, Dan J" <[EMAIL PROTECTED]> wrote: > > > I am mistaken, the 'depends on ARCH...' precludes HAS_DMA. Perhaps the > > compiler is emitting a call to async_tx_find_channel when it needs

Re: crypto/async_tx/* doesn't build on s390

2008-02-01 Thread Cornelia Huck
On Thu, 31 Jan 2008 12:49:00 -0700, "Williams, Dan J" <[EMAIL PROTECTED]> wrote: > I am mistaken, the 'depends on ARCH...' precludes HAS_DMA. Perhaps the > compiler is emitting a call to async_tx_find_channel when it needs to be > inline? On x86 do_async_xor is successfully compiled away when

Re: crypto/async_tx/* doesn't build on s390

2008-01-31 Thread Cornelia Huck
On Thu, 31 Jan 2008 15:50:58 +0100, Heiko Carstens <[EMAIL PROTECTED]> wrote: > I get the following: > > crypto/built-in.o: In function `do_async_xor': > async_xor.c:49: undefined reference to `dma_map_page' > async_xor.c:56: undefined reference to `dma_map_page' > > This is mainly because s390

crypto/async_tx/* doesn't build on s390

2008-01-31 Thread Heiko Carstens
I get the following: crypto/built-in.o: In function `do_async_xor': async_xor.c:49: undefined reference to `dma_map_page' async_xor.c:56: undefined reference to `dma_map_page' This is mainly because s390 doesn't support DMA at all, but these files get selected via MD_RAID456 anyway. Any idea how