Re: crypto: Kernel memory overwrite attempt detected to spans multiple pages

2019-04-11 Thread Kees Cook
On Thu, Apr 11, 2019 at 12:26 PM Eric Biggers wrote: > Well, I guess I'll just add __GFP_COMP so I at least don't get spammed with > useless bug reports. Thanks, I appreciate it. > But I don't think it's in any way acceptable to change the semantics of the > kernel's page allocator but only

Re: crypto: Kernel memory overwrite attempt detected to spans multiple pages

2019-04-10 Thread Rik van Riel
On Wed, 2019-04-10 at 16:11 -0700, Eric Biggers wrote: > You've explained *what* it does again, but not *why*. *Why* do you > want > hardened usercopy to detect copies across page boundaries, when there > is no > actual buffer overflow? When some subsystem in the kernel allocates multiple pages

Re: crypto: Kernel memory overwrite attempt detected to spans multiple pages

2019-03-21 Thread Kees Cook
On Wed, Mar 20, 2019 at 11:57 AM Eric Biggers wrote: > > On Tue, Mar 19, 2019 at 10:09:13AM -0700, Eric Biggers wrote: > > On Tue, Mar 19, 2019 at 12:54:23PM +0100, Geert Uytterhoeven wrote: > > > When running the sha1-asm crypto selftest on arm with > > > CONFIG_HARDENED_USERCOPY_PAGESPAN=y: > >