[PATCH 3.10 003/319] crypto: algif_skcipher - Require setkey before accept(2)

From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so that the accept(2) call will fail with -ENOKEY if setkey hasn't been

[PATCH 3.10 003/319] crypto: algif_skcipher - Require setkey before accept(2)

From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so that the accept(2) call will fail with -ENOKEY if setkey hasn't been done on the socket yet. Cc:

[PATCH 3.19.y-ckt 001/170] crypto: algif_skcipher - Require setkey before accept(2)

3.19.8-ckt18 -stable review patch. If anyone has any objections, please let me know. ---8< From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will

[PATCH 3.19.y-ckt 001/170] crypto: algif_skcipher - Require setkey before accept(2)

3.19.8-ckt18 -stable review patch. If anyone has any objections, please let me know. ---8< From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them

[PATCH 3.16.y-ckt 044/129] crypto: algif_skcipher - Require setkey before accept(2)

3.16.7-ckt25 -stable review patch. If anyone has any objections, please let me know. ---8< From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will

[PATCH 3.16.y-ckt 044/129] crypto: algif_skcipher - Require setkey before accept(2)

3.16.7-ckt25 -stable review patch. If anyone has any objections, please let me know. ---8< From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them

[PATCH 3.12 059/142] crypto: algif_skcipher - Require setkey before accept(2)

From: Herbert Xu 3.12-stable review patch. If anyone has any objections, please let me know. === commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first.

[PATCH 3.12 059/142] crypto: algif_skcipher - Require setkey before accept(2)

From: Herbert Xu 3.12-stable review patch. If anyone has any objections, please let me know. === commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so that

[PATCH 4.3 157/200] crypto: algif_skcipher - Require setkey before accept(2)

4.3-stable review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first.

[PATCH 4.3 157/200] crypto: algif_skcipher - Require setkey before accept(2)

4.3-stable review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so

[PATCH 4.4 080/117] crypto: algif_skcipher - Require setkey before accept(2)

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so

[PATCH 4.4 080/117] crypto: algif_skcipher - Require setkey before accept(2)

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first.

[PATCH 3.2 68/87] crypto: algif_skcipher - Require setkey before accept(2)

3.2.77-rc1 review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so

[PATCH 3.2 68/87] crypto: algif_skcipher - Require setkey before accept(2)

3.2.77-rc1 review patch. If anyone has any objections, please let me know. -- From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first.

[PATCH 4.2.y-ckt 148/268] crypto: algif_skcipher - Require setkey before accept(2)

4.2.8-ckt3 -stable review patch. If anyone has any objections, please let me know. ---8< From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them

[PATCH 4.2.y-ckt 148/268] crypto: algif_skcipher - Require setkey before accept(2)

4.2.8-ckt3 -stable review patch. If anyone has any objections, please let me know. ---8< From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/03/2016 02:31 AM, Herbert Xu wrote: > On Sat, Jan 02, 2016 at 09:18:30PM +0100, Milan Broz wrote: >> >> But I cannot change thousands of cryptsetup installations that are actively >> using that code. >> This is clear userspace breakage which should not happen this way. > > I'll try to add

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/03/2016 02:31 AM, Herbert Xu wrote: > On Sat, Jan 02, 2016 at 09:18:30PM +0100, Milan Broz wrote: >> >> But I cannot change thousands of cryptsetup installations that are actively >> using that code. >> This is clear userspace breakage which should not happen this way. > > I'll try to add

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On Sat, Jan 02, 2016 at 09:18:30PM +0100, Milan Broz wrote: > > But I cannot change thousands of cryptsetup installations that are actively > using that code. > This is clear userspace breakage which should not happen this way. I'll try to add some compatibility code for your case, assuming your

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/02/2016 09:03 PM, Stephan Mueller wrote: > Am Samstag, 2. Januar 2016, 15:41:34 schrieb Milan Broz: > > Hi Milan, > ... >>> Hi Herbert, >>> >>> this patch breaks userspace in cryptsetup... >>> >>> We use algif_skcipher in cryptsetup (for years, even before >>> there was Stephan's library)

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

- Use new skcipher interface > >>> crypto: algif_skcipher - Require setkey before accept(2) > >>> on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). > >> > >> You sent the email to everyone on the original CC list except me. > >>

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/02/2016 12:52 PM, Milan Broz wrote: > On 12/25/2015 08:40 AM, Herbert Xu wrote: >> Dmitry Vyukov wrote: >>> >>> I am testing with your two patches: >>> crypto: algif_skcipher - Use new skcipher interface >>> crypto: algif_skcipher

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 12/25/2015 08:40 AM, Herbert Xu wrote: > Dmitry Vyukov wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Require setkey before accept(2) >> on top of a88164345b81292b55a8d4829f

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/02/2016 12:52 PM, Milan Broz wrote: > On 12/25/2015 08:40 AM, Herbert Xu wrote: >> Dmitry Vyukov <dvyu...@google.com> wrote: >>> >>> I am testing with your two patches: >>> crypto: algif_skcipher - Use new skcipher interface >>> cryp

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 12/25/2015 08:40 AM, Herbert Xu wrote: > Dmitry Vyukov <dvyu...@google.com> wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Require setkey before accept(2) >> on top of a

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/02/2016 09:03 PM, Stephan Mueller wrote: > Am Samstag, 2. Januar 2016, 15:41:34 schrieb Milan Broz: > > Hi Milan, > ... >>> Hi Herbert, >>> >>> this patch breaks userspace in cryptsetup... >>> >>> We use algif_skcipher in cryptsetup (for years, even before >>> there was Stephan's library)

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

t;> crypto: algif_skcipher - Use new skcipher interface > >>> crypto: algif_skcipher - Require setkey before accept(2) > >>> on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). > >> > >> You sent the email to everyone on the original CC list

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On Sat, Jan 02, 2016 at 09:18:30PM +0100, Milan Broz wrote: > > But I cannot change thousands of cryptsetup installations that are actively > using that code. > This is clear userspace breakage which should not happen this way. I'll try to add some compatibility code for your case, assuming your

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

Dmitry Vyukov wrote: > > My email client just followed instructions in your email. You've said > to Reply-to: syzkal...@googlegroups.com. I did not set this Reply-To header. It's most likely set by your broken Google Groups setup. So either you should start actually replying to my email

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

Dmitry Vyukov wrote: > > My email client just followed instructions in your email. You've said > to Reply-to: syzkal...@googlegroups.com. I did not set this Reply-To header. It's most likely set by your broken Google Groups setup. So either you should start actually

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On Fri, Dec 25, 2015 at 8:40 AM, Herbert Xu wrote: > Dmitry Vyukov wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Require setkey before accept(2) >> on top of a88164345b81292

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On Fri, Dec 25, 2015 at 8:40 AM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > Dmitry Vyukov <dvyu...@google.com> wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Re

Re: crypto: algif_skcipher - Require setkey before accept(2)

On Fri, 25 Dec 2015, Herbert Xu wrote: > On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote: > > Lines 766, 767 don't look correct at all. > > Thanks Julia. I have sent an updated patch in the original thread. > I wonder why I haven't received the original kbuild test robot > email

Re: crypto: algif_skcipher - Require setkey before accept(2)

On Fri, 25 Dec 2015, Herbert Xu wrote: > On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote: > > Lines 766, 767 don't look correct at all. > > Thanks Julia. I have sent an updated patch in the original thread. > I wonder why I haven't received the original kbuild test robot > email

Re: crypto: algif_skcipher - Require setkey before accept(2)

On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote: > Lines 766, 767 don't look correct at all. Thanks Julia. I have sent an updated patch in the original thread. I wonder why I haven't received the original kbuild test robot email though. Cheers, -- Email: Herbert Xu Home Page:

[PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

Dmitry Vyukov wrote: > > I am testing with your two patches: > crypto: algif_skcipher - Use new skcipher interface > crypto: algif_skcipher - Require setkey before accept(2) > on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). You sent the email to everyone on the o

Re: crypto: algif_skcipher - Require setkey before accept(2)

ert, > > [auto build test WARNING on crypto/master] > [also build test WARNING on next-20151223] > [cannot apply to v4.4-rc6] > > url: > https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-algif_skcipher-Require-setkey-before-accept-2/20151224-174142 > base: >

[PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

Dmitry Vyukov <dvyu...@google.com> wrote: > > I am testing with your two patches: > crypto: algif_skcipher - Use new skcipher interface > crypto: algif_skcipher - Require setkey before accept(2) > on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). You sent

Re: crypto: algif_skcipher - Require setkey before accept(2)

On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote: > Lines 766, 767 don't look correct at all. Thanks Julia. I have sent an updated patch in the original thread. I wonder why I haven't received the original kbuild test robot email though. Cheers, -- Email: Herbert Xu

Re: crypto: algif_skcipher - Require setkey before accept(2)

ert, > > [auto build test WARNING on crypto/master] > [also build test WARNING on next-20151223] > [cannot apply to v4.4-rc6] > > url: > https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-algif_skcipher-Require-setkey-before-accept-2/20151224-174142 > base: >