>
> > > static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr
> > > *in_nlh,
> > >
> > >struct nlattr **attrs)
> > >
> > > {
> > > ...
> > >
> > > if (!p->cru_driver_name[0])
&
Am Freitag, 21. November 2014, 10:31:31 schrieb Herbert Xu:
Hi Herbert,
> On Thu, Nov 20, 2014 at 05:08:42PM +0100, Stephan Mueller wrote:
> > Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:
> >
> > Hi Herbert,
> >
> > > On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller
On Thu, Nov 20, 2014 at 05:08:42PM +0100, Stephan Mueller wrote:
> Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:
>
> Hi Herbert,
>
> > On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
> > > What about the following
> > >
> > > if (p->cru_driver_name[0]
>
> If
Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:
Hi Herbert,
> On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
> > What about the following
> >
> > if (p->cru_driver_name[0]
If the driver name is not empty
> >
> > alg = crypto_alg_match(p, 1);
Do an exact
On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
>
> What about the following
>
> if (p->cru_driver_name[0]
> alg = crypto_alg_match(p, 1);
> else
> alg = crypto_alg_match(p, 0);
If cru_driver_name is not empty then exact will never be used, no?
Cheers,
--
Email:
>
> > > static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr
> > > *in_nlh,
> > >
> > >struct nlattr **attrs)
> > >
> > > {
> > > ...
> > >
> > > if (!p->cru_driver_name[0])
&
Am Donnerstag, 20. November 2014, 09:04:06 schrieb Steffen Klassert:
Hi Steffen,
> On Thu, Nov 20, 2014 at 03:45:26PM +0800, Herbert Xu wrote:
> > On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote:
> > > I think this is not sufficient, crypto_alg_match() will now return the
> > >
struct nlattr **attrs)
> >
> > {
> > ...
> >
> > if (!p->cru_driver_name[0])
> >
> > return -EINVAL;
>
> OK let's fix this.
>
> crypto: user - Allow get request with empty driver name
>
> Currentl
On Thu, Nov 20, 2014 at 03:45:26PM +0800, Herbert Xu wrote:
> On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote:
> >
> > I think this is not sufficient, crypto_alg_match() will now return the first
> > algorithm in crypto_alg_list that matches cra_name. We would need to extend
> >
On Thu, Nov 20, 2014 at 03:45:26PM +0800, Herbert Xu wrote:
On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote:
I think this is not sufficient, crypto_alg_match() will now return the first
algorithm in crypto_alg_list that matches cra_name. We would need to extend
)
{
...
if (!p-cru_driver_name[0])
return -EINVAL;
OK let's fix this.
crypto: user - Allow get request with empty driver name
Currently all get requests with an empty driver name fail with
EINVAL. Since most users actually want to supply an empty driver
name
Am Donnerstag, 20. November 2014, 09:04:06 schrieb Steffen Klassert:
Hi Steffen,
On Thu, Nov 20, 2014 at 03:45:26PM +0800, Herbert Xu wrote:
On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote:
I think this is not sufficient, crypto_alg_match() will now return the
first
*in_skb, struct nlmsghdr
*in_nlh,
struct nlattr **attrs)
{
...
if (!p-cru_driver_name[0])
return -EINVAL;
OK let's fix this.
crypto: user - Allow get request with empty driver name
Currently all get requests
On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
What about the following
if (p-cru_driver_name[0]
alg = crypto_alg_match(p, 1);
else
alg = crypto_alg_match(p, 0);
If cru_driver_name is not empty then exact will never be used, no?
Cheers,
--
Email: Herbert Xu
Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:
Hi Herbert,
On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
What about the following
if (p-cru_driver_name[0]
If the driver name is not empty
alg = crypto_alg_match(p, 1);
Do an exact match using
On Thu, Nov 20, 2014 at 05:08:42PM +0100, Stephan Mueller wrote:
Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:
Hi Herbert,
On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
What about the following
if (p-cru_driver_name[0]
If the driver name is
Am Freitag, 21. November 2014, 10:31:31 schrieb Herbert Xu:
Hi Herbert,
On Thu, Nov 20, 2014 at 05:08:42PM +0100, Stephan Mueller wrote:
Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu:
Hi Herbert,
On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote:
*in_skb, struct nlmsghdr
*in_nlh,
struct nlattr **attrs)
{
...
if (!p-cru_driver_name[0])
return -EINVAL;
OK let's fix this.
crypto: user - Allow get request with empty driver name
Currently all get requests
On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote:
>
> I think this is not sufficient, crypto_alg_match() will now return the first
> algorithm in crypto_alg_list that matches cra_name. We would need to extend
> crypto_alg_match() to return the algorithm with the highest priority in
struct nlattr **attrs)
> > {
> > ...
> > if (!p->cru_driver_name[0])
> > return -EINVAL;
>
> OK let's fix this.
>
> crypto: user - Allow get request with empty driver name
>
> Currently all get requests with an empty driver name fail w
return -EINVAL;
OK let's fix this.
crypto: user - Allow get request with empty driver name
Currently all get requests with an empty driver name fail with
EINVAL. Since most users actually want to supply an empty driver
name this patch removes this check.
Signed-off-by: He
this.
crypto: user - Allow get request with empty driver name
Currently all get requests with an empty driver name fail with
EINVAL. Since most users actually want to supply an empty driver
name this patch removes this check.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
diff --git
-cru_driver_name[0])
return -EINVAL;
OK let's fix this.
crypto: user - Allow get request with empty driver name
Currently all get requests with an empty driver name fail with
EINVAL. Since most users actually want to supply an empty driver
name this patch removes
On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote:
I think this is not sufficient, crypto_alg_match() will now return the first
algorithm in crypto_alg_list that matches cra_name. We would need to extend
crypto_alg_match() to return the algorithm with the highest priority in
24 matches
Mail list logo
