Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 3:25 PM, David Howells wrote: > > This function has a list of requisite parameters for the caller: .. and so what? When you call "free()", that has a requisite parameter: the data to free. If you don't supply it, we should BUG_ON(), right? No.

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 3:25 PM, David Howells wrote: > > This function has a list of requisite parameters for the caller: .. and so what? When you call "free()", that has a requisite parameter: the data to free. If you don't supply it, we should BUG_ON(), right? No. Instead we do the sane

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 3:25 PM, David Howells wrote: > Linus Torvalds wrote: > >> I'm not seeing why it would ever be ok to do BUG_ON() instead of just >> returning an error, though. > > This function has a list of requisite parameters for the

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 3:25 PM, David Howells wrote: > Linus Torvalds wrote: > >> I'm not seeing why it would ever be ok to do BUG_ON() instead of just >> returning an error, though. > > This function has a list of requisite parameters for the caller: > > BUG_ON(!pkey); <-- You

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread David Howells
Linus Torvalds wrote: > I'm not seeing why it would ever be ok to do BUG_ON() instead of just > returning an error, though. This function has a list of requisite parameters for the caller: BUG_ON(!pkey); <-- You need the public key to use,

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread David Howells
Linus Torvalds wrote: > I'm not seeing why it would ever be ok to do BUG_ON() instead of just > returning an error, though. This function has a list of requisite parameters for the caller: BUG_ON(!pkey); <-- You need the public key to use, BUG_ON(!sig);

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Johannes Berg
On Mon, 2017-11-27 at 21:46 +, Linus Torvalds wrote: > On Sat, Nov 25, 2017 at 7:07 PM, Fengguang Wu wrote: > > FYI, we noticed the following commit (built with gcc-4.8): > > > > commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize > > regulatory

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Johannes Berg
On Mon, 2017-11-27 at 21:46 +, Linus Torvalds wrote: > On Sat, Nov 25, 2017 at 7:07 PM, Fengguang Wu wrote: > > FYI, we noticed the following commit (built with gcc-4.8): > > > > commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize > > regulatory keys/database later") >

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 7:07 PM, Fengguang Wu wrote: > FYI, we noticed the following commit (built with gcc-4.8): > > commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize > regulatory keys/database later") The attached 'dmesg.xz' doesn't actually match

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 7:07 PM, Fengguang Wu wrote: > FYI, we noticed the following commit (built with gcc-4.8): > > commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize > regulatory keys/database later") The attached 'dmesg.xz' doesn't actually match the kernel or the

d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-25 Thread Fengguang Wu
FYI, we noticed the following commit (built with gcc-4.8): commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize regulatory keys/database later") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: boot on test machine: qemu-system-x86_64

d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-25 Thread Fengguang Wu
FYI, we noticed the following commit (built with gcc-4.8): commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize regulatory keys/database later") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: boot on test machine: qemu-system-x86_64