Re: drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR'

2021-03-03 Thread Manivannan Sadhasivam
On Wed, Mar 03, 2021 at 09:48:40AM +0100, Miquel Raynal wrote: > Hello, > [...] > > PTR_ERR(NULL) is success. But let's just fix the IS_ERR_OR_NULL() check > > to IS_ERR() so we don't have to wonder if returning success is > > intentional. > > Thanks for the report, I've just sent the fix. >

Re: drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR'

2021-03-03 Thread Dan Carpenter
On Wed, Mar 03, 2021 at 09:48:40AM +0100, Miquel Raynal wrote: > > @Manni, I thought you would be added in Cc automatically as you're the > author of the fixed commit, but I was wrong, sorry for the mistake. That's very weird... get_maintainer.pl does look up the fixes tag and adds the commit

Re: drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR'

2021-03-03 Thread Miquel Raynal
EM > parser > config: nds32-randconfig-m031-20210302 (attached as .config) > compiler: nds32le-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: &

drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR'

2021-03-03 Thread Dan Carpenter
-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +109 drivers/mtd/parsers