> Oh so it's another troll then?
I am just a contributor.
> Good to know, ignoring from now on.
The opinions can vary for my contributions as usual.
I hope that the software development attention can evolve in more
positive ways again.
Regards,
Markus
> Why are you all arguing with a all-but-instinguishable-from-a-bot persona
I am curious if another meeting at a Linux conference
can adjust this view.
> about a patch that I will never apply?
I hope that you can get into a more constructive mood a bit later
for the reconsideration of the
wt., 25 cze 2019 o 09:30 Greg Kroah-Hartman
napisał(a):
>
> On Tue, Jun 25, 2019 at 09:10:25AM +0200, Bartosz Golaszewski wrote:
> > pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult
> > napisał(a):
> > >
> > > On 24.06.19 12:46, Bartosz Golaszewski wrote:
> > >
> > > >> The patch seems
On Tue, Jun 25, 2019 at 09:10:25AM +0200, Bartosz Golaszewski wrote:
> pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult
> napisał(a):
> >
> > On 24.06.19 12:46, Bartosz Golaszewski wrote:
> >
> > >> The patch seems pretty trivial and doesn't change any actual code, so
> > >> I don't see
pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult
napisał(a):
>
> On 24.06.19 12:46, Bartosz Golaszewski wrote:
>
> >> The patch seems pretty trivial and doesn't change any actual code, so
> >> I don't see hard resons for rejecting it.
> >>
> >
> > In its current form it makes the code
On 24.06.19 12:46, Bartosz Golaszewski wrote:
>> The patch seems pretty trivial and doesn't change any actual code, so
>> I don't see hard resons for rejecting it.
>>
>
> In its current form it makes the code even less readable. The #ifdef
> should actually be one line lower and touch the
> In its current form it makes the code even less readable.
This can be your development opinion.
> The #ifdef should actually be one line lower
I suggested that the conditional compilation can contain also a blank line
together with a comment block.
> and touch the comment instead of the
>> +++ b/drivers/base/platform.c
>> @@ -78,6 +78,7 @@ struct resource *platform_get_resource(struct
>> platform_device *dev,
>> return NULL;
>> }
>> EXPORT_SYMBOL_GPL(platform_get_resource);
>> +#ifdef CONFIG_HAS_IOMEM
>>
>> /**
>> * devm_platform_ioremap_resource - call
pon., 24 cze 2019 o 12:05 Enrico Weigelt, metux IT consult
napisał(a):
>
> On 24.06.19 10:29, Bartosz Golaszewski wrote:
> > pt., 14 cze 2019 o 18:50 Markus Elfring napisał(a):
> >>
> >> From: Markus Elfring
> >> Date: Fri, 14 Jun 2019 17:45:13 +0200
> >>
> >> Move the preprocessor statement
On 24.06.19 10:29, Bartosz Golaszewski wrote:
> pt., 14 cze 2019 o 18:50 Markus Elfring napisał(a):
>>
>> From: Markus Elfring
>> Date: Fri, 14 Jun 2019 17:45:13 +0200
>>
>> Move the preprocessor statement “#ifdef CONFIG_HAS_IOMEM” so that
>> the corresponding scope for conditional compilation
pt., 14 cze 2019 o 18:50 Markus Elfring napisał(a):
>
> From: Markus Elfring
> Date: Fri, 14 Jun 2019 17:45:13 +0200
>
> Move the preprocessor statement “#ifdef CONFIG_HAS_IOMEM” so that
> the corresponding scope for conditional compilation includes also comments
> for this function
From: Markus Elfring
Date: Fri, 14 Jun 2019 17:45:13 +0200
Move the preprocessor statement “#ifdef CONFIG_HAS_IOMEM” so that
the corresponding scope for conditional compilation includes also comments
for this function implementation.
Signed-off-by: Markus Elfring
---
drivers/base/platform.c |
12 matches
Mail list logo
