On Wed, Jul 31, 2019 at 10:01 PM Hongwei Zhang wrote:
> Add bindings to support SGPIO on AST2400 or AST2500.
>
> Signed-off-by: Hongwei Zhang
> Reviewed-by: Andrew Jeffery
OK timeout for further DT binding review. I adjusted a bunch
of things like whitespace and referencing other files when
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
Reviewed-by: Andrew Jeffery
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644
On Wed, 31 Jul 2019, at 00:55, Hongwei Zhang wrote:
> Add bindings to support SGPIO on AST2400 or AST2500.
>
> Signed-off-by: Hongwei Zhang
> ---
> .../devicetree/bindings/gpio/sgpio-aspeed.txt | 55
> ++
> 1 file changed, 55 insertions(+)
> create mode 100644
ux-aspeed; Bartosz Golaszewski; Rob
> Herring; Mark Rutland;
> linux-kernel@vger.kernel.org; Linux ARM
> Subject: Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support
>
> On Mon, Jul 29, 2019 at 2:19 AM Andrew Jeffery wrote:
>
> > The behaviour is to period
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
On Mon, Jul 29, 2019 at 2:19 AM Andrew Jeffery wrote:
> The behaviour is to periodically emit the state of all enabled GPIOs
> (i.e. the ngpios value), one per bus clock cycle. There's no explicit
> addressing scheme, the protocol encodes the value for a given GPIO
> by its position in the data
On Mon, 29 Jul 2019, at 09:04, Linus Walleij wrote:
> On Mon, Jul 22, 2019 at 3:42 AM Andrew Jeffery wrote:
>
> > If the clock driver owns the control register, it also needs to know how
> > many GPIOs we want to emit on the bus. This seems like an awkward
> > configuration parameter for a
On Mon, Jul 22, 2019 at 3:42 AM Andrew Jeffery wrote:
> If the clock driver owns the control register, it also needs to know how
> many GPIOs we want to emit on the bus. This seems like an awkward
> configuration parameter for a clock driver.
>
> To avoid the weird parameter we could protect the
On Sat, 20 Jul 2019, at 17:43, Linus Walleij wrote:
> Hi Hongwei,
>
> after looking close at the driver and bindings I have this feeback:
>
> On Fri, Jul 19, 2019 at 9:25 PM Hongwei Zhang wrote:
>
> +- reg : Address and length of the register set for the
> device
>
> This
Hi Hongwei,
after looking close at the driver and bindings I have this feeback:
On Fri, Jul 19, 2019 at 9:25 PM Hongwei Zhang wrote:
+- reg : Address and length of the register set for the device
This 0x100 range may look simple but in the driver it looks like
this:
+static
> linux-asp...@lists.ozlabs.org; linux-
> ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> linux-g...@vger.kernel.org
> Subject: Re: [PATCH 2/3 v4] dt-bindings: gpio: aspeed: Add SGPIO support
>
> The subject is largely correct, but please see the discussion on
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
The subject is largely correct, but please see the discussion on the driver
patch
about how to clean up the [PATCH ...] prefix.
On Thu, 18 Jul 2019, at 05:42, Hongwei Zhang wrote:
> Add bindings to support SGPIO on AST2400 or AST2500.
>
> Signed-off-by: Hongwei Zhang
> ---
>
Hello Andrew,
Thanks for your review, please find the v4 in separate email. We merged all
your suggestion in v4.
Best Regards,
--Hongwei
-Original Message-
> From: Andrew Jeffery
> Sent: Tuesday, July 16, 2019 11:26 PM
> To: Hongwei Zhang; Bartosz Golaszewski; Joel Stanley; Linus
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
Thanks Andrew, please see above v3 and inline comments at below.
> --Hongwei
>
> > From: Andrew Jeffery
> > Sent: Sunday, July 14, 2019 10:25 PM
> > To: Hongwei Zhang; Joel Stanley; Linus Walleij; devicet...@vger.kernel.org
> > Cc: Rob Herring; Mark
s.infradead.org;
> linux-g...@vger.kernel.org
> Subject: Re: [PATCH 2/3 v2] dt-bindings: gpio: aspeed: Add SGPIO support
>
> Hello Hongwei,
>
> On Sat, 13 Jul 2019, at 05:44, Hongwei Zhang wrote:
> > Add bindings to support SGPIO on AST2400 or AST2500.
Hello Hongwei,
On Sat, 13 Jul 2019, at 05:44, Hongwei Zhang wrote:
> Add bindings to support SGPIO on AST2400 or AST2500.
>
> Signed-off-by: Hongwei Zhang
> ---
> .../devicetree/bindings/gpio/sgpio-aspeed.txt | 43
> ++
> 1 file changed, 43 insertions(+)
> create
Thanks for your review, Andrew,
Just submitted an updated binding document, with new proper subject line:
[PATCH 2/3 v2] dt-bindings: gpio: aspeed: Add SGPIO support
Regards,
--Hongwei
-Original Message-
From: Andrew Jeffery
Sent: Tuesday, July 9, 2019 10:16 PM
To: Hongwei Zhang
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 43 ++
1 file changed, 43 insertions(+)
create mode 100755 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
On Thu, 4 Jul 2019, at 05:31, Hongwei Zhang wrote:
> Add bindings to support SGPIO on AST2400 or AST2500.
>
> Signed-off-by: Hongwei Zhang
> ---
> .../devicetree/bindings/gpio/sgpio-aspeed.txt | 36
> ++
> 1 file changed, 36 insertions(+)
> create mode 100644
On Wed, 10 Jul 2019, at 04:23, Rob Herring wrote:
> On Wed, Jul 3, 2019 at 2:01 PM Hongwei Zhang wrote:
> >
> > Add bindings to support SGPIO on AST2400 or AST2500.
> >
> > Signed-off-by: Hongwei Zhang
> > ---
> > .../devicetree/bindings/gpio/sgpio-aspeed.txt | 36
> >
On Wed, Jul 3, 2019 at 2:01 PM Hongwei Zhang wrote:
>
> Add bindings to support SGPIO on AST2400 or AST2500.
>
> Signed-off-by: Hongwei Zhang
> ---
> .../devicetree/bindings/gpio/sgpio-aspeed.txt | 36
> ++
Is this SGPIO as in the blinky lights for HDDs in servers? If
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 36 ++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
24 matches
Mail list logo
