Re: echo mem > /sys/power/state

2008-01-23 Thread Pavel Machek
Hi! > > Set alarm belongs in drivers/rtc, moved now. > > > > > > + alarm = now+length; > > > > + rtc_time_to_tm(alarm, ); > > > > + > > > > + retval = cmos_set_alarm(rtc, ); > > > > > > cmos_set_alarm() takes a struct device * too. > > > > Fixed. > > any updated patch i

Re: echo mem /sys/power/state

2008-01-23 Thread Pavel Machek
Hi! Set alarm belongs in drivers/rtc, moved now. + alarm = now+length; + rtc_time_to_tm(alarm, alm.time); + + retval = cmos_set_alarm(rtc, alm); cmos_set_alarm() takes a struct device * too. Fixed. any updated patch i could try? Thanks, Here

Re: echo mem > /sys/power/state

2008-01-22 Thread Ingo Molnar
* Pavel Machek <[EMAIL PROTECTED]> wrote: > Set alarm belongs in drivers/rtc, moved now. > > > > + alarm = now+length; > > > + rtc_time_to_tm(alarm, ); > > > + > > > + retval = cmos_set_alarm(rtc, ); > > > > cmos_set_alarm() takes a struct device * too. > > Fixed. any updated patch i could

Re: echo mem /sys/power/state

2008-01-22 Thread Ingo Molnar
* Pavel Machek [EMAIL PROTECTED] wrote: Set alarm belongs in drivers/rtc, moved now. + alarm = now+length; + rtc_time_to_tm(alarm, alm.time); + + retval = cmos_set_alarm(rtc, alm); cmos_set_alarm() takes a struct device * too. Fixed. any updated patch i could try? Thanks,

Re: echo mem > /sys/power/state

2008-01-21 Thread Pavel Machek
Hi! > > index f7dfff2..e5693d6 100644 > > --- a/kernel/power/Makefile > > +++ b/kernel/power/Makefile > > @@ -5,7 +5,7 @@ endif > > > > obj-y := main.o > > obj-$(CONFIG_PM_LEGACY)+= pm.o > > -obj-$(CONFIG_PM_SLEEP) += process.o console.o >

Re: echo mem /sys/power/state

2008-01-21 Thread Pavel Machek
Hi! index f7dfff2..e5693d6 100644 --- a/kernel/power/Makefile +++ b/kernel/power/Makefile @@ -5,7 +5,7 @@ endif obj-y := main.o obj-$(CONFIG_PM_LEGACY)+= pm.o -obj-$(CONFIG_PM_SLEEP) += process.o console.o

Re: echo mem > /sys/power/state

2008-01-20 Thread Johannes Weiner
Hi, Pavel Machek <[EMAIL PROTECTED]> writes: > diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c > index 29cf145..d830ed2 100644 > --- a/drivers/rtc/rtc-cmos.c > +++ b/drivers/rtc/rtc-cmos.c > @@ -78,7 +78,7 @@ static inline int is_intr(u8 rtc_intr) > >

Re: echo mem > /sys/power/state

2008-01-20 Thread Pavel Machek
On Mon 2008-01-21 00:42:08, Ingo Molnar wrote: > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > Hi! > > > > Ingo wanted simple sleep self-test... Here's something. > > thanks :) > > threw it into auto-qa, and it got thrown back with: Ok... it needs to depend on cmos_rtc... Plus timeout

Re: echo mem > /sys/power/state

2008-01-20 Thread Ingo Molnar
* Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > Ingo wanted simple sleep self-test... Here's something. thanks :) threw it into auto-qa, and it got thrown back with: dione:~/linux/linux> ./err kernel/power/sleepy.c: In function 'set_alarm': kernel/power/sleepy.c:50: warning: passing

Re: echo mem > /sys/power/state

2008-01-20 Thread Pavel Machek
Hi! Ingo wanted simple sleep self-test... Here's something. set_alarm needs to move into rtc-cmos, and I guess I should boottest it... Pavel ~be careful what you wish for~ Machek diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 29cf145..d830ed2 100644

Re: echo mem /sys/power/state

2008-01-20 Thread Pavel Machek
Hi! Ingo wanted simple sleep self-test... Here's something. set_alarm needs to move into rtc-cmos, and I guess I should boottest it... Pavel ~be careful what you wish for~ Machek diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 29cf145..d830ed2 100644

Re: echo mem /sys/power/state

2008-01-20 Thread Ingo Molnar
* Pavel Machek [EMAIL PROTECTED] wrote: Hi! Ingo wanted simple sleep self-test... Here's something. thanks :) threw it into auto-qa, and it got thrown back with: dione:~/linux/linux ./err kernel/power/sleepy.c: In function 'set_alarm': kernel/power/sleepy.c:50: warning: passing argument 1

Re: echo mem /sys/power/state

2008-01-20 Thread Pavel Machek
On Mon 2008-01-21 00:42:08, Ingo Molnar wrote: * Pavel Machek [EMAIL PROTECTED] wrote: Hi! Ingo wanted simple sleep self-test... Here's something. thanks :) threw it into auto-qa, and it got thrown back with: Ok... it needs to depend on cmos_rtc... Plus timeout needs to be

Re: echo mem /sys/power/state

2008-01-20 Thread Johannes Weiner
Hi, Pavel Machek [EMAIL PROTECTED] writes: diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 29cf145..d830ed2 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -78,7 +78,7 @@ static inline int is_intr(u8 rtc_intr)

Re: echo mem > /sys/power/state

2008-01-18 Thread Rafael J. Wysocki
On Friday, 18 of January 2008, Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > (it doesnt matter if graphics does not resume fine - at least for my > > > tests) > > > > > > kprobes had similar problems and it now has a few simple smoke-tests > > > - which i just saw

Re: echo mem > /sys/power/state

2008-01-18 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > (it doesnt matter if graphics does not resume fine - at least for my > > tests) > > > > kprobes had similar problems and it now has a few simple smoke-tests > > - which i just saw trigger on a patch that i did not notice would > > break kprobes.

Re: echo mem > /sys/power/state

2008-01-18 Thread Harvey Harrison
On Fri, 2008-01-18 at 00:47 -0800, Andrew Morton wrote: > On Fri, 18 Jan 2008 09:36:10 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > * Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > > > > Probably it would be more efficient to have the people who wrote the > > > > code also test

Re: echo mem > /sys/power/state

2008-01-18 Thread Ingo Molnar
* Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 01/17/2008 08:13 PM, Andrew Morton wrote: >> On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: >>> Heh. Laptop suspend to anything has been so broken for so long in the >>> -mm series on my Compaq R3000 that I didn't even know it

Re: echo mem > /sys/power/state

2008-01-18 Thread Andrew Morton
On Fri, 18 Jan 2008 09:36:10 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > > Probably it would be more efficient to have the people who wrote the > > > code also test it. > > > > Well, that would certainly help. > > > > I do test all of

Re: echo mem > /sys/power/state

2008-01-18 Thread Ingo Molnar
* Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Probably it would be more efficient to have the people who wrote the > > code also test it. > > Well, that would certainly help. > > I do test all of my patches and generally all of the patches I sign > off, but surely that's not enough.

Re: echo mem /sys/power/state

2008-01-18 Thread Ingo Molnar
* Rafael J. Wysocki [EMAIL PROTECTED] wrote: Probably it would be more efficient to have the people who wrote the code also test it. Well, that would certainly help. I do test all of my patches and generally all of the patches I sign off, but surely that's not enough. please add a

Re: echo mem /sys/power/state

2008-01-18 Thread Andrew Morton
On Fri, 18 Jan 2008 09:36:10 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: * Rafael J. Wysocki [EMAIL PROTECTED] wrote: Probably it would be more efficient to have the people who wrote the code also test it. Well, that would certainly help. I do test all of my patches and

Re: echo mem /sys/power/state

2008-01-18 Thread Ingo Molnar
* Jiri Slaby [EMAIL PROTECTED] wrote: On 01/17/2008 08:13 PM, Andrew Morton wrote: On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx [EMAIL PROTECTED] wrote: Heh. Laptop suspend to anything has been so broken for so long in the -mm series on my Compaq R3000 that I didn't even know it was ever

Re: echo mem /sys/power/state

2008-01-18 Thread Harvey Harrison
On Fri, 2008-01-18 at 00:47 -0800, Andrew Morton wrote: On Fri, 18 Jan 2008 09:36:10 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: * Rafael J. Wysocki [EMAIL PROTECTED] wrote: Probably it would be more efficient to have the people who wrote the code also test it. Well, that

Re: echo mem /sys/power/state

2008-01-18 Thread Ingo Molnar
* Andrew Morton [EMAIL PROTECTED] wrote: (it doesnt matter if graphics does not resume fine - at least for my tests) kprobes had similar problems and it now has a few simple smoke-tests - which i just saw trigger on a patch that i did not notice would break kprobes. I think this

Re: echo mem /sys/power/state

2008-01-18 Thread Rafael J. Wysocki
On Friday, 18 of January 2008, Ingo Molnar wrote: * Andrew Morton [EMAIL PROTECTED] wrote: (it doesnt matter if graphics does not resume fine - at least for my tests) kprobes had similar problems and it now has a few simple smoke-tests - which i just saw trigger on a patch

Re: echo mem > /sys/power/state

2008-01-17 Thread Rafael J. Wysocki
On Thursday, 17 of January 2008, Nigel Cunningham wrote: > Hi. > > Rafael J. Wysocki wrote: > > On Thursday, 17 of January 2008, Andrew Morton wrote: > >> On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: > >> > >>> On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: >

Re: echo mem > /sys/power/state

2008-01-17 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: > On Thursday, 17 of January 2008, Andrew Morton wrote: >> On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: >> >>> On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: So I take everyone's latest and greatest product and injudiciously

Re: echo mem > /sys/power/state

2008-01-17 Thread Jiri Slaby
On 01/17/2008 08:13 PM, Andrew Morton wrote: On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: Heh. Laptop suspend to anything has been so broken for so long in the -mm series on my Compaq R3000 that I didn't even know it was ever supposed to work. It gets broken more

Re: echo mem > /sys/power/state

2008-01-17 Thread Rafael J. Wysocki
On Thursday, 17 of January 2008, Andrew Morton wrote: > On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: > > > So I take everyone's latest and greatest product and injudiciously type > > > the > > > above

Re: echo mem > /sys/power/state

2008-01-17 Thread Andrew Morton
On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: > > So I take everyone's latest and greatest product and injudiciously type the > > above command. The result five minutes later is at > >

Re: echo mem > /sys/power/state

2008-01-17 Thread Rafael J. Wysocki
On Thursday, 17 of January 2008, Andrew Morton wrote: > > So I take everyone's latest and greatest product and injudiciously type the > above command. The result five minutes later is at > http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all the > bugs. > > Sorry, but I've

Re: echo mem > /sys/power/state

2008-01-17 Thread Zan Lynx
On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: > So I take everyone's latest and greatest product and injudiciously type the > above command. The result five minutes later is at > http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all the > bugs. > > Sorry, but I've

Re: echo mem /sys/power/state

2008-01-17 Thread Rafael J. Wysocki
On Thursday, 17 of January 2008, Andrew Morton wrote: So I take everyone's latest and greatest product and injudiciously type the above command. The result five minutes later is at http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all the bugs. Sorry, but I've had it

Re: echo mem /sys/power/state

2008-01-17 Thread Andrew Morton
On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: So I take everyone's latest and greatest product and injudiciously type the above command. The result five minutes later is at

Re: echo mem /sys/power/state

2008-01-17 Thread Zan Lynx
On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: So I take everyone's latest and greatest product and injudiciously type the above command. The result five minutes later is at http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all the bugs. Sorry, but I've had it

Re: echo mem /sys/power/state

2008-01-17 Thread Rafael J. Wysocki
On Thursday, 17 of January 2008, Andrew Morton wrote: On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: So I take everyone's latest and greatest product and injudiciously type the above command. The

Re: echo mem /sys/power/state

2008-01-17 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: On Thursday, 17 of January 2008, Andrew Morton wrote: On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: So I take everyone's latest and greatest product and injudiciously type the above

Re: echo mem /sys/power/state

2008-01-17 Thread Jiri Slaby
On 01/17/2008 08:13 PM, Andrew Morton wrote: On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx [EMAIL PROTECTED] wrote: Heh. Laptop suspend to anything has been so broken for so long in the -mm series on my Compaq R3000 that I didn't even know it was ever supposed to work. It gets broken more

Re: echo mem /sys/power/state

2008-01-17 Thread Rafael J. Wysocki
On Thursday, 17 of January 2008, Nigel Cunningham wrote: Hi. Rafael J. Wysocki wrote: On Thursday, 17 of January 2008, Andrew Morton wrote: On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: So I take

echo mem > /sys/power/state

2008-01-16 Thread Andrew Morton
So I take everyone's latest and greatest product and injudiciously type the above command. The result five minutes later is at http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all the bugs. Sorry, but I've had it with this stuff and I'm tired of fixing everyone else's stuff.

echo mem /sys/power/state

2008-01-16 Thread Andrew Morton
So I take everyone's latest and greatest product and injudiciously type the above command. The result five minutes later is at http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all the bugs. Sorry, but I've had it with this stuff and I'm tired of fixing everyone else's stuff.