[PATCH 21/28] sysfs: error handling in sysfs, fill_read_buffer()

2007-02-07 Thread Greg KH
From: Oliver Neukum <[EMAIL PROTECTED]> if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has been read. Not marking the buffer filled is the obvious fix.

[PATCH 21/28] sysfs: error handling in sysfs, fill_read_buffer()

2007-02-07 Thread Greg KH
From: Oliver Neukum [EMAIL PROTECTED] if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has been read. Not marking the buffer filled is the obvious fix.

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Oliver Neukum
Am Dienstag, 2. Januar 2007 16:47 schrieb Alan Stern: > On Tue, 2 Jan 2007, Oliver Neukum wrote: > > > Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: > > > On Tue, 2 Jan 2007, Oliver Neukum wrote: > > > > > > > Hi, > > > > > > > > if a driver returns an error in fill_read_buffer(), the

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Alan Stern
On Tue, 2 Jan 2007, Oliver Neukum wrote: > Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: > > On Tue, 2 Jan 2007, Oliver Neukum wrote: > > > > > Hi, > > > > > > if a driver returns an error in fill_read_buffer(), the buffer will be > > > marked as filled. Subsequent reads will return

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Oliver Neukum
Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: > On Tue, 2 Jan 2007, Oliver Neukum wrote: > > > Hi, > > > > if a driver returns an error in fill_read_buffer(), the buffer will be > > marked as filled. Subsequent reads will return eof. But there is > > no data because of an error, not

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Alan Stern
On Tue, 2 Jan 2007, Oliver Neukum wrote: > Hi, > > if a driver returns an error in fill_read_buffer(), the buffer will be > marked as filled. Subsequent reads will return eof. But there is > no data because of an error, not because it has been read. > Not marking the buffer filled is the obvious

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Alan Stern
On Tue, 2 Jan 2007, Oliver Neukum wrote: Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has been read. Not marking the buffer filled is the obvious fix.

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Oliver Neukum
Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: On Tue, 2 Jan 2007, Oliver Neukum wrote: Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Alan Stern
On Tue, 2 Jan 2007, Oliver Neukum wrote: Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: On Tue, 2 Jan 2007, Oliver Neukum wrote: Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Oliver Neukum
Am Dienstag, 2. Januar 2007 16:47 schrieb Alan Stern: On Tue, 2 Jan 2007, Oliver Neukum wrote: Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: On Tue, 2 Jan 2007, Oliver Neukum wrote: Hi, if a driver returns an error in fill_read_buffer(), the buffer will be

error handling in sysfs, fill_read_buffer()

2007-01-01 Thread Oliver Neukum
Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has been read. Not marking the buffer filled is the obvious fix. Regards Oliver

error handling in sysfs, fill_read_buffer()

2007-01-01 Thread Oliver Neukum
Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has been read. Not marking the buffer filled is the obvious fix. Regards Oliver