Re: fpga: fpga_mgr_get() buggy ?

On Thu, Aug 16, 2018 at 2:18 AM, Federico Vaga wrote: > Hi alan, > > inline comments > > On Wednesday, August 15, 2018 11:02:12 PM CEST Alan Tull wrote: >> On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga > wrote: >> > Hi Alan, >> > >> > Thanks for your time, comments below >> > >> > On Wednesday,

Re: fpga: fpga_mgr_get() buggy ?

On Thu, Aug 16, 2018 at 2:18 AM, Federico Vaga wrote: > Hi alan, > > inline comments > > On Wednesday, August 15, 2018 11:02:12 PM CEST Alan Tull wrote: >> On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga > wrote: >> > Hi Alan, >> > >> > Thanks for your time, comments below >> > >> > On Wednesday,

Re: fpga: fpga_mgr_get() buggy ?

Hi alan, inline comments On Wednesday, August 15, 2018 11:02:12 PM CEST Alan Tull wrote: > On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga wrote: > > Hi Alan, > > > > Thanks for your time, comments below > > > > On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: > >> On Thu, Jun 28,

Re: fpga: fpga_mgr_get() buggy ?

Hi alan, inline comments On Wednesday, August 15, 2018 11:02:12 PM CEST Alan Tull wrote: > On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga wrote: > > Hi Alan, > > > > Thanks for your time, comments below > > > > On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: > >> On Thu, Jun 28,

Re: fpga: fpga_mgr_get() buggy ?

On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga wrote: > Hi Alan, > > Thanks for your time, comments below > > On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: >> On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga > wrote: >> > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: >>

Re: fpga: fpga_mgr_get() buggy ?

On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga wrote: > Hi Alan, > > Thanks for your time, comments below > > On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: >> On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga > wrote: >> > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: >>

Re: fpga: fpga_mgr_get() buggy ?

Hi Alan, Thanks for your time, comments below On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: > On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga wrote: > > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > >> On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga > > > > wrote:

Re: fpga: fpga_mgr_get() buggy ?

Hi Alan, Thanks for your time, comments below On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: > On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga wrote: > > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > >> On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga > > > > wrote:

Re: fpga: fpga_mgr_get() buggy ?

On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga wrote: > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: >> On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga > wrote: >> > Hi Alan, >> > >> > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: >> >> On Fri, Jun 22, 2018 at 2:53 AM,

Re: fpga: fpga_mgr_get() buggy ?

On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga wrote: > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: >> On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga > wrote: >> > Hi Alan, >> > >> > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: >> >> On Fri, Jun 22, 2018 at 2:53 AM,

Re: fpga: fpga_mgr_get() buggy ?

On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga wrote: > > Hi Alan, > > > > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > >> On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga > >> wrote: > >> > >> Hi Federico, > >> > >> >> >

Re: fpga: fpga_mgr_get() buggy ?

On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga wrote: > > Hi Alan, > > > > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > >> On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga > >> wrote: > >> > >> Hi Federico, > >> > >> >> >

Re: fpga: fpga_mgr_get() buggy ?

On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga wrote: > Hi Alan, > > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: >> On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga >> wrote: >> >> Hi Federico, >> >> >> > What is buggy is the function fpga_mgr_get(). >> >> > That patch has been done to

Re: fpga: fpga_mgr_get() buggy ?

On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga wrote: > Hi Alan, > > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: >> On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga >> wrote: >> >> Hi Federico, >> >> >> > What is buggy is the function fpga_mgr_get(). >> >> > That patch has been done to

Re: fpga: fpga_mgr_get() buggy ?

Hi Alan, On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga > wrote: > > Hi Federico, > > >> > What is buggy is the function fpga_mgr_get(). > >> > That patch has been done to allow multiple FPGA manager > >> > instances > >> > to be linked

Re: fpga: fpga_mgr_get() buggy ?

Hi Alan, On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga > wrote: > > Hi Federico, > > >> > What is buggy is the function fpga_mgr_get(). > >> > That patch has been done to allow multiple FPGA manager > >> > instances > >> > to be linked

Re: fpga: fpga_mgr_get() buggy ?

On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga wrote: Hi Federico, >> > What is buggy is the function fpga_mgr_get(). >> > That patch has been done to allow multiple FPGA manager instances >> > to be linked to the same device (PCI it says). But function >> > fpga_mgr_get() will return only the

Re: fpga: fpga_mgr_get() buggy ?

On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga wrote: Hi Federico, >> > What is buggy is the function fpga_mgr_get(). >> > That patch has been done to allow multiple FPGA manager instances >> > to be linked to the same device (PCI it says). But function >> > fpga_mgr_get() will return only the

Re: fpga: fpga_mgr_get() buggy ?

Hi Alan, inline comments On Friday, 22 June 2018 04:07:41 CEST Alan Tull wrote: > On Thu, Jun 21, 2018 at 8:13 AM, Federico Vaga > wrote: > > Hi Federico, > > Thanks for the analysis. I'll probably not be able to look into > this very much until next week. A few notes below. > > > Hello, >

Re: fpga: fpga_mgr_get() buggy ?

Hi Alan, inline comments On Friday, 22 June 2018 04:07:41 CEST Alan Tull wrote: > On Thu, Jun 21, 2018 at 8:13 AM, Federico Vaga > wrote: > > Hi Federico, > > Thanks for the analysis. I'll probably not be able to look into > this very much until next week. A few notes below. > > > Hello, >

Re: fpga: fpga_mgr_get() buggy ?

On Thu, Jun 21, 2018 at 8:13 AM, Federico Vaga wrote: Hi Federico, Thanks for the analysis. I'll probably not be able to look into this very much until next week. A few notes below. > Hello, > > I believe that this patch > > fpga: manager: change api, don't use drvdata >

Re: fpga: fpga_mgr_get() buggy ?

On Thu, Jun 21, 2018 at 8:13 AM, Federico Vaga wrote: Hi Federico, Thanks for the analysis. I'll probably not be able to look into this very much until next week. A few notes below. > Hello, > > I believe that this patch > > fpga: manager: change api, don't use drvdata >

fpga: fpga_mgr_get() buggy ?

Hello, I believe that this patch fpga: manager: change api, don't use drvdata 7085e2a94f7df5f419e3cfb2fe809ce6564e9629 is incomplete and buggy. I completely agree that drvdata should not be used by the FPGA manager or any other subsystem like that. What is buggy is the function

fpga: fpga_mgr_get() buggy ?

Hello, I believe that this patch fpga: manager: change api, don't use drvdata 7085e2a94f7df5f419e3cfb2fe809ce6564e9629 is incomplete and buggy. I completely agree that drvdata should not be used by the FPGA manager or any other subsystem like that. What is buggy is the function