Re: fs_context-related oops in mainline

2019-03-15 Thread Al Viro
On Fri, Mar 15, 2019 at 02:24:30PM +, David Howells wrote: > Al Viro wrote: > > > - if (fc->user_ns) > > - put_user_ns(fc->user_ns); > > - fc->user_ns = get_user_ns(netns->user_ns); > > + if (netns) { > > + if (fc->user_ns) > > + put_user_ns(fc->use

Re: fs_context-related oops in mainline

2019-03-15 Thread Greg Kroah-Hartman
On Fri, Mar 15, 2019 at 02:24:30PM +, David Howells wrote: > Al Viro wrote: > > > - if (fc->user_ns) > > - put_user_ns(fc->user_ns); > > - fc->user_ns = get_user_ns(netns->user_ns); > > + if (netns) { > > + if (fc->user_ns) > > + put_user_ns(fc->use

Re: fs_context-related oops in mainline

2019-03-15 Thread David Howells
Al Viro wrote: > - if (fc->user_ns) > - put_user_ns(fc->user_ns); > - fc->user_ns = get_user_ns(netns->user_ns); > + if (netns) { > + if (fc->user_ns) > + put_user_ns(fc->user_ns); > + fc->user_ns = get_user_ns(netns->user_ns); >

Re: fs_context-related oops in mainline

2019-03-15 Thread Dominik Brodowski
On Fri, Mar 15, 2019 at 12:18:13PM +, Al Viro wrote: > On Fri, Mar 15, 2019 at 12:50:02PM +0100, Dominik Brodowski wrote: > > On Fri, Mar 15, 2019 at 11:44:45AM +, David Howells wrote: > > > Dominik Brodowski wrote: > > > > > > > [0.839322] RIP: 0010:sysfs_init_fs_context+0x82/0xd0 >

Re: fs_context-related oops in mainline

2019-03-15 Thread Al Viro
On Fri, Mar 15, 2019 at 12:50:02PM +0100, Dominik Brodowski wrote: > On Fri, Mar 15, 2019 at 11:44:45AM +, David Howells wrote: > > Dominik Brodowski wrote: > > > > > [0.839322] RIP: 0010:sysfs_init_fs_context+0x82/0xd0 > > > > Could you load your kernel into gdb and then do: > > > >

Re: fs_context-related oops in mainline

2019-03-15 Thread Dominik Brodowski
On Fri, Mar 15, 2019 at 11:44:45AM +, David Howells wrote: > Dominik Brodowski wrote: > > > [0.839322] RIP: 0010:sysfs_init_fs_context+0x82/0xd0 > > Could you load your kernel into gdb and then do: > > i li *sysfs_init_fs_context+0x82 Doesn't seem necessary as per my mail to Al a

Re: fs_context-related oops in mainline

2019-03-15 Thread Dominik Brodowski
On Fri, Mar 15, 2019 at 11:34:47AM +, Al Viro wrote: > On Fri, Mar 15, 2019 at 08:43:07AM +0100, Dominik Brodowski wrote: > > David, Al, > > > > commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context") > > seems to have introduced a bug; at least that's the commit I bisecte

Re: fs_context-related oops in mainline

2019-03-15 Thread David Howells
Dominik Brodowski wrote: > [0.839322] RIP: 0010:sysfs_init_fs_context+0x82/0xd0 Could you load your kernel into gdb and then do: i li *sysfs_init_fs_context+0x82 David

Re: fs_context-related oops in mainline

2019-03-15 Thread Al Viro
On Fri, Mar 15, 2019 at 08:43:07AM +0100, Dominik Brodowski wrote: > David, Al, > > commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context") > seems to have introduced a bug; at least that's the commit I bisected the > following oops down to: > This occurs while trying to moun

fs_context-related oops in mainline

2019-03-15 Thread Dominik Brodowski
David, Al, commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context") seems to have introduced a bug; at least that's the commit I bisected the following oops down to: [0.827317] BUG: unable to handle kernel NULL pointer dereference at 0220 [0.829771] #PF er