Re: futex_cmpxchg_enabled breakage

2018-09-17 Thread Rich Felker
On Sun, Sep 16, 2018 at 03:38:44PM +0200, Florian Weimer wrote: > * Rich Felker: > > >> I believe the expected userspace interface is that you probe support > >> with set_robust_list first, and then start using the relevant futex > >> interfaces only if that call succeeded. > > > > In order for

Re: futex_cmpxchg_enabled breakage

2018-09-17 Thread Rich Felker
On Sun, Sep 16, 2018 at 03:38:44PM +0200, Florian Weimer wrote: > * Rich Felker: > > >> I believe the expected userspace interface is that you probe support > >> with set_robust_list first, and then start using the relevant futex > >> interfaces only if that call succeeded. > > > > In order for

Re: futex_cmpxchg_enabled breakage

2018-09-16 Thread Florian Weimer
* Rich Felker: >> I believe the expected userspace interface is that you probe support >> with set_robust_list first, and then start using the relevant futex >> interfaces only if that call succeeded. > > In order for it to work, set_robust_list needs to succeed for all > threads, present and

Re: futex_cmpxchg_enabled breakage

2018-09-16 Thread Florian Weimer
* Rich Felker: >> I believe the expected userspace interface is that you probe support >> with set_robust_list first, and then start using the relevant futex >> interfaces only if that call succeeded. > > In order for it to work, set_robust_list needs to succeed for all > threads, present and

Re: futex_cmpxchg_enabled breakage

2018-09-16 Thread Rich Felker
On Sun, Sep 16, 2018 at 02:16:25PM +0200, Florian Weimer wrote: > * Rich Felker: > > > I just spent a number of hours helping someone track down a bug that > > looks like it's some kind of futex_cmpxchg_enabled detection error on > > powerpc64 (still not sure of the root cause; set_robust_list

Re: futex_cmpxchg_enabled breakage

2018-09-16 Thread Rich Felker
On Sun, Sep 16, 2018 at 02:16:25PM +0200, Florian Weimer wrote: > * Rich Felker: > > > I just spent a number of hours helping someone track down a bug that > > looks like it's some kind of futex_cmpxchg_enabled detection error on > > powerpc64 (still not sure of the root cause; set_robust_list

Re: futex_cmpxchg_enabled breakage

2018-09-16 Thread Florian Weimer
* Rich Felker: > I just spent a number of hours helping someone track down a bug that > looks like it's some kind of futex_cmpxchg_enabled detection error on > powerpc64 (still not sure of the root cause; set_robust_list producing > -ENOSYS), and a while back I hit the same problem on sh2 due to

Re: futex_cmpxchg_enabled breakage

2018-09-16 Thread Florian Weimer
* Rich Felker: > I just spent a number of hours helping someone track down a bug that > looks like it's some kind of futex_cmpxchg_enabled detection error on > powerpc64 (still not sure of the root cause; set_robust_list producing > -ENOSYS), and a while back I hit the same problem on sh2 due to

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Thomas Gleixner
On Sat, 15 Sep 2018, Rich Felker wrote: > On Sat, Sep 15, 2018 at 05:34:24PM +0200, Thomas Gleixner wrote: > > By doing that you paper over a non functional fixup which could cause other > > really hard to decode runtime failures. If that fails there is a bug > > somewhere else and that runtime

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Thomas Gleixner
On Sat, 15 Sep 2018, Rich Felker wrote: > On Sat, Sep 15, 2018 at 05:34:24PM +0200, Thomas Gleixner wrote: > > By doing that you paper over a non functional fixup which could cause other > > really hard to decode runtime failures. If that fails there is a bug > > somewhere else and that runtime

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Rich Felker
On Sat, Sep 15, 2018 at 12:15:54PM -0400, Rich Felker wrote: > On Sat, Sep 15, 2018 at 05:34:24PM +0200, Thomas Gleixner wrote: > > On Thu, 30 Aug 2018, Rich Felker wrote: > > > On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > > > > On Wed, 29 Aug 2018, Rich Felker wrote: > > > >

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Rich Felker
On Sat, Sep 15, 2018 at 12:15:54PM -0400, Rich Felker wrote: > On Sat, Sep 15, 2018 at 05:34:24PM +0200, Thomas Gleixner wrote: > > On Thu, 30 Aug 2018, Rich Felker wrote: > > > On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > > > > On Wed, 29 Aug 2018, Rich Felker wrote: > > > >

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Rich Felker
On Sat, Sep 15, 2018 at 05:34:24PM +0200, Thomas Gleixner wrote: > On Thu, 30 Aug 2018, Rich Felker wrote: > > On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > > > On Wed, 29 Aug 2018, Rich Felker wrote: > > > > > > > I just spent a number of hours helping someone track down a

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Rich Felker
On Sat, Sep 15, 2018 at 05:34:24PM +0200, Thomas Gleixner wrote: > On Thu, 30 Aug 2018, Rich Felker wrote: > > On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > > > On Wed, 29 Aug 2018, Rich Felker wrote: > > > > > > > I just spent a number of hours helping someone track down a

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Thomas Gleixner
On Thu, 30 Aug 2018, Rich Felker wrote: > On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > > On Wed, 29 Aug 2018, Rich Felker wrote: > > > > > I just spent a number of hours helping someone track down a bug that > > > looks like it's some kind of futex_cmpxchg_enabled detection

Re: futex_cmpxchg_enabled breakage

2018-09-15 Thread Thomas Gleixner
On Thu, 30 Aug 2018, Rich Felker wrote: > On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > > On Wed, 29 Aug 2018, Rich Felker wrote: > > > > > I just spent a number of hours helping someone track down a bug that > > > looks like it's some kind of futex_cmpxchg_enabled detection

Re: futex_cmpxchg_enabled breakage

2018-08-30 Thread Rich Felker
On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > On Wed, 29 Aug 2018, Rich Felker wrote: > > > I just spent a number of hours helping someone track down a bug that > > looks like it's some kind of futex_cmpxchg_enabled detection error on > > powerpc64 (still not sure of the root

Re: futex_cmpxchg_enabled breakage

2018-08-30 Thread Rich Felker
On Thu, Aug 30, 2018 at 11:19:58AM +0200, Thomas Gleixner wrote: > On Wed, 29 Aug 2018, Rich Felker wrote: > > > I just spent a number of hours helping someone track down a bug that > > looks like it's some kind of futex_cmpxchg_enabled detection error on > > powerpc64 (still not sure of the root

Re: futex_cmpxchg_enabled breakage

2018-08-30 Thread Peter Zijlstra
On Wed, Aug 29, 2018 at 06:22:21PM -0400, Rich Felker wrote: > If there are archs that support SMP but don't provide their own Then throw it out the window and drive over it with a tank. Seriously, an SMP architecture that doesn't have native cmpxchg (or equivalent) is not worth anybodies time.

Re: futex_cmpxchg_enabled breakage

2018-08-30 Thread Peter Zijlstra
On Wed, Aug 29, 2018 at 06:22:21PM -0400, Rich Felker wrote: > If there are archs that support SMP but don't provide their own Then throw it out the window and drive over it with a tank. Seriously, an SMP architecture that doesn't have native cmpxchg (or equivalent) is not worth anybodies time.

Re: futex_cmpxchg_enabled breakage

2018-08-30 Thread Thomas Gleixner
On Wed, 29 Aug 2018, Rich Felker wrote: > I just spent a number of hours helping someone track down a bug that > looks like it's some kind of futex_cmpxchg_enabled detection error on > powerpc64 (still not sure of the root cause; set_robust_list producing > -ENOSYS), and a while back I hit the

Re: futex_cmpxchg_enabled breakage

2018-08-30 Thread Thomas Gleixner
On Wed, 29 Aug 2018, Rich Felker wrote: > I just spent a number of hours helping someone track down a bug that > looks like it's some kind of futex_cmpxchg_enabled detection error on > powerpc64 (still not sure of the root cause; set_robust_list producing > -ENOSYS), and a while back I hit the

futex_cmpxchg_enabled breakage

2018-08-29 Thread Rich Felker
I just spent a number of hours helping someone track down a bug that looks like it's some kind of futex_cmpxchg_enabled detection error on powerpc64 (still not sure of the root cause; set_robust_list producing -ENOSYS), and a while back I hit the same problem on sh2 due to lack of EFAULT on nommu,

futex_cmpxchg_enabled breakage

2018-08-29 Thread Rich Felker
I just spent a number of hours helping someone track down a bug that looks like it's some kind of futex_cmpxchg_enabled detection error on powerpc64 (still not sure of the root cause; set_robust_list producing -ENOSYS), and a while back I hit the same problem on sh2 due to lack of EFAULT on nommu,