Re: general protection fault in j1939_netdev_notify (2)

2020-12-21 Thread Oleksij Rempel
On Mon, Dec 21, 2020 at 01:25:47PM +0100, Oliver Hartkopp wrote: > > > On 20.12.20 15:37, Oleksij Rempel wrote: > > Hello Oliver, > > > > On Sun, Dec 20, 2020 at 02:18:27PM +0100, Oliver Hartkopp wrote: > > > Hello Oleksij, > > > > > > I assume there is some ndev->ml_priv value set - but not fr

Re: general protection fault in j1939_netdev_notify (2)

2020-12-21 Thread Oliver Hartkopp
On 20.12.20 15:37, Oleksij Rempel wrote: Hello Oliver, On Sun, Dec 20, 2020 at 02:18:27PM +0100, Oliver Hartkopp wrote: Hello Oleksij, I assume there is some ndev->ml_priv value set - but not from a CAN netdevice. it is kind of CAN device :) No, it is not. Team and bonding devices copy

Re: general protection fault in j1939_netdev_notify (2)

2020-12-20 Thread Oleksij Rempel
Hello Oliver, On Sun, Dec 20, 2020 at 02:18:27PM +0100, Oliver Hartkopp wrote: > Hello Oleksij, > > I assume there is some ndev->ml_priv value set - but not from a CAN > netdevice. it is kind of CAN device :) > What was the reason to fiddle with the 'priv' stuff in j1939_netdev_notify() > befor

Re: general protection fault in j1939_netdev_notify (2)

2020-12-20 Thread Oliver Hartkopp
Hello Oleksij, I assume there is some ndev->ml_priv value set - but not from a CAN netdevice. What was the reason to fiddle with the 'priv' stuff in j1939_netdev_notify() before checking if it was a CAN device? Would this patch fix the issue then? diff --git a/net/can/j1939/main.c b/net/ca

general protection fault in j1939_netdev_notify (2)

2020-12-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d635a69d Merge tag 'net-next-5.11' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1315f12350 kernel config: https://syzkaller.appspot.com/x/.config?x=c3556e4856b17a95 das