Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-13 Thread Greg Kroah-Hartman
nge shown below will be > too large to test before merge window for 5.12 opens. > > The patch for fixing "general protection fault in > tomoyo_socket_sendmsg_permission" will kill kthread_get_run(). > Closing frequently crashing bug now is the better. > > On 2021/02/11

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-13 Thread Greg Kroah-Hartman
nge shown below will be > too large to test before merge window for 5.12 opens. > > The patch for fixing "general protection fault in > tomoyo_socket_sendmsg_permission" will kill kthread_get_run(). > Closing frequently crashing bug now is the better. > > On 2021/02/11

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-13 Thread Tetsuo Handa
for fixing "general protection fault in tomoyo_socket_sendmsg_permission" will kill kthread_get_run(). Closing frequently crashing bug now is the better. On 2021/02/11 22:40, Tetsuo Handa wrote: > I guess that we need to serialize attach operation and reset/detach > operations

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-12 Thread Shuah Khan
ix. part. Therefore, I strongly expect you to apply this version now. Is there a reproducer for this problem? There is no reproducer for "general protection fault in tomoyo_socket_sendmsg_permission" problem, but the race condition is explained at https://lkml.kernel.org/r/676d4518-0faa

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-11 Thread Tetsuo Handa
Right. I would like to get a clear understanding of how this condition >>>> is triggered. I am not saying this isn't a problem. Understanding how >>>> it is triggered helps find the best fix. >>> >>> part. Therefore, I strongly expect you to apply this versi

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-11 Thread Tetsuo Handa
;> fix. >> >> As I said at >> https://lkml.kernel.org/r/f8cae6b1-8f84-0e6a-7d9c-fc4aec68f...@i-love.sakura.ne.jp >> , >> the as-is patch is effectively a complete fix. And applying the as-is patch >> should help spending >> syzbot resources

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-11 Thread Shuah Khan
-love.sakura.ne.jp , the as-is patch is effectively a complete fix. And applying the as-is patch should help spending syzbot resources for reproducing "general protection fault in tomoyo_socket_sendmsg_permission" with debug printk() patch applied, which in turn will help you in Right. I

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Tetsuo Handa
patch is effectively a complete fix. And applying the as-is patch should help spending syzbot resources for reproducing "general protection fault in tomoyo_socket_sendmsg_permission" with debug printk() patch applied, which in turn will help you in > Right. I would like to get a clear u

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Shuah Khan
. What are these fix suggestions? "general protection fault in tomoyo_socket_sendmsg_permission" is a NULL pointer dereference which can happen if vhci_device_reset() and/or vhci_device_init() (which does vdev->ud.tcp_socket = NULL;) were unexpectedly called. There is no reproducer, and

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Tetsuo Handa
se fix suggestions? "general protection fault in tomoyo_socket_sendmsg_permission" is a NULL pointer dereference which can happen if vhci_device_reset() and/or vhci_device_init() (which does vdev->ud.tcp_socket = NULL;) were unexpectedly called. There is no reproducer, and (as far as I k

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Shuah Khan
On 1/29/21 7:25 PM, Tetsuo Handa wrote: On 2021/01/30 6:18, Shuah Khan wrote: In this console log: It seems "this console log" refers to https://syzkaller.appspot.com/x/log.txt?x=1045303450 . 06:57:50 executing program 1: socketpair$tipc(0x1e, 0x2, 0x0,

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-30 Thread Tetsuo Handa
On 2021/01/30 6:18, Shuah Khan wrote: > In this console log: It seems "this console log" refers to https://syzkaller.appspot.com/x/log.txt?x=1045303450 . > > 06:57:50 executing program 1: > socketpair$tipc(0x1e, 0x2, 0x0, &(0x7fc0)={0x}) >

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-29 Thread Shuah Khan
On 1/29/21 10:08 AM, Tetsuo Handa wrote: On 2021/01/30 1:05, Shuah Khan wrote: Since "general protection fault in tomoyo_socket_sendmsg_permission" is caused by unexpectedly resetting ud->tcp_socket to NULL without waiting for tx thread to terminate, tracing the ordering of ev

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-29 Thread Tetsuo Handa
On 2021/01/30 1:05, Shuah Khan wrote: >> Since "general protection fault in tomoyo_socket_sendmsg_permission" is >> caused by >> unexpectedly resetting ud->tcp_socket to NULL without waiting for tx thread >> to >> terminate, tracing the order

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-28 Thread Tetsuo Handa
ight make it easier to reproduce the problem. > > I am unable to reproduce the problem using the reproducer and running > multiple instances of the reproducer. Since syzkaller cannot find a reproducer for "general protection fault in tomoyo_socket_sendmsg_permission", and you ca

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-27 Thread Tetsuo Handa
On 2020/11/14 2:14, Shuah Khan wrote: > On 11/13/20 5:00 AM, Hillf Danton wrote: >> Thu, 12 Nov 2020 23:21:26 -0800 >>> syzbot found the following issue on: >>> >>> HEAD commit:    9dbc1c03 Merge tag 'xfs-5.10-fixes-3' of git://git.kernel... >>> git tree:   upstream >>> console output:

Re: general protection fault in tomoyo_socket_sendmsg_permission

2020-11-13 Thread Shuah Khan
On 11/13/20 5:00 AM, Hillf Danton wrote: Thu, 12 Nov 2020 23:21:26 -0800 syzbot found the following issue on: HEAD commit:9dbc1c03 Merge tag 'xfs-5.10-fixes-3' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1045303450 kernel

general protection fault in tomoyo_socket_sendmsg_permission

2020-11-12 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:9dbc1c03 Merge tag 'xfs-5.10-fixes-3' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1045303450 kernel config: https://syzkaller.appspot.com/x/.config?x=1735b7978b1c3721