Re: hci_sock.c build failure

2007-09-13 Thread Marcel Holtmann
Hi Toralf, > I'm wondering why the build failure wasn't fixed by a patch like this: > > > diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c > index 5ccea5f..85416bb 100644 > --- a/net/bluetooth/hci_sock.c > +++ b/net/bluetooth/hci_sock.c > @@ -348,8 +348,6 @@ static inline void

Re: hci_sock.c build failure

2007-09-13 Thread Toralf Förster
Hello, I'm wondering why the build failure wasn't fixed by a patch like this: diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index 5ccea5f..85416bb 100644 --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -348,8 +348,6 @@ static inline void hci_sock_cmsg(struct

Re: hci_sock.c build failure

2007-09-13 Thread Toralf Förster
Hello, I'm wondering why the build failure wasn't fixed by a patch like this: diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index 5ccea5f..85416bb 100644 --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -348,8 +348,6 @@ static inline void hci_sock_cmsg(struct

Re: hci_sock.c build failure

2007-09-13 Thread Marcel Holtmann
Hi Toralf, I'm wondering why the build failure wasn't fixed by a patch like this: diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index 5ccea5f..85416bb 100644 --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -348,8 +348,6 @@ static inline void

Re: hci_sock.c build failure

2007-09-12 Thread Marcel Holtmann
Hi Dave, > > It's not even a randconfig issue, my build dies too (this is Linus's > > current tree.) > > > > Time to poke through the 10 bluetooth patches that were just added... > > I'll push the following fix to Linus. the patch looks absolutely fine to me. You can put an Acked-by line to

Re: hci_sock.c build failure

2007-09-12 Thread Coly Li
Coly Li 写道: > David Miller 写道: >> From: Greg KH <[EMAIL PROTECTED]> >> Date: Wed, 12 Sep 2007 05:02:53 -0700 >> >>> It's not even a randconfig issue, my build dies too (this is Linus's >>> current tree.) >>> >>> Time to poke through the 10 bluetooth patches that were just added... >> I'll push the

Re: hci_sock.c build failure

2007-09-12 Thread Coly Li
David Miller 写道: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 12 Sep 2007 05:02:53 -0700 > >> It's not even a randconfig issue, my build dies too (this is Linus's >> current tree.) >> >> Time to poke through the 10 bluetooth patches that were just added... > > I'll push the following fix to

Re: hci_sock.c build failure

2007-09-12 Thread Robert P. J. Day
On Wed, 12 Sep 2007, Greg KH wrote: > On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > > Hi, > > > > I did a make randconfig and then make C=1. > > > > hci_sock.c fails to build because it doesnt know compat_timeval (i > > guess). > > > > find the error message and the config

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 05:07:26 -0700 > No, this is worse, i386 doesn't have a compat_timeval structure defined, > nor does any other 32 bit platform. > > Marcel, I think you need to use a different structure, care to fix this > up? Ok, then see the patch I

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 05:02:53 -0700 > It's not even a randconfig issue, my build dies too (this is Linus's > current tree.) > > Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to Linus. >From

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 05:04:07 -0700 > It was 767c5eb5d35aeb85987143f0a730bc21d3ecfb3d that caused it. It > needs a .h file added to the file, patch forthcoming... Ok, I though it was a CONFIG_COMPAT ifdef issue, feel free to push the header include fix. - To

Re: hci_sock.c build failure

2007-09-12 Thread S.Çağlar Onur
12 Eyl 2007 Çar tarihinde, Greg KH şunları yazmıştı: > No, this is worse, i386 doesn't have a compat_timeval structure defined, > nor does any other 32 bit platform. > > Marcel, I think you need to use a different structure, care to fix this > up? I sent a patch for this problem about ~4 hours

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 05:04:07AM -0700, Greg KH wrote: > On Wed, Sep 12, 2007 at 05:02:53AM -0700, Greg KH wrote: > > On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > > > Hi, > > > > > > I did a make randconfig and then make C=1. > > > > > > hci_sock.c fails to build because it

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 05:02:53AM -0700, Greg KH wrote: > On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > > Hi, > > > > I did a make randconfig and then make C=1. > > > > hci_sock.c fails to build because it doesnt know compat_timeval (i > > guess). > > > > find the error

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > Hi, > > I did a make randconfig and then make C=1. > > hci_sock.c fails to build because it doesnt know compat_timeval (i > guess). > > find the error message and the config attached. It's not even a randconfig issue, my build dies

hci_sock.c build failure

2007-09-12 Thread Andre Haupt
Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know compat_timeval (i guess). find the error message and the config attached. regards, Andre LD net/ax25/ax25.o LD net/ax25/built-in.o CHECK net/bluetooth/af_bluetooth.c CC

Re: hci_sock.c build failure

2007-09-12 Thread Coly Li
Coly Li 写道: David Miller 写道: From: Greg KH [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 05:02:53 -0700 It's not even a randconfig issue, my build dies too (this is Linus's current tree.) Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to

Re: hci_sock.c build failure

2007-09-12 Thread Marcel Holtmann
Hi Dave, It's not even a randconfig issue, my build dies too (this is Linus's current tree.) Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to Linus. the patch looks absolutely fine to me. You can put an Acked-by line to it. Sorry

hci_sock.c build failure

2007-09-12 Thread Andre Haupt
Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know compat_timeval (i guess). find the error message and the config attached. regards, Andre LD net/ax25/ax25.o LD net/ax25/built-in.o CHECK net/bluetooth/af_bluetooth.c CC

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know compat_timeval (i guess). find the error message and the config attached. It's not even a randconfig issue, my build dies too

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 05:02:53AM -0700, Greg KH wrote: On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know compat_timeval (i guess). find the error message and the config

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 05:04:07AM -0700, Greg KH wrote: On Wed, Sep 12, 2007 at 05:02:53AM -0700, Greg KH wrote: On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 05:02:53 -0700 It's not even a randconfig issue, my build dies too (this is Linus's current tree.) Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to Linus. From

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 05:04:07 -0700 It was 767c5eb5d35aeb85987143f0a730bc21d3ecfb3d that caused it. It needs a .h file added to the file, patch forthcoming... Ok, I though it was a CONFIG_COMPAT ifdef issue, feel free to push the header include fix. - To

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 05:07:26 -0700 No, this is worse, i386 doesn't have a compat_timeval structure defined, nor does any other 32 bit platform. Marcel, I think you need to use a different structure, care to fix this up? Ok, then see the patch I posted

Re: hci_sock.c build failure

2007-09-12 Thread Robert P. J. Day
On Wed, 12 Sep 2007, Greg KH wrote: On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know compat_timeval (i guess). find the error message and the config attached. It's not

Re: hci_sock.c build failure

2007-09-12 Thread Coly Li
David Miller 写道: From: Greg KH [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 05:02:53 -0700 It's not even a randconfig issue, my build dies too (this is Linus's current tree.) Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to Linus. From