Re: hfi1 use of PCI internals

On Fri, Jun 17, 2016 at 06:05:43PM -0400, Ashutosh Dixit wrote: > On Thu, Jun 16 2016 at 04:08:17 PM, Bjorn Helgaas wrote: > > > > That's a good start, but leads to more questions. For example, it > > doesn't answer the obvious question of why the driver needs to > >

Re: hfi1 use of PCI internals

On Fri, Jun 17, 2016 at 06:05:43PM -0400, Ashutosh Dixit wrote: > On Thu, Jun 16 2016 at 04:08:17 PM, Bjorn Helgaas wrote: > > > > That's a good start, but leads to more questions. For example, it > > doesn't answer the obvious question of why the driver needs to > > enable/disable ASPM from

Re: hfi1 use of PCI internals

On Thu, Jun 16 2016 at 04:08:17 PM, Bjorn Helgaas wrote: > > That's a good start, but leads to more questions. For example, it > doesn't answer the obvious question of why the driver needs to > enable/disable ASPM from interrupt context. For power saving reasons we keep ASPM

Re: hfi1 use of PCI internals

On Thu, Jun 16 2016 at 04:08:17 PM, Bjorn Helgaas wrote: > > That's a good start, but leads to more questions. For example, it > doesn't answer the obvious question of why the driver needs to > enable/disable ASPM from interrupt context. For power saving reasons we keep ASPM L1 enabled, but

Re: hfi1 use of PCI internals

On Thu, Jun 16, 2016 at 03:08:17PM -0500, Bjorn Helgaas wrote: As far as I can tell, none of these PCI questions were raised on linux-pci, so we never even had a chance to have a conversation about them. I'll let Ashutosh handle the technical details here since he is most familiar with the

Re: hfi1 use of PCI internals

On Thu, Jun 16, 2016 at 03:08:17PM -0500, Bjorn Helgaas wrote: As far as I can tell, none of these PCI questions were raised on linux-pci, so we never even had a chance to have a conversation about them. I'll let Ashutosh handle the technical details here since he is most familiar with the

Re: hfi1 use of PCI internals

On Thu, Jun 16, 2016 at 02:48:30PM -0400, Ashutosh Dixit wrote: > On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > >

Re: hfi1 use of PCI internals

On Thu, Jun 16, 2016 at 02:48:30PM -0400, Ashutosh Dixit wrote: > On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > > configuration, e.g., see

Re: hfi1 use of PCI internals

On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. > > I know there have

Re: hfi1 use of PCI internals

On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. > > I know there have been lots of ASPM

hfi1 use of PCI internals

I noticed drivers/infiniband/hw/hfi1 got moved from staging to drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. I know there have been lots of ASPM issues, both hardware problems and Linux kernel problems, but it is

hfi1 use of PCI internals

I noticed drivers/infiniband/hw/hfi1 got moved from staging to drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. I know there have been lots of ASPM issues, both hardware problems and Linux kernel problems, but it is