Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-20 Thread Rich Felker
On Mon, Jul 20, 2020 at 10:53:26AM -0400, Rich Felker wrote: > On Mon, Jul 20, 2020 at 03:42:38PM +0200, John Paul Adrian Glaubitz wrote: > > Hi Christoph! > > > > On 7/20/20 3:38 PM, Christoph Hellwig wrote: > > > On Wed, Jul 15, 2020 at 01:12:33AM +0200, John Paul Adrian Glaubitz wrote: > > >>

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-20 Thread Rich Felker
On Mon, Jul 20, 2020 at 03:42:38PM +0200, John Paul Adrian Glaubitz wrote: > Hi Christoph! > > On 7/20/20 3:38 PM, Christoph Hellwig wrote: > > On Wed, Jul 15, 2020 at 01:12:33AM +0200, John Paul Adrian Glaubitz wrote: > >> Hello! > >> > >> I have applied Christoph's full series on top of Linus'

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-20 Thread John Paul Adrian Glaubitz
Hi Christoph! On 7/20/20 3:38 PM, Christoph Hellwig wrote: > On Wed, Jul 15, 2020 at 01:12:33AM +0200, John Paul Adrian Glaubitz wrote: >> Hello! >> >> I have applied Christoph's full series on top of Linus' tree and I can >> confirm that >> the kernel boots fine on my SH-7785LCR board. >> >>

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-20 Thread Christoph Hellwig
On Wed, Jul 15, 2020 at 01:12:33AM +0200, John Paul Adrian Glaubitz wrote: > Hello! > > I have applied Christoph's full series on top of Linus' tree and I can > confirm that > the kernel boots fine on my SH-7785LCR board. > > Thus, for the whole series of patches: > > Tested-by: John Paul

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
On 7/16/20 9:28 PM, Peter Zijlstra wrote: > For some reason I had a whole bunch of junk left in my checkout and had > to basically: rm `git status -s | awk '{print $2}'`. > > Sorry for the noise. > > OK, let me go try my own patches :-) FWIW, I just successfully built the "defconfig"

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread Peter Zijlstra
On Thu, Jul 16, 2020 at 08:14:38PM +0200, John Paul Adrian Glaubitz wrote: > Hi Peter! > > On 7/16/20 2:04 PM, pet...@infradead.org wrote: > > On Thu, Jul 16, 2020 at 01:37:20PM +0200, pet...@infradead.org wrote: > >> $ /opt/cross/bin/sh4-linux-gcc --version > >> sh4-linux-gcc (GCC) 10.1.0 > > >

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
Hi Peter! On 7/16/20 2:04 PM, pet...@infradead.org wrote: > On Thu, Jul 16, 2020 at 01:37:20PM +0200, pet...@infradead.org wrote: >> $ /opt/cross/bin/sh4-linux-gcc --version >> sh4-linux-gcc (GCC) 10.1.0 > > $ git checkout origin/master # linus' tree > $ mkdir sh-defconfig > $ make

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread peterz
On Thu, Jul 16, 2020 at 01:37:20PM +0200, pet...@infradead.org wrote: > $ /opt/cross/bin/sh4-linux-gcc --version > sh4-linux-gcc (GCC) 10.1.0 $ git checkout origin/master # linus' tree $ mkdir sh-defconfig $ make O=sh-defconfig/ ARCH=sh CROSS_COMPILE=/opt/cross/bin/sh4-linux- defconfig #

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread peterz
On Thu, Jul 16, 2020 at 01:03:36PM +0200, John Paul Adrian Glaubitz wrote: > Hi Peter! > > On 7/16/20 1:01 PM, pet...@infradead.org wrote: > >> The build fails with: > >> > >> CC mm/mmu_gather.o > >> mm/mmu_gather.c: In function ‘tlb_table_invalidate’: > >> mm/mmu_gather.c:180:6: error:

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
Hi Geert! On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > Any plans to take "[PATCH v2 0/9] sh: Modernize printing of kernel messages"? > https://lore.kernel.org/r/20200617143639.18315-1-geert+rene...@glider.be @Rich: Any chance we can pick this one up? Adrian -- .''`. John Paul Adrian

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
On 7/15/20 6:18 PM, John Paul Adrian Glaubitz wrote: > Found the culprit: > > c5b27a889da92f4a969d61df77bd4f79ffce57c9 is the first bad commit > commit c5b27a889da92f4a969d61df77bd4f79ffce57c9 > Author: Peter Zijlstra > Date: Tue Sep 4 14:45:04 2018 +0200 > > sh/tlb: Convert SH to generic

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
Hi Peter! On 7/16/20 1:01 PM, pet...@infradead.org wrote: >> The build fails with: >> >> CC mm/mmu_gather.o >> mm/mmu_gather.c: In function ‘tlb_table_invalidate’: >> mm/mmu_gather.c:180:6: error: implicit declaration of function >> ‘tlb_needs_table_invalidate’; did you mean

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread peterz
On Thu, Jul 16, 2020 at 12:54:51PM +0200, John Paul Adrian Glaubitz wrote: > Hi Peter! > > On 7/16/20 12:29 PM, pet...@infradead.org wrote: > >> Then Aneesh got a bunch of those patches merged because he needed it for > >> Power, but the rest bitrotted again. > >> > >> Let me rebase/refresh the

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
Hi Peter! On 7/16/20 12:29 PM, pet...@infradead.org wrote: >> Then Aneesh got a bunch of those patches merged because he needed it for >> Power, but the rest bitrotted again. >> >> Let me rebase/refresh the rest of that and send it out again. > > OK, latest patches here: > >

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread peterz
On Thu, Jul 16, 2020 at 11:40:39AM +0200, Peter Zijlstra wrote: > On Wed, Jul 15, 2020 at 08:21:27PM +0200, Geert Uytterhoeven wrote: > > > Oh, we actually discussed that: > > https://lore.kernel.org/linux-mm/20191204133454.gw2...@hirez.programming.kicks-ass.net/ > > but there was no

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread John Paul Adrian Glaubitz
Hi Peter! On 7/16/20 11:40 AM, Peter Zijlstra wrote: > On Wed, Jul 15, 2020 at 08:21:27PM +0200, Geert Uytterhoeven wrote: > >> Oh, we actually discussed that: >> https://lore.kernel.org/linux-mm/20191204133454.gw2...@hirez.programming.kicks-ass.net/ >> but there was no conclusion... > > Urgh..

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-16 Thread Peter Zijlstra
On Wed, Jul 15, 2020 at 08:21:27PM +0200, Geert Uytterhoeven wrote: > Oh, we actually discussed that: > https://lore.kernel.org/linux-mm/20191204133454.gw2...@hirez.programming.kicks-ass.net/ > but there was no conclusion... Urgh.. clearly that fell off the table :-( So yes, that patch works,

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
On 7/15/20 8:21 PM, Geert Uytterhoeven wrote: >> CC'ing the author (Peter Zijlstra ). > > Oh, we actually discussed that: > https://lore.kernel.org/linux-mm/20191204133454.gw2...@hirez.programming.kicks-ass.net/ > but there was no conclusion... Aha, interesting. The question is whether someone

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread Geert Uytterhoeven
On Wed, Jul 15, 2020 at 6:18 PM John Paul Adrian Glaubitz wrote: > On 7/15/20 4:37 PM, John Paul Adrian Glaubitz wrote: > > Okay, kernel 5.0.0 does not suffer from this bug. So I should be able to > > bisect > > this particular issue. > > > > I'm glad I don't have to start bisecting with earlier

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
On 7/15/20 4:37 PM, John Paul Adrian Glaubitz wrote: > Okay, kernel 5.0.0 does not suffer from this bug. So I should be able to > bisect > this particular issue. > > I'm glad I don't have to start bisecting with earlier kernels because these > won't build easily with my current toolchain based

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
On 7/15/20 4:37 PM, John Paul Adrian Glaubitz wrote: > Will report once I found the bad commit that introduced the problem. git bisect lead me to a merge commit: glaubitz@epyc:..glaubitz/linux> git bisect log git bisect start # good: [1c163f4c7b3f621efff9b28a47abb36f7378d783] Linux 5.0 git

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
Hi Geert! On 7/15/20 10:27 AM, John Paul Adrian Glaubitz wrote: >> Lemme gues: does commit 002ae7057069538a ("mm, dump_page(): do not crash >> with invalid mapping pointer") in v5.8-rc1 help? > > Hmm, it seems I already have that patch (I'm using Linus' main tree): > > commit

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
Hi! On 7/15/20 10:11 AM, Geert Uytterhoeven wrote: >> Btw, booting with systemd as init causes a lot of hickups which I didn't see >> with 3.16: > >> [ 25.184000] BUG: Bad page state in process systemd-hiberna pfn:5d91a > > Lemme gues: does commit 002ae7057069538a ("mm, dump_page(): do not

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread Geert Uytterhoeven
Hi Adrian, On Wed, Jul 15, 2020 at 9:51 AM John Paul Adrian Glaubitz wrote: > On 7/15/20 9:46 AM, John Paul Adrian Glaubitz wrote: > > Indeed, it does. This patch should be picked up as well. > > > > Kernel boots without any errors now. > > Btw, booting with systemd as init causes a lot of

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread Geert Uytterhoeven
Hi Adrian, On Wed, Jul 15, 2020 at 9:46 AM John Paul Adrian Glaubitz wrote: > On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > >> [5.464000] WARNING: CPU: 0 PID: 1 at mm/slab.c:2589 > >> cache_alloc_refill+0x216/0x6a0 > >> [5.464000] Modules linked in: > >> [5.464000] > >> [

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread Geert Uytterhoeven
Hi Adrian, On Wed, Jul 15, 2020 at 9:37 AM John Paul Adrian Glaubitz wrote: > On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > > On Wed, Jul 15, 2020 at 1:14 AM John Paul Adrian Glaubitz > > wrote: > >> However, independent of Christoph's series, the kernels throws two > >> backtraces during >

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
On 7/15/20 9:46 AM, John Paul Adrian Glaubitz wrote: > Indeed, it does. This patch should be picked up as well. > > Kernel boots without any errors now. Btw, booting with systemd as init causes a lot of hickups which I didn't see with 3.16: [ 25.184000] 9d903e2c [ 25.184000] 8062124c [

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: >> [5.464000] WARNING: CPU: 0 PID: 1 at mm/slab.c:2589 >> cache_alloc_refill+0x216/0x6a0 >> [5.464000] Modules linked in: >> [5.464000] >> [5.464000] CPU: 0 PID: 1 Comm: swapper Not tainted >> 5.8.0-rc5-00026-g22b7a96ece82 #3 >> [

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
Hi Geert! On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > Hi Adrian, > > On Wed, Jul 15, 2020 at 1:14 AM John Paul Adrian Glaubitz > wrote: >> However, independent of Christoph's series, the kernels throws two >> backtraces during >> boot which I think should require a git bisect (unless I

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread Geert Uytterhoeven
Hi Adrian, On Wed, Jul 15, 2020 at 1:14 AM John Paul Adrian Glaubitz wrote: > However, independent of Christoph's series, the kernels throws two backtraces > during > boot which I think should require a git bisect (unless I missed a > configuration option > as I trimmed down the kernel a bit

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
On 7/15/20 5:12 AM, Rich Felker wrote: >> See the traces below and let me know what you think. > > I've got a slightly earlier version (my for-next) built for qemu r2d > board, and don't get any such messages. Do you have a lock-debugging > option enabled that's catching a problem, perhaps?

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread Rich Felker
On Wed, Jul 15, 2020 at 01:12:33AM +0200, John Paul Adrian Glaubitz wrote: > Hello! > > I have applied Christoph's full series on top of Linus' tree and I can > confirm that > the kernel boots fine on my SH-7785LCR board. > > Thus, for the whole series of patches: > > Tested-by: John Paul

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread John Paul Adrian Glaubitz
On 7/15/20 1:12 AM, John Paul Adrian Glaubitz wrote: > See the traces below and let me know what you think. (The second trace is redundant, I actually meant to post the two traces only and not the whole kernel boot sequence). Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread John Paul Adrian Glaubitz
Hello! I have applied Christoph's full series on top of Linus' tree and I can confirm that the kernel boots fine on my SH-7785LCR board. Thus, for the whole series of patches: Tested-by: John Paul Adrian Glaubitz However, independent of Christoph's series, the kernels throws two backtraces

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread John Paul Adrian Glaubitz
On 7/14/20 5:59 PM, Rich Felker wrote: > I'd like to have a way to test the DMA changes or testing feedback > from someone using an affected configuration just because they're > sufficiently nontrivial (Adrian might be able to do this? If so that'd > be great; if not let me know if it's testable

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread Rich Felker
On Tue, Jul 14, 2020 at 02:31:00PM +0200, John Paul Adrian Glaubitz wrote: > Hi Christoph! > > On 7/14/20 2:18 PM, Christoph Hellwig wrote: > > can you take a look and possibly pick up the series below that untangles > > and sorts out minor issues with the sh ioremap and dma code? > > > > I sent

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread John Paul Adrian Glaubitz
Hi Christoph! On 7/14/20 2:18 PM, Christoph Hellwig wrote: > can you take a look and possibly pick up the series below that untangles > and sorts out minor issues with the sh ioremap and dma code? > > I sent this out a few times, but never got an answer. If you don't > want to pick up the

ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread Christoph Hellwig
Hi Yoshinori and Rich, can you take a look and possibly pick up the series below that untangles and sorts out minor issues with the sh ioremap and dma code? I sent this out a few times, but never got an answer. If you don't want to pick up the series I can also take it through one of my trees