Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-17 Thread Rusty Russell
In message <[EMAIL PROTECTED]> you write: >Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST) >From: "Mohammad A. Haque" <[EMAIL PROTECTED]> > >I'll be trying in a few hours. > > Meanwhile for people wanting the crashes to be fixed, please > apply this patch. > > This was _always_ broken,

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-17 Thread Rusty Russell
In message [EMAIL PROTECTED] you write: Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST) From: "Mohammad A. Haque" [EMAIL PROTECTED] I'll be trying in a few hours. Meanwhile for people wanting the crashes to be fixed, please apply this patch. This was _always_ broken, and really

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-15 Thread Tom Leete
"Mohammad A. Haque" wrote: > > I do the following > > sudo modprobe iptable_nat > > Module Size Used by > iptable_nat17440 0 (unused) > ip_conntrack 19808 1 [iptable_nat] > ip_tables 12320 3 [iptable_nat] > > Oops start flying by

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-15 Thread Jasper Spaans
On Thu, Dec 14, 2000 at 05:50:35PM -0500, Mohammad A. Haque wrote: [zap] > Oops start flying by when I access via NFS. > > If you need the actual Oops messages we're gonna have to get someone > who can setup a serial console. I captured one on my console, anyone interested please drop me a

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-15 Thread Jasper Spaans
On Thu, Dec 14, 2000 at 05:50:35PM -0500, Mohammad A. Haque wrote: [zap] Oops start flying by when I access via NFS. If you need the actual Oops messages we're gonna have to get someone who can setup a serial console. I captured one on my console, anyone interested please drop me a note.

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-15 Thread Tom Leete
"Mohammad A. Haque" wrote: I do the following sudo modprobe iptable_nat Module Size Used by iptable_nat17440 0 (unused) ip_conntrack 19808 1 [iptable_nat] ip_tables 12320 3 [iptable_nat] Oops start flying by when I

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Tom Leete
"David S. Miller" wrote: > >Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST) >From: "Mohammad A. Haque" <[EMAIL PROTECTED]> > >I'll be trying in a few hours. > > Meanwhile for people wanting the crashes to be fixed, please > apply this patch. > > This was _always_ broken, and really

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread Harald Welte
On Fri, Dec 15, 2000 at 01:48:32AM +0100, Andi Kleen wrote: > > Also is it sure that the backtrace involves ip_rcv ? A more likely > guess is that it happens during the IP_LOCAL_OUT hook, when skb->dev > isn't set yet, but conntrack already has to already reassemble fragments. Oh, thanks Andi.

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread Andi Kleen
On Thu, Dec 14, 2000 at 04:11:10PM -0800, David S. Miller wrote: >Date: Fri, 15 Dec 2000 01:20:00 +0100 >From: Harald Welte <[EMAIL PROTECTED]> > >Or is there something wrong with: > >- packet arrives in net/ipv4/ip_input.c:ip_rcv() >- netfilter hook NF_IP_PRE_ROUTING is

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread David S. Miller
Date: Fri, 15 Dec 2000 01:20:00 +0100 From: Harald Welte <[EMAIL PROTECTED]> Or is there something wrong with: - packet arrives in net/ipv4/ip_input.c:ip_rcv() - netfilter hook NF_IP_PRE_ROUTING is called - net/ipv4/netfilter/ip_conntrack_core.c:ip_conntrack_in() is called

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread Harald Welte
On Thu, Dec 14, 2000 at 11:55:43AM -0800, David S. Miller wrote: >Date: Thu, 14 Dec 2000 12:07:38 -0800 (PST) >From: Ion Badulescu <[EMAIL PROTECTED]> > >I'm afraid I won't be able to answer this question, since I'm >leaving for a 3-week vacation in about 50 minutes and I need my

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
Problem only happens when ip_conntrack is loaded. On Thu, 14 Dec 2000, Mohammad A. Haque wrote: > I do the following > > sudo modprobe iptable_nat > > Module Size Used by > iptable_nat17440 0 (unused) > ip_conntrack 19808 1 [iptable_nat] >

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
I do the following sudo modprobe iptable_nat Module Size Used by iptable_nat17440 0 (unused) ip_conntrack 19808 1 [iptable_nat] ip_tables 12320 3 [iptable_nat] Oops start flying by when I access via NFS. If you need the actual

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Bob_Tracy
Ion Badulescu wrote: > On Thu, 14 Dec 2000 07:15:04 -0500, Mohammad A. Haque <[EMAIL PROTECTED]> wrote: > > Were you connected to a network or receiving/sending anything? > > ip_defrag is broken -- there is an obvious NULL pointer dereference > in it, introduced in test12. It doesn't hit

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
Just quick feedback. Test 1: Netfilter compiled into kernel. Netfilter configuration options as modules. Modules loaded. Using NFS, I got Oops (in fact I've never seen an Oops output infinitely before. Maybe it would have stopped if I waited.) Test 2:

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Bob_Tracy
Ion Badulescu wrote: > On Thu, 14 Dec 2000 07:15:04 -0500, Mohammad A. Haque <[EMAIL PROTECTED]> wrote: > > Were you connected to a network or receiving/sending anything? > > ip_defrag is broken -- there is an obvious NULL pointer dereference > in it, introduced in test12. It doesn't hit

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread David S. Miller
Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST) From: "Mohammad A. Haque" <[EMAIL PROTECTED]> I'll be trying in a few hours. Meanwhile for people wanting the crashes to be fixed, please apply this patch. This was _always_ broken, and really what netfilter is doing should have never

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
I'll be trying in a few hours. On Thu, 14 Dec 2000, Ion Badulescu wrote: > On Thu, 14 Dec 2000, David S. Miller wrote: > > > If you turn off netfilter, ip_conntrack, etc. does the OOPS still > > occur? > > I'm afraid I won't be able to answer this question, since I'm leaving for > a 3-week

Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread David S. Miller
Date: Thu, 14 Dec 2000 12:07:38 -0800 (PST) From: Ion Badulescu <[EMAIL PROTECTED]> I'm afraid I won't be able to answer this question, since I'm leaving for a 3-week vacation in about 50 minutes and I need my firewall functional until then. :-) Maybe other people who have seen

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Ion Badulescu
On Thu, 14 Dec 2000, David S. Miller wrote: > If you turn off netfilter, ip_conntrack, etc. does the OOPS still > occur? I'm afraid I won't be able to answer this question, since I'm leaving for a 3-week vacation in about 50 minutes and I need my firewall functional until then. :-) Maybe other

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread David S. Miller
Date: Thu, 14 Dec 2000 11:52:29 -0800 (PST) From: Ion Badulescu <[EMAIL PROTECTED]> The oops looks something like this. It was caught on serial console, and decoded on test11, so it doesn't have translation for module symbols. It if helps, this box is running ip_conntrack and

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Ion Badulescu
On Thu, 14 Dec 2000, David S. Miller wrote: >Date: Thu, 14 Dec 2000 10:38:01 -0800 >From: Ion Badulescu <[EMAIL PROTECTED]> > >I won't venture a fix, as I don't know the networking code well >enough. So far, no networking maintainer has had anything to say >about this

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread David S. Miller
Date:Thu, 14 Dec 2000 10:38:01 -0800 From: Ion Badulescu <[EMAIL PROTECTED]> I won't venture a fix, as I don't know the networking code well enough. So far, no networking maintainer has had anything to say about this bug on the list... Because this is the first most of us

ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Ion Badulescu
On Thu, 14 Dec 2000 07:15:04 -0500, Mohammad A. Haque <[EMAIL PROTECTED]> wrote: > Were you connected to a network or receiving/sending anything? ip_defrag is broken -- there is an obvious NULL pointer dereference in it, introduced in test12. It doesn't hit normally, because of path MTU

ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Ion Badulescu
On Thu, 14 Dec 2000 07:15:04 -0500, Mohammad A. Haque [EMAIL PROTECTED] wrote: Were you connected to a network or receiving/sending anything? ip_defrag is broken -- there is an obvious NULL pointer dereference in it, introduced in test12. It doesn't hit normally, because of path MTU discovery,

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Ion Badulescu
On Thu, 14 Dec 2000, David S. Miller wrote: Date: Thu, 14 Dec 2000 10:38:01 -0800 From: Ion Badulescu [EMAIL PROTECTED] I won't venture a fix, as I don't know the networking code well enough. So far, no networking maintainer has had anything to say about this bug on the

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread David S. Miller
Date: Thu, 14 Dec 2000 11:52:29 -0800 (PST) From: Ion Badulescu [EMAIL PROTECTED] The oops looks something like this. It was caught on serial console, and decoded on test11, so it doesn't have translation for module symbols. It if helps, this box is running ip_conntrack and the

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Bob_Tracy
Ion Badulescu wrote: On Thu, 14 Dec 2000 07:15:04 -0500, Mohammad A. Haque [EMAIL PROTECTED] wrote: Were you connected to a network or receiving/sending anything? ip_defrag is broken -- there is an obvious NULL pointer dereference in it, introduced in test12. It doesn't hit normally,

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
Just quick feedback. Test 1: Netfilter compiled into kernel. Netfilter configuration options as modules. Modules loaded. Using NFS, I got Oops (in fact I've never seen an Oops output infinitely before. Maybe it would have stopped if I waited.) Test 2:

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Ion Badulescu
On Thu, 14 Dec 2000, David S. Miller wrote: If you turn off netfilter, ip_conntrack, etc. does the OOPS still occur? I'm afraid I won't be able to answer this question, since I'm leaving for a 3-week vacation in about 50 minutes and I need my firewall functional until then. :-) Maybe other

Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread David S. Miller
Date: Thu, 14 Dec 2000 12:07:38 -0800 (PST) From: Ion Badulescu [EMAIL PROTECTED] I'm afraid I won't be able to answer this question, since I'm leaving for a 3-week vacation in about 50 minutes and I need my firewall functional until then. :-) Maybe other people who have seen

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Bob_Tracy
Ion Badulescu wrote: On Thu, 14 Dec 2000 07:15:04 -0500, Mohammad A. Haque [EMAIL PROTECTED] wrote: Were you connected to a network or receiving/sending anything? ip_defrag is broken -- there is an obvious NULL pointer dereference in it, introduced in test12. It doesn't hit normally,

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
I'll be trying in a few hours. On Thu, 14 Dec 2000, Ion Badulescu wrote: On Thu, 14 Dec 2000, David S. Miller wrote: If you turn off netfilter, ip_conntrack, etc. does the OOPS still occur? I'm afraid I won't be able to answer this question, since I'm leaving for a 3-week vacation in

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread David S. Miller
Date:Thu, 14 Dec 2000 10:38:01 -0800 From: Ion Badulescu [EMAIL PROTECTED] I won't venture a fix, as I don't know the networking code well enough. So far, no networking maintainer has had anything to say about this bug on the list... Because this is the first most of us

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread David S. Miller
Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST) From: "Mohammad A. Haque" [EMAIL PROTECTED] I'll be trying in a few hours. Meanwhile for people wanting the crashes to be fixed, please apply this patch. This was _always_ broken, and really what netfilter is doing should have never worked.

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread Harald Welte
On Thu, Dec 14, 2000 at 11:55:43AM -0800, David S. Miller wrote: Date: Thu, 14 Dec 2000 12:07:38 -0800 (PST) From: Ion Badulescu [EMAIL PROTECTED] I'm afraid I won't be able to answer this question, since I'm leaving for a 3-week vacation in about 50 minutes and I need my

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
I do the following sudo modprobe iptable_nat Module Size Used by iptable_nat17440 0 (unused) ip_conntrack 19808 1 [iptable_nat] ip_tables 12320 3 [iptable_nat] Oops start flying by when I access via NFS. If you need the actual

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread David S. Miller
Date: Fri, 15 Dec 2000 01:20:00 +0100 From: Harald Welte [EMAIL PROTECTED] Or is there something wrong with: - packet arrives in net/ipv4/ip_input.c:ip_rcv() - netfilter hook NF_IP_PRE_ROUTING is called - net/ipv4/netfilter/ip_conntrack_core.c:ip_conntrack_in() is called -

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread Andi Kleen
On Thu, Dec 14, 2000 at 04:11:10PM -0800, David S. Miller wrote: Date: Fri, 15 Dec 2000 01:20:00 +0100 From: Harald Welte [EMAIL PROTECTED] Or is there something wrong with: - packet arrives in net/ipv4/ip_input.c:ip_rcv() - netfilter hook NF_IP_PRE_ROUTING is called -

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Mohammad A. Haque
Problem only happens when ip_conntrack is loaded. On Thu, 14 Dec 2000, Mohammad A. Haque wrote: I do the following sudo modprobe iptable_nat Module Size Used by iptable_nat17440 0 (unused) ip_conntrack 19808 1 [iptable_nat] ip_tables

Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))

2000-12-14 Thread Harald Welte
On Fri, Dec 15, 2000 at 01:48:32AM +0100, Andi Kleen wrote: Also is it sure that the backtrace involves ip_rcv ? A more likely guess is that it happens during the IP_LOCAL_OUT hook, when skb-dev isn't set yet, but conntrack already has to already reassemble fragments. Oh, thanks Andi. This

Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)

2000-12-14 Thread Tom Leete
"David S. Miller" wrote: Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST) From: "Mohammad A. Haque" [EMAIL PROTECTED] I'll be trying in a few hours. Meanwhile for people wanting the crashes to be fixed, please apply this patch. This was _always_ broken, and really what netfilter