Re: isolate_lru_page on !head pages

2015-12-22 Thread Vlastimil Babka
On 12/15/2015 05:59 PM, Michal Hocko wrote: head page is what linked into LRU, but not nessesary the way we obtain the page to check. If we check PageLRU(pte_page(*pte)) it should produce the right result. I am not following you here. Any pfn walk could get to a tail page and if we happen to d

Re: isolate_lru_page on !head pages

2015-12-15 Thread Michal Hocko
On Tue 15-12-15 14:03:18, Kirill A. Shutemov wrote: > On Tue, Dec 15, 2015 at 09:52:33AM +0100, Michal Hocko wrote: > > On Mon 14-12-15 14:04:56, Kirill A. Shutemov wrote: > > > On Wed, Dec 09, 2015 at 02:02:05PM +0100, Michal Hocko wrote: > > > > Hi Kirill, > > > > > > [ sorry for late reply, jus

Re: isolate_lru_page on !head pages

2015-12-15 Thread Kirill A. Shutemov
On Tue, Dec 15, 2015 at 09:52:33AM +0100, Michal Hocko wrote: > On Mon 14-12-15 14:04:56, Kirill A. Shutemov wrote: > > On Wed, Dec 09, 2015 at 02:02:05PM +0100, Michal Hocko wrote: > > > Hi Kirill, > > > > [ sorry for late reply, just back from vacation. ] > > > > > while looking at the issue re

Re: isolate_lru_page on !head pages

2015-12-15 Thread Michal Hocko
On Mon 14-12-15 14:04:56, Kirill A. Shutemov wrote: > On Wed, Dec 09, 2015 at 02:02:05PM +0100, Michal Hocko wrote: > > Hi Kirill, > > [ sorry for late reply, just back from vacation. ] > > > while looking at the issue reported by Minchan [1] I have noticed that > > there is nothing to prevent fr

Re: isolate_lru_page on !head pages

2015-12-14 Thread Kirill A. Shutemov
On Wed, Dec 09, 2015 at 02:02:05PM +0100, Michal Hocko wrote: > Hi Kirill, [ sorry for late reply, just back from vacation. ] > while looking at the issue reported by Minchan [1] I have noticed that > there is nothing to prevent from "isolating" a tail page from LRU because > isolate_lru_page che

isolate_lru_page on !head pages

2015-12-09 Thread Michal Hocko
Hi Kirill, while looking at the issue reported by Minchan [1] I have noticed that there is nothing to prevent from "isolating" a tail page from LRU because isolate_lru_page checks PageLRU which is PAGEFLAG(LRU, lru, PF_HEAD) so it is checked on the head page rather than the given page directly but