[PATCH 02/13] kdbus: add header file

2015-01-16 Thread Greg Kroah-Hartman
From: Daniel Mack This patch adds the header file which describes the low-level transport protocol used by various ioctls. The header file is located in include/uapi/linux/ as it is shared between kernel and userspace, and it only contains data structure definitionsi, enums and #defines for

[PATCH 02/13] kdbus: add header file

2015-01-16 Thread Greg Kroah-Hartman
From: Daniel Mack dan...@zonque.org This patch adds the header file which describes the low-level transport protocol used by various ioctls. The header file is located in include/uapi/linux/ as it is shared between kernel and userspace, and it only contains data structure definitionsi, enums and

Re: kdbus: add header file

2014-11-21 Thread Daniel Mack
Hi Harald, On 11/21/2014 09:34 AM, Harald Hoyer wrote: > On 21.11.2014 06:02, Greg Kroah-Hartman wrote: >> From: Daniel Mack >> … > >> + >> +/** >> + * enum kdbus_make_flags - Flags for KDBUS_CMD_{BUS,EP,NS}_MAKE >> + * @KDBUS_MAKE_ACCESS_GROUP:Make the device node group-accessible >> +

Re: kdbus: add header file

2014-11-21 Thread Harald Hoyer
On 21.11.2014 06:02, Greg Kroah-Hartman wrote: > From: Daniel Mack > … > + > +/** > + * enum kdbus_make_flags - Flags for KDBUS_CMD_{BUS,EP,NS}_MAKE > + * @KDBUS_MAKE_ACCESS_GROUP: Make the device node group-accessible > + * @KDBUS_MAKE_ACCESS_WORLD: Make the device node world-accessible > + */

Re: kdbus: add header file

2014-11-21 Thread Harald Hoyer
On 21.11.2014 06:02, Greg Kroah-Hartman wrote: From: Daniel Mack dan...@zonque.org … + +/** + * enum kdbus_make_flags - Flags for KDBUS_CMD_{BUS,EP,NS}_MAKE + * @KDBUS_MAKE_ACCESS_GROUP: Make the device node group-accessible + * @KDBUS_MAKE_ACCESS_WORLD: Make the device node

Re: kdbus: add header file

2014-11-21 Thread Daniel Mack
Hi Harald, On 11/21/2014 09:34 AM, Harald Hoyer wrote: On 21.11.2014 06:02, Greg Kroah-Hartman wrote: From: Daniel Mack dan...@zonque.org … + +/** + * enum kdbus_make_flags - Flags for KDBUS_CMD_{BUS,EP,NS}_MAKE + * @KDBUS_MAKE_ACCESS_GROUP:Make the device node group-accessible

kdbus: add header file

2014-11-20 Thread Greg Kroah-Hartman
From: Daniel Mack This patch adds the header file which describes the low-level transport protocol used by various ioctls. The header file is located in include/uapi/linux/ as it is shared between kernel and userspace, and it only contains data structure definitionsi, enums and #defines for

kdbus: add header file

2014-11-20 Thread Greg Kroah-Hartman
From: Daniel Mack dan...@zonque.org This patch adds the header file which describes the low-level transport protocol used by various ioctls. The header file is located in include/uapi/linux/ as it is shared between kernel and userspace, and it only contains data structure definitionsi, enums and

Re: kdbus: add header file

2014-10-31 Thread Daniel Mack
On 10/30/2014 01:03 PM, Arnd Bergmann wrote: > On Thursday 30 October 2014 12:52:58 Daniel Mack wrote: >> Hmm, this is the header exported to userspace, so having enums in would >> make our lives easier, right? > > My point was that you never use the enum by type and the only place in > user

Re: kdbus: add header file

2014-10-31 Thread Daniel Mack
On 10/30/2014 01:03 PM, Arnd Bergmann wrote: On Thursday 30 October 2014 12:52:58 Daniel Mack wrote: Hmm, this is the header exported to userspace, so having enums in would make our lives easier, right? My point was that you never use the enum by type and the only place in user space where

Re: kdbus: add header file

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 12:52:58 Daniel Mack wrote: > On 10/30/2014 12:26 PM, Arnd Bergmann wrote: > > On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote: > > >> The nice thing about enums is of course that it helps with debugging > >> as gdb can show the string representation rather

Re: kdbus: add header file

2014-10-30 Thread Daniel Mack
On 10/30/2014 12:26 PM, Arnd Bergmann wrote: > On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote: >> The nice thing about enums is of course that it helps with debugging >> as gdb can show the string representation rather than the number, >> because in contrast to #defines, an enum is

Re: kdbus: add header file

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote: > On Thu, Oct 30, 2014 at 9:20 AM, Arnd Bergmann wrote: > > I think in general, using enum is great, but for ioctl command numbers, > > we probably want to have defines so the user space implementation can > > use #ifdef to see if the

Re: kdbus: add header file

2014-10-30 Thread Tom Gundersen
On Thu, Oct 30, 2014 at 9:20 AM, Arnd Bergmann wrote: > I think in general, using enum is great, but for ioctl command numbers, > we probably want to have defines so the user space implementation can > use #ifdef to see if the kernel version that it is being built for > knows a particular

Re: kdbus: add header file

2014-10-30 Thread Arnd Bergmann
On Wednesday 29 October 2014 15:00:46 Greg Kroah-Hartman wrote: > +enum kdbus_ioctl_type { > + KDBUS_CMD_BUS_MAKE =_IOW(KDBUS_IOCTL_MAGIC, 0x00, > +struct kdbus_cmd_make), > + KDBUS_CMD_DOMAIN_MAKE =

Re: kdbus: add header file

2014-10-30 Thread Arnd Bergmann
On Wednesday 29 October 2014 15:00:46 Greg Kroah-Hartman wrote: +enum kdbus_ioctl_type { + KDBUS_CMD_BUS_MAKE =_IOW(KDBUS_IOCTL_MAGIC, 0x00, +struct kdbus_cmd_make), + KDBUS_CMD_DOMAIN_MAKE = _IOW(KDBUS_IOCTL_MAGIC,

Re: kdbus: add header file

2014-10-30 Thread Tom Gundersen
On Thu, Oct 30, 2014 at 9:20 AM, Arnd Bergmann a...@arndb.de wrote: I think in general, using enum is great, but for ioctl command numbers, we probably want to have defines so the user space implementation can use #ifdef to see if the kernel version that it is being built for knows a

Re: kdbus: add header file

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote: On Thu, Oct 30, 2014 at 9:20 AM, Arnd Bergmann a...@arndb.de wrote: I think in general, using enum is great, but for ioctl command numbers, we probably want to have defines so the user space implementation can use #ifdef to see if

Re: kdbus: add header file

2014-10-30 Thread Daniel Mack
On 10/30/2014 12:26 PM, Arnd Bergmann wrote: On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote: The nice thing about enums is of course that it helps with debugging as gdb can show the string representation rather than the number, because in contrast to #defines, an enum is something

Re: kdbus: add header file

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 12:52:58 Daniel Mack wrote: On 10/30/2014 12:26 PM, Arnd Bergmann wrote: On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote: The nice thing about enums is of course that it helps with debugging as gdb can show the string representation rather than the

kdbus: add header file

2014-10-29 Thread Greg Kroah-Hartman
From: Daniel Mack This patch adds the header file which describes the low-level transport protocol used by various ioctls. The header file is located in include/uapi/linux/ as it is shared between kernel and userspace, and it only contains data structure definitionsi, enums and #defines for

kdbus: add header file

2014-10-29 Thread Greg Kroah-Hartman
From: Daniel Mack dan...@zonque.org This patch adds the header file which describes the low-level transport protocol used by various ioctls. The header file is located in include/uapi/linux/ as it is shared between kernel and userspace, and it only contains data structure definitionsi, enums and